From: Richard Henderson <richard.henderson@linaro.org>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: samuel.thibault@ens-lyon.org, qemu-devel@nongnu.org,
marcandre.lureau@redhat.com
Subject: Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system
Date: Mon, 13 May 2019 14:14:29 -0700 [thread overview]
Message-ID: <4a2f1364-b7d2-209e-3d17-ca1eef3b53e3@linaro.org> (raw)
In-Reply-To: <CAL1e-=hE4zMwDewsbD6=Kc32Ss9wcB-AyOtY-G=HhDKS9YMOoQ@mail.gmail.com>
On 5/11/19 5:47 AM, Aleksandar Markovic wrote:
>
> On May 10, 2019 10:36 PM, "Richard Henderson" <richard.henderson@linaro.org
> <mailto:richard.henderson@linaro.org>> wrote:
>>
>> For linux-user, there is no need to add slirp to the set of
>> git modules checked out, nor build it.
>>
>> This also avoids a makefile bug wrt insufficient dependencies
>> on subdir-slirp. If slirp/ is not initially present, the
>> dependencies that check it out are associated with softmmu,
>> which then generates a build error on slirp/ not present.
>>
>
> Hi,
>
> Does this work if only user mode targets are specified via ˊ--target-listˊ
> switch?
Yes. There is a bit of code that converts such a target list to the same
result as --disable-system, which is $softmmu = no.
> If no, the patch shoud be amended. If yes, the commit message should be
> extended.
Like what? I think it's pretty clear as is.
r~
next prev parent reply other threads:[~2019-05-13 21:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 20:34 [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system Richard Henderson
2019-05-11 5:48 ` Thomas Huth
2019-05-11 12:47 ` Aleksandar Markovic
2019-05-13 21:14 ` Richard Henderson [this message]
2019-05-14 19:15 ` Aleksandar Markovic
2019-05-15 10:07 ` Peter Maydell
2019-05-15 18:36 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a2f1364-b7d2-209e-3d17-ca1eef3b53e3@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aleksandar.m.mail@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.