All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: "Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system
Date: Wed, 15 May 2019 11:07:02 +0100	[thread overview]
Message-ID: <CAFEAcA9mU7OPhr1Koktzttj3nzXbr6i4DG6Wzy8tgVP95BkjxA@mail.gmail.com> (raw)
In-Reply-To: <CAL1e-=hsgj0oq_4VUX97KRm3eJovXLw4G28dXiU9X+XA6wsQ2A@mail.gmail.com>

On Tue, 14 May 2019 at 20:16, Aleksandar Markovic
<aleksandar.m.mail@gmail.com> wrote:
>
> On May 13, 2019 11:14 PM, "Richard Henderson" <richard.henderson@linaro.org>
> wrote:
> >
> > On 5/11/19 5:47 AM, Aleksandar Markovic wrote:
> > > If no, the patch shoud be amended. If yes, the commit message should be
> > > extended.
> >
> > Like what?  I think it's pretty clear as is.
> >
>
> Richard, no. In this case, there is a glaring discrepancy between the title
> and the functionality that the change provides. Much better title would be
> “configure: Disable slirp if no system mode target is selected”.
>
> I leave it to you to find out what can be improved in the commit message.

Aleksandar: I think this is not really a very productive stance to take.
Richard thinks the commit message is reasonable. If you have something
you would like him to change, I think we will reach a useful endpoint
much more quickly and smoothly if you suggest some new text, rather than
effectively saying "you need to think of something, and I'm going to keep
making you rewrite it until you telepathically figure out what the text
I wanted you to write is".

thanks
-- PMM


  reply	other threads:[~2019-05-15 10:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 20:34 [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system Richard Henderson
2019-05-11  5:48 ` Thomas Huth
2019-05-11 12:47 ` Aleksandar Markovic
2019-05-13 21:14   ` Richard Henderson
2019-05-14 19:15     ` Aleksandar Markovic
2019-05-15 10:07       ` Peter Maydell [this message]
2019-05-15 18:36         ` Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA9mU7OPhr1Koktzttj3nzXbr6i4DG6Wzy8tgVP95BkjxA@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=aleksandar.m.mail@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.