* [PATCH] scsi: scsi_transport_sas: Fix the following coccicheck warning:
@ 2022-12-27 2:32 KaiLong Wang
0 siblings, 0 replies; only message in thread
From: KaiLong Wang @ 2022-12-27 2:32 UTC (permalink / raw)
To: jejb, martin.petersen; +Cc: linux-scsi, linux-kernel
drivers/scsi/scsi_transport_sas.c:525:9-17: WARNING: use scnprintf or sprintf
drivers/scsi/scsi_transport_sas.c:572:8-16: WARNING: use scnprintf or sprintf
drivers/scsi/scsi_transport_sas.c:1180:9-17: WARNING: use scnprintf or sprintf
Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
---
drivers/scsi/scsi_transport_sas.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
index 74b99f2b0b74..5504067adcf1 100644
--- a/drivers/scsi/scsi_transport_sas.c
+++ b/drivers/scsi/scsi_transport_sas.c
@@ -522,7 +522,7 @@ show_sas_device_type(struct device *dev,
struct sas_phy *phy = transport_class_to_phy(dev);
if (!phy->identify.device_type)
- return snprintf(buf, 20, "none\n");
+ return sysfs_emit(buf, "none\n");
return get_sas_device_type_names(phy->identify.device_type, buf);
}
static DEVICE_ATTR(device_type, S_IRUGO, show_sas_device_type, NULL);
@@ -569,7 +569,7 @@ show_sas_phy_enable(struct device *dev, struct device_attribute *attr,
{
struct sas_phy *phy = transport_class_to_phy(dev);
- return snprintf(buf, 20, "%d\n", phy->enabled);
+ return sysfs_emit(buf, "%d\n", phy->enabled);
}
static DEVICE_ATTR(enable, S_IRUGO | S_IWUSR, show_sas_phy_enable,
@@ -1177,7 +1177,7 @@ show_sas_rphy_device_type(struct device *dev,
struct sas_rphy *rphy = transport_class_to_rphy(dev);
if (!rphy->identify.device_type)
- return snprintf(buf, 20, "none\n");
+ return sysfs_emit(buf, "none\n");
return get_sas_device_type_names(
rphy->identify.device_type, buf);
}
--
2.36.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-27 2:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-27 2:32 [PATCH] scsi: scsi_transport_sas: Fix the following coccicheck warning: KaiLong Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.