* [GIT PULL] amlogic Drivers updates for v6.2
@ 2022-11-22 15:24 ` Neil Armstrong
0 siblings, 0 replies; 11+ messages in thread
From: Neil Armstrong @ 2022-11-22 15:24 UTC (permalink / raw)
To: soc, arm; +Cc: linux-amlogic, linux-arm-kernel
Hi,
Here's an Amlogic Drivers change for v6.3, fixes memcpy vs iomem type warnings in meson_sm driver.
Neil
The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780:
Linux 6.1-rc1 (2022-10-16 15:36:24 -0700)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git tags/amlogic-drivers-for-v6.2
for you to fetch changes up to 7dc69c7d073e6004a281db8f7f15cf6ebf702ea0:
firmware: meson_sm: Fix memcpy vs iomem type warnings (2022-10-17 17:19:04 +0200)
----------------------------------------------------------------
Amlogic Drivers changes for v6.2:
- Fix memcpy vs iomem type warnings in meson_sm driver
----------------------------------------------------------------
Kees Cook (1):
firmware: meson_sm: Fix memcpy vs iomem type warnings
drivers/firmware/meson/meson_sm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 11+ messages in thread* [GIT PULL] amlogic Drivers updates for v6.2 @ 2022-11-22 15:24 ` Neil Armstrong 0 siblings, 0 replies; 11+ messages in thread From: Neil Armstrong @ 2022-11-22 15:24 UTC (permalink / raw) To: soc, arm; +Cc: linux-amlogic, linux-arm-kernel Hi, Here's an Amlogic Drivers change for v6.3, fixes memcpy vs iomem type warnings in meson_sm driver. Neil The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: Linux 6.1-rc1 (2022-10-16 15:36:24 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git tags/amlogic-drivers-for-v6.2 for you to fetch changes up to 7dc69c7d073e6004a281db8f7f15cf6ebf702ea0: firmware: meson_sm: Fix memcpy vs iomem type warnings (2022-10-17 17:19:04 +0200) ---------------------------------------------------------------- Amlogic Drivers changes for v6.2: - Fix memcpy vs iomem type warnings in meson_sm driver ---------------------------------------------------------------- Kees Cook (1): firmware: meson_sm: Fix memcpy vs iomem type warnings drivers/firmware/meson/meson_sm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* [GIT PULL] amlogic Drivers updates for v6.2 @ 2022-11-22 15:24 ` Neil Armstrong 0 siblings, 0 replies; 11+ messages in thread From: Neil Armstrong @ 2022-11-22 15:24 UTC (permalink / raw) To: soc, arm; +Cc: linux-amlogic, linux-arm-kernel Hi, Here's an Amlogic Drivers change for v6.3, fixes memcpy vs iomem type warnings in meson_sm driver. Neil The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: Linux 6.1-rc1 (2022-10-16 15:36:24 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git tags/amlogic-drivers-for-v6.2 for you to fetch changes up to 7dc69c7d073e6004a281db8f7f15cf6ebf702ea0: firmware: meson_sm: Fix memcpy vs iomem type warnings (2022-10-17 17:19:04 +0200) ---------------------------------------------------------------- Amlogic Drivers changes for v6.2: - Fix memcpy vs iomem type warnings in meson_sm driver ---------------------------------------------------------------- Kees Cook (1): firmware: meson_sm: Fix memcpy vs iomem type warnings drivers/firmware/meson/meson_sm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [GIT PULL] amlogic Drivers updates for v6.2 2022-11-22 15:24 ` Neil Armstrong (?) @ 2022-11-22 21:48 ` Arnd Bergmann -1 siblings, 0 replies; 11+ messages in thread From: Arnd Bergmann @ 2022-11-22 21:48 UTC (permalink / raw) To: Neil Armstrong, soc, arm; +Cc: linux-amlogic, linux-arm-kernel On Tue, Nov 22, 2022, at 16:24, Neil Armstrong wrote: > > for you to fetch changes up to 7dc69c7d073e6004a281db8f7f15cf6ebf702ea0: > > firmware: meson_sm: Fix memcpy vs iomem type warnings (2022-10-17 > 17:19:04 +0200) > > ---------------------------------------------------------------- > Amlogic Drivers changes for v6.2: > - Fix memcpy vs iomem type warnings in meson_sm driver > It looks like a trivial fix, but I think it's actually wrong: The real problem appears to be the use of the ioremap_cache() function in meson_sm_map_shmem(), which returns an __iomem token that is mapped cacheable on architectures that support this function, but behaves like normal ioremap on others. This is probably not what you want here, instead this should be converted to memremap(), with the __iomem annotation dropped. In the long run, we should try to kill off ioremap_cache entirely, and not introduce new ones. Arnd ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [GIT PULL] amlogic Drivers updates for v6.2 @ 2022-11-22 21:48 ` Arnd Bergmann 0 siblings, 0 replies; 11+ messages in thread From: Arnd Bergmann @ 2022-11-22 21:48 UTC (permalink / raw) To: Neil Armstrong, soc, arm; +Cc: linux-amlogic, linux-arm-kernel On Tue, Nov 22, 2022, at 16:24, Neil Armstrong wrote: > > for you to fetch changes up to 7dc69c7d073e6004a281db8f7f15cf6ebf702ea0: > > firmware: meson_sm: Fix memcpy vs iomem type warnings (2022-10-17 > 17:19:04 +0200) > > ---------------------------------------------------------------- > Amlogic Drivers changes for v6.2: > - Fix memcpy vs iomem type warnings in meson_sm driver > It looks like a trivial fix, but I think it's actually wrong: The real problem appears to be the use of the ioremap_cache() function in meson_sm_map_shmem(), which returns an __iomem token that is mapped cacheable on architectures that support this function, but behaves like normal ioremap on others. This is probably not what you want here, instead this should be converted to memremap(), with the __iomem annotation dropped. In the long run, we should try to kill off ioremap_cache entirely, and not introduce new ones. Arnd _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [GIT PULL] amlogic Drivers updates for v6.2 @ 2022-11-22 21:48 ` Arnd Bergmann 0 siblings, 0 replies; 11+ messages in thread From: Arnd Bergmann @ 2022-11-22 21:48 UTC (permalink / raw) To: Neil Armstrong, soc, arm; +Cc: linux-amlogic, linux-arm-kernel On Tue, Nov 22, 2022, at 16:24, Neil Armstrong wrote: > > for you to fetch changes up to 7dc69c7d073e6004a281db8f7f15cf6ebf702ea0: > > firmware: meson_sm: Fix memcpy vs iomem type warnings (2022-10-17 > 17:19:04 +0200) > > ---------------------------------------------------------------- > Amlogic Drivers changes for v6.2: > - Fix memcpy vs iomem type warnings in meson_sm driver > It looks like a trivial fix, but I think it's actually wrong: The real problem appears to be the use of the ioremap_cache() function in meson_sm_map_shmem(), which returns an __iomem token that is mapped cacheable on architectures that support this function, but behaves like normal ioremap on others. This is probably not what you want here, instead this should be converted to memremap(), with the __iomem annotation dropped. In the long run, we should try to kill off ioremap_cache entirely, and not introduce new ones. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [GIT PULL] amlogic Drivers updates for v6.2 2022-11-22 21:48 ` Arnd Bergmann (?) @ 2022-11-23 10:51 ` Neil Armstrong -1 siblings, 0 replies; 11+ messages in thread From: Neil Armstrong @ 2022-11-23 10:51 UTC (permalink / raw) To: Arnd Bergmann, soc, arm; +Cc: linux-amlogic, linux-arm-kernel On 22/11/2022 22:48, Arnd Bergmann wrote: > On Tue, Nov 22, 2022, at 16:24, Neil Armstrong wrote: >> >> for you to fetch changes up to 7dc69c7d073e6004a281db8f7f15cf6ebf702ea0: >> >> firmware: meson_sm: Fix memcpy vs iomem type warnings (2022-10-17 >> 17:19:04 +0200) >> >> ---------------------------------------------------------------- >> Amlogic Drivers changes for v6.2: >> - Fix memcpy vs iomem type warnings in meson_sm driver >> > > It looks like a trivial fix, but I think it's actually wrong: > The real problem appears to be the use of the ioremap_cache() > function in meson_sm_map_shmem(), which returns an __iomem > token that is mapped cacheable on architectures that support > this function, but behaves like normal ioremap on others. > > This is probably not what you want here, instead this should > be converted to memremap(), with the __iomem annotation dropped. > In the long run, we should try to kill off ioremap_cache > entirely, and not introduce new ones. OK will have a look into that, Thanks, Neil > > Arnd ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [GIT PULL] amlogic Drivers updates for v6.2 @ 2022-11-23 10:51 ` Neil Armstrong 0 siblings, 0 replies; 11+ messages in thread From: Neil Armstrong @ 2022-11-23 10:51 UTC (permalink / raw) To: Arnd Bergmann, soc, arm; +Cc: linux-amlogic, linux-arm-kernel On 22/11/2022 22:48, Arnd Bergmann wrote: > On Tue, Nov 22, 2022, at 16:24, Neil Armstrong wrote: >> >> for you to fetch changes up to 7dc69c7d073e6004a281db8f7f15cf6ebf702ea0: >> >> firmware: meson_sm: Fix memcpy vs iomem type warnings (2022-10-17 >> 17:19:04 +0200) >> >> ---------------------------------------------------------------- >> Amlogic Drivers changes for v6.2: >> - Fix memcpy vs iomem type warnings in meson_sm driver >> > > It looks like a trivial fix, but I think it's actually wrong: > The real problem appears to be the use of the ioremap_cache() > function in meson_sm_map_shmem(), which returns an __iomem > token that is mapped cacheable on architectures that support > this function, but behaves like normal ioremap on others. > > This is probably not what you want here, instead this should > be converted to memremap(), with the __iomem annotation dropped. > In the long run, we should try to kill off ioremap_cache > entirely, and not introduce new ones. OK will have a look into that, Thanks, Neil > > Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [GIT PULL] amlogic Drivers updates for v6.2 @ 2022-11-23 10:51 ` Neil Armstrong 0 siblings, 0 replies; 11+ messages in thread From: Neil Armstrong @ 2022-11-23 10:51 UTC (permalink / raw) To: Arnd Bergmann, soc, arm; +Cc: linux-amlogic, linux-arm-kernel On 22/11/2022 22:48, Arnd Bergmann wrote: > On Tue, Nov 22, 2022, at 16:24, Neil Armstrong wrote: >> >> for you to fetch changes up to 7dc69c7d073e6004a281db8f7f15cf6ebf702ea0: >> >> firmware: meson_sm: Fix memcpy vs iomem type warnings (2022-10-17 >> 17:19:04 +0200) >> >> ---------------------------------------------------------------- >> Amlogic Drivers changes for v6.2: >> - Fix memcpy vs iomem type warnings in meson_sm driver >> > > It looks like a trivial fix, but I think it's actually wrong: > The real problem appears to be the use of the ioremap_cache() > function in meson_sm_map_shmem(), which returns an __iomem > token that is mapped cacheable on architectures that support > this function, but behaves like normal ioremap on others. > > This is probably not what you want here, instead this should > be converted to memremap(), with the __iomem annotation dropped. > In the long run, we should try to kill off ioremap_cache > entirely, and not introduce new ones. OK will have a look into that, Thanks, Neil > > Arnd _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [GIT PULL] amlogic Drivers updates for v6.2 2022-11-22 15:24 ` Neil Armstrong ` (2 preceding siblings ...) (?) @ 2022-11-22 22:20 ` patchwork-bot+linux-soc 2022-11-23 11:05 ` Arnd Bergmann -1 siblings, 1 reply; 11+ messages in thread From: patchwork-bot+linux-soc @ 2022-11-22 22:20 UTC (permalink / raw) To: Neil Armstrong; +Cc: soc Hello: This pull request was applied to soc/soc.git (for-next) by Arnd Bergmann <arnd@arndb.de>: On Tue, 22 Nov 2022 16:24:59 +0100 you wrote: > Hi, > > Here's an Amlogic Drivers change for v6.3, fixes memcpy vs iomem type warnings in meson_sm driver. > > Neil > > The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: > > [...] Here is the summary with links: - [GIT,PULL] amlogic Drivers updates for v6.2 https://git.kernel.org/soc/soc/c/ad654a0a21bb You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [GIT PULL] amlogic Drivers updates for v6.2 2022-11-22 22:20 ` patchwork-bot+linux-soc @ 2022-11-23 11:05 ` Arnd Bergmann 0 siblings, 0 replies; 11+ messages in thread From: Arnd Bergmann @ 2022-11-23 11:05 UTC (permalink / raw) To: patchwork-bot+linux-soc, Neil Armstrong; +Cc: soc On Tue, Nov 22, 2022, at 23:20, patchwork-bot+linux-soc@kernel.org wrote: > Hello: > > This pull request was applied to soc/soc.git (for-next) > by Arnd Bergmann <arnd@arndb.de>: > > On Tue, 22 Nov 2022 16:24:59 +0100 you wrote: >> Hi, >> >> Here's an Amlogic Drivers change for v6.3, fixes memcpy vs iomem type warnings in meson_sm driver. >> >> Neil >> >> The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: >> >> [...] > > Here is the summary with links: > - [GIT,PULL] amlogic Drivers updates for v6.2 > https://git.kernel.org/soc/soc/c/ad654a0a21bb > > You are awesome, thank you! > -- Sorry about this, I meant to remove this change when I originally complained about this, and it looked I accidentally kept working on the branch that still had it. I've fixed it up now, and it's gone again once I push out the latest updaet. Arnd ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-11-23 11:06 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-11-22 15:24 [GIT PULL] amlogic Drivers updates for v6.2 Neil Armstrong 2022-11-22 15:24 ` Neil Armstrong 2022-11-22 15:24 ` Neil Armstrong 2022-11-22 21:48 ` Arnd Bergmann 2022-11-22 21:48 ` Arnd Bergmann 2022-11-22 21:48 ` Arnd Bergmann 2022-11-23 10:51 ` Neil Armstrong 2022-11-23 10:51 ` Neil Armstrong 2022-11-23 10:51 ` Neil Armstrong 2022-11-22 22:20 ` patchwork-bot+linux-soc 2022-11-23 11:05 ` Arnd Bergmann
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.