[PATCH][meta-networking] kronosnet: inherit manpages

[PATCH][meta-networking] kronosnet: inherit manpages

[Oleksandr Kravchuk]

Let manpages bbclass handle man pages.

Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>
---
 .../recipes-extended/kronosnet/kronosnet_1.18.bb            | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta-networking/recipes-extended/kronosnet/kronosnet_1.18.bb b/meta-networking/recipes-extended/kronosnet/kronosnet_1.18.bb
index 7b1dfc241..3fd6298b5 100644
--- a/meta-networking/recipes-extended/kronosnet/kronosnet_1.18.bb
+++ b/meta-networking/recipes-extended/kronosnet/kronosnet_1.18.bb
@@ -16,7 +16,7 @@ SRC_URI = "git://github.com/kronosnet/kronosnet;protocol=https;branch=stable1"
 
 UPSTREAM_CHECK_URI = "https://github.com/kronosnet/kronosnet/releases"
 
-inherit autotools
+inherit autotools manpages
 
 S = "${WORKDIR}/git"
 
@@ -26,5 +26,5 @@ S = "${WORKDIR}/git"
 CFLAGS_append_toolchain-clang = " -Wno-sign-compare"
 
 PACKAGECONFIG[man] = "enable_man="yes", --disable-man, "
-
-PACKAGECONFIG_remove = "man"
+#
+#PACKAGECONFIG_remove = "man"
-- 
2.25.1

Re: [oe] [PATCH][meta-networking] kronosnet: inherit manpages

[Robert Joslyn]

On Mon, 2020-08-03 at 19:24 +0200, Oleksandr Kravchuk wrote:
> Let manpages bbclass handle man pages.
> 
> Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>
> ---
>  .../recipes-extended/kronosnet/kronosnet_1.18.bb            | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-networking/recipes-
> extended/kronosnet/kronosnet_1.18.bb b/meta-networking/recipes-
> extended/kronosnet/kronosnet_1.18.bb
> index 7b1dfc241..3fd6298b5 100644
> --- a/meta-networking/recipes-extended/kronosnet/kronosnet_1.18.bb
> +++ b/meta-networking/recipes-extended/kronosnet/kronosnet_1.18.bb
> @@ -16,7 +16,7 @@ SRC_URI =
> "git://github.com/kronosnet/kronosnet;protocol=https;branch=stable1"
>  
>  UPSTREAM_CHECK_URI = "https://github.com/kronosnet/kronosnet/releases"
>  
> -inherit autotools
> +inherit autotools manpages
>  
>  S = "${WORKDIR}/git"
>  
> @@ -26,5 +26,5 @@ S = "${WORKDIR}/git"
>  CFLAGS_append_toolchain-clang = " -Wno-sign-compare"
>  
>  PACKAGECONFIG[man] = "enable_man="yes", --disable-man, "

To use the manpages class, you'll want to change the PACKAGECONFIG option
to "manpages". Unless there is some reason to do otherwise, I also suggest
using --enable-man along with --disable-man to be consistent:

PACKAGECONFIG[manpages] = "--enable-man,--disable-man"

There are still some errors in do_install when enabling this that you'll
need to look into as well if you want to enable man pages. For example:

| /home/robert/yocto/poky/build/tmp/hosttools/install: cannot stat
'../../git/man/knet_addrtostr.3': No such file or directory

Thanks,
Robert

> -
> -PACKAGECONFIG_remove = "man"
> +#
> +#PACKAGECONFIG_remove = "man"
>