All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays
@ 2020-08-07 15:03 ` Holger Assmann
  0 siblings, 0 replies; 8+ messages in thread
From: Holger Assmann @ 2020-08-07 15:03 UTC (permalink / raw)
  To: Rob Herring, Maxime Coquelin, Alexandre Torgue, Ahmad Fatoum
  Cc: Holger Assmann, devicetree, linux-stm32, linux-arm-kernel, linux-kernel

The KSZ9031 PHY skew timings for rxc/txc, originally set to achieve
the desired phase shift between clock- and data-signal, now trigger a
kernel warning when used in rgmii-id mode:

 *-skew-ps values should be used only with phy-mode = "rgmii"

This is because commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode
support for the KSZ9031 PHY") now configures own timings when
phy-mode = "rgmii-id". Device trees wanting to set their own delays
should use phy-mode "rgmii" instead as the warning prescribes.

The "standard" timings now used with "rgmii-id" work fine on this
board, so drop the explicit timings in the device tree and thereby
silence the warning.

Fixes: 666b5ca85cd3 ("ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board")
Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>
---
 arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
index 5700e6b700d3..b85025d00943 100644
--- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
@@ -121,8 +121,6 @@
 			reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; /* ETH_RST# */
 			interrupt-parent = <&gpioa>;
 			interrupts = <6 IRQ_TYPE_EDGE_FALLING>; /* ETH_MDINT# */
-			rxc-skew-ps = <1860>;
-			txc-skew-ps = <1860>;
 			reset-assert-us = <10000>;
 			reset-deassert-us = <300>;
 			micrel,force-master;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays
@ 2020-08-07 15:03 ` Holger Assmann
  0 siblings, 0 replies; 8+ messages in thread
From: Holger Assmann @ 2020-08-07 15:03 UTC (permalink / raw)
  To: Rob Herring, Maxime Coquelin, Alexandre Torgue, Ahmad Fatoum
  Cc: devicetree, Holger Assmann, linux-stm32, linux-arm-kernel, linux-kernel

The KSZ9031 PHY skew timings for rxc/txc, originally set to achieve
the desired phase shift between clock- and data-signal, now trigger a
kernel warning when used in rgmii-id mode:

 *-skew-ps values should be used only with phy-mode = "rgmii"

This is because commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode
support for the KSZ9031 PHY") now configures own timings when
phy-mode = "rgmii-id". Device trees wanting to set their own delays
should use phy-mode "rgmii" instead as the warning prescribes.

The "standard" timings now used with "rgmii-id" work fine on this
board, so drop the explicit timings in the device tree and thereby
silence the warning.

Fixes: 666b5ca85cd3 ("ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board")
Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>
---
 arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
index 5700e6b700d3..b85025d00943 100644
--- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
@@ -121,8 +121,6 @@
 			reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; /* ETH_RST# */
 			interrupt-parent = <&gpioa>;
 			interrupts = <6 IRQ_TYPE_EDGE_FALLING>; /* ETH_MDINT# */
-			rxc-skew-ps = <1860>;
-			txc-skew-ps = <1860>;
 			reset-assert-us = <10000>;
 			reset-deassert-us = <300>;
 			micrel,force-master;
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays
  2020-08-07 15:03 ` Holger Assmann
@ 2020-08-07 15:24   ` Ahmad Fatoum
  -1 siblings, 0 replies; 8+ messages in thread
From: Ahmad Fatoum @ 2020-08-07 15:24 UTC (permalink / raw)
  To: Holger Assmann, Rob Herring, Maxime Coquelin, Alexandre Torgue
  Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel,
	Pengutronix Kernel Team

On 8/7/20 5:03 PM, Holger Assmann wrote:
> The KSZ9031 PHY skew timings for rxc/txc, originally set to achieve
> the desired phase shift between clock- and data-signal, now trigger a
> kernel warning when used in rgmii-id mode:
> 
>  *-skew-ps values should be used only with phy-mode = "rgmii"
> 
> This is because commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode
> support for the KSZ9031 PHY") now configures own timings when
> phy-mode = "rgmii-id". Device trees wanting to set their own delays
> should use phy-mode "rgmii" instead as the warning prescribes.
> 
> The "standard" timings now used with "rgmii-id" work fine on this
> board, so drop the explicit timings in the device tree and thereby
> silence the warning.
> 
> Fixes: 666b5ca85cd3 ("ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board")
> Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>

Acked-by: Ahmad Fatoum <a.fatoum@pengutronic.de>

> ---
>  arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> index 5700e6b700d3..b85025d00943 100644
> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> @@ -121,8 +121,6 @@
>  			reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; /* ETH_RST# */
>  			interrupt-parent = <&gpioa>;
>  			interrupts = <6 IRQ_TYPE_EDGE_FALLING>; /* ETH_MDINT# */
> -			rxc-skew-ps = <1860>;
> -			txc-skew-ps = <1860>;
>  			reset-assert-us = <10000>;
>  			reset-deassert-us = <300>;
>  			micrel,force-master;
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays
@ 2020-08-07 15:24   ` Ahmad Fatoum
  0 siblings, 0 replies; 8+ messages in thread
From: Ahmad Fatoum @ 2020-08-07 15:24 UTC (permalink / raw)
  To: Holger Assmann, Rob Herring, Maxime Coquelin, Alexandre Torgue
  Cc: Pengutronix Kernel Team, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel

On 8/7/20 5:03 PM, Holger Assmann wrote:
> The KSZ9031 PHY skew timings for rxc/txc, originally set to achieve
> the desired phase shift between clock- and data-signal, now trigger a
> kernel warning when used in rgmii-id mode:
> 
>  *-skew-ps values should be used only with phy-mode = "rgmii"
> 
> This is because commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode
> support for the KSZ9031 PHY") now configures own timings when
> phy-mode = "rgmii-id". Device trees wanting to set their own delays
> should use phy-mode "rgmii" instead as the warning prescribes.
> 
> The "standard" timings now used with "rgmii-id" work fine on this
> board, so drop the explicit timings in the device tree and thereby
> silence the warning.
> 
> Fixes: 666b5ca85cd3 ("ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board")
> Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>

Acked-by: Ahmad Fatoum <a.fatoum@pengutronic.de>

> ---
>  arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> index 5700e6b700d3..b85025d00943 100644
> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> @@ -121,8 +121,6 @@
>  			reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; /* ETH_RST# */
>  			interrupt-parent = <&gpioa>;
>  			interrupts = <6 IRQ_TYPE_EDGE_FALLING>; /* ETH_MDINT# */
> -			rxc-skew-ps = <1860>;
> -			txc-skew-ps = <1860>;
>  			reset-assert-us = <10000>;
>  			reset-deassert-us = <300>;
>  			micrel,force-master;
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays
  2020-08-07 15:24   ` Ahmad Fatoum
@ 2020-08-07 15:25     ` Ahmad Fatoum
  -1 siblings, 0 replies; 8+ messages in thread
From: Ahmad Fatoum @ 2020-08-07 15:25 UTC (permalink / raw)
  To: Holger Assmann, Rob Herring, Maxime Coquelin, Alexandre Torgue
  Cc: Pengutronix Kernel Team, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel

On 8/7/20 5:24 PM, Ahmad Fatoum wrote:
> On 8/7/20 5:03 PM, Holger Assmann wrote:
>> The KSZ9031 PHY skew timings for rxc/txc, originally set to achieve
>> the desired phase shift between clock- and data-signal, now trigger a
>> kernel warning when used in rgmii-id mode:
>>
>>  *-skew-ps values should be used only with phy-mode = "rgmii"
>>
>> This is because commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode
>> support for the KSZ9031 PHY") now configures own timings when
>> phy-mode = "rgmii-id". Device trees wanting to set their own delays
>> should use phy-mode "rgmii" instead as the warning prescribes.
>>
>> The "standard" timings now used with "rgmii-id" work fine on this
>> board, so drop the explicit timings in the device tree and thereby
>> silence the warning.
>>
>> Fixes: 666b5ca85cd3 ("ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board")
>> Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>
> 
> Acked-by: Ahmad Fatoum <a.fatoum@pengutronic.de>

Typo Correction: Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

:-)

> 
>> ---
>>  arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
>> index 5700e6b700d3..b85025d00943 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
>> @@ -121,8 +121,6 @@
>>  			reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; /* ETH_RST# */
>>  			interrupt-parent = <&gpioa>;
>>  			interrupts = <6 IRQ_TYPE_EDGE_FALLING>; /* ETH_MDINT# */
>> -			rxc-skew-ps = <1860>;
>> -			txc-skew-ps = <1860>;
>>  			reset-assert-us = <10000>;
>>  			reset-deassert-us = <300>;
>>  			micrel,force-master;
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays
@ 2020-08-07 15:25     ` Ahmad Fatoum
  0 siblings, 0 replies; 8+ messages in thread
From: Ahmad Fatoum @ 2020-08-07 15:25 UTC (permalink / raw)
  To: Holger Assmann, Rob Herring, Maxime Coquelin, Alexandre Torgue
  Cc: linux-arm-kernel, devicetree, linux-stm32,
	Pengutronix Kernel Team, linux-kernel

On 8/7/20 5:24 PM, Ahmad Fatoum wrote:
> On 8/7/20 5:03 PM, Holger Assmann wrote:
>> The KSZ9031 PHY skew timings for rxc/txc, originally set to achieve
>> the desired phase shift between clock- and data-signal, now trigger a
>> kernel warning when used in rgmii-id mode:
>>
>>  *-skew-ps values should be used only with phy-mode = "rgmii"
>>
>> This is because commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode
>> support for the KSZ9031 PHY") now configures own timings when
>> phy-mode = "rgmii-id". Device trees wanting to set their own delays
>> should use phy-mode "rgmii" instead as the warning prescribes.
>>
>> The "standard" timings now used with "rgmii-id" work fine on this
>> board, so drop the explicit timings in the device tree and thereby
>> silence the warning.
>>
>> Fixes: 666b5ca85cd3 ("ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board")
>> Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>
> 
> Acked-by: Ahmad Fatoum <a.fatoum@pengutronic.de>

Typo Correction: Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

:-)

> 
>> ---
>>  arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
>> index 5700e6b700d3..b85025d00943 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
>> @@ -121,8 +121,6 @@
>>  			reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; /* ETH_RST# */
>>  			interrupt-parent = <&gpioa>;
>>  			interrupts = <6 IRQ_TYPE_EDGE_FALLING>; /* ETH_MDINT# */
>> -			rxc-skew-ps = <1860>;
>> -			txc-skew-ps = <1860>;
>>  			reset-assert-us = <10000>;
>>  			reset-deassert-us = <300>;
>>  			micrel,force-master;
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays
  2020-08-07 15:03 ` Holger Assmann
@ 2020-08-28  9:12   ` Alexandre Torgue
  -1 siblings, 0 replies; 8+ messages in thread
From: Alexandre Torgue @ 2020-08-28  9:12 UTC (permalink / raw)
  To: Holger Assmann, Rob Herring, Maxime Coquelin, Ahmad Fatoum
  Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel

Hi Holger

On 8/7/20 5:03 PM, Holger Assmann wrote:
> The KSZ9031 PHY skew timings for rxc/txc, originally set to achieve
> the desired phase shift between clock- and data-signal, now trigger a
> kernel warning when used in rgmii-id mode:
> 
>   *-skew-ps values should be used only with phy-mode = "rgmii"
> 
> This is because commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode
> support for the KSZ9031 PHY") now configures own timings when
> phy-mode = "rgmii-id". Device trees wanting to set their own delays
> should use phy-mode "rgmii" instead as the warning prescribes.
> 
> The "standard" timings now used with "rgmii-id" work fine on this
> board, so drop the explicit timings in the device tree and thereby
> silence the warning.
> 
> Fixes: 666b5ca85cd3 ("ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board")
> Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>
> ---
>   arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> index 5700e6b700d3..b85025d00943 100644
> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> @@ -121,8 +121,6 @@
>   			reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; /* ETH_RST# */
>   			interrupt-parent = <&gpioa>;
>   			interrupts = <6 IRQ_TYPE_EDGE_FALLING>; /* ETH_MDINT# */
> -			rxc-skew-ps = <1860>;
> -			txc-skew-ps = <1860>;
>   			reset-assert-us = <10000>;
>   			reset-deassert-us = <300>;
>   			micrel,force-master;
> 

Applied on stm32-next.

Thanks.
Alex

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays
@ 2020-08-28  9:12   ` Alexandre Torgue
  0 siblings, 0 replies; 8+ messages in thread
From: Alexandre Torgue @ 2020-08-28  9:12 UTC (permalink / raw)
  To: Holger Assmann, Rob Herring, Maxime Coquelin, Ahmad Fatoum
  Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel

Hi Holger

On 8/7/20 5:03 PM, Holger Assmann wrote:
> The KSZ9031 PHY skew timings for rxc/txc, originally set to achieve
> the desired phase shift between clock- and data-signal, now trigger a
> kernel warning when used in rgmii-id mode:
> 
>   *-skew-ps values should be used only with phy-mode = "rgmii"
> 
> This is because commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode
> support for the KSZ9031 PHY") now configures own timings when
> phy-mode = "rgmii-id". Device trees wanting to set their own delays
> should use phy-mode "rgmii" instead as the warning prescribes.
> 
> The "standard" timings now used with "rgmii-id" work fine on this
> board, so drop the explicit timings in the device tree and thereby
> silence the warning.
> 
> Fixes: 666b5ca85cd3 ("ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board")
> Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>
> ---
>   arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> index 5700e6b700d3..b85025d00943 100644
> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> @@ -121,8 +121,6 @@
>   			reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; /* ETH_RST# */
>   			interrupt-parent = <&gpioa>;
>   			interrupts = <6 IRQ_TYPE_EDGE_FALLING>; /* ETH_MDINT# */
> -			rxc-skew-ps = <1860>;
> -			txc-skew-ps = <1860>;
>   			reset-assert-us = <10000>;
>   			reset-deassert-us = <300>;
>   			micrel,force-master;
> 

Applied on stm32-next.

Thanks.
Alex

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-08-28  9:14 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-07 15:03 [PATCH] ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays Holger Assmann
2020-08-07 15:03 ` Holger Assmann
2020-08-07 15:24 ` Ahmad Fatoum
2020-08-07 15:24   ` Ahmad Fatoum
2020-08-07 15:25   ` Ahmad Fatoum
2020-08-07 15:25     ` Ahmad Fatoum
2020-08-28  9:12 ` Alexandre Torgue
2020-08-28  9:12   ` Alexandre Torgue

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.