All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] plugin: provision: create multiple contexts for multiple entries in mbpi
@ 2020-03-02 16:31 Nicola Lunghi
  2020-03-04 16:10 ` Denis Kenzior
  0 siblings, 1 reply; 14+ messages in thread
From: Nicola Lunghi @ 2020-03-02 16:31 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

if the mobile provider information database has multiple apn settings for the
same operator, ofono was throwing an error and creating a default internet
context with an empty apn.

This patch will instead allow the automatic creation of multiple context
allowing the user to pick one of the default via connman.

Connman supports multiple cellular context so no issue there.

Previously proposed by Martin Hundebøll here:
https://lists.ofono.org/hyperkitty/list/ofono(a)ofono.org/thread/2SC46PH5CWT3A3HTHGUKUUVI3QDYIL73/#7B6CPARJQMZUBQUPXBJMAOXZY4RW2L3D

And tested by Nicola Lunghi with connman 1.37

Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
---
 plugins/provision.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/provision.c b/plugins/provision.c
index 99c299eb..aa0b05e4 100644
--- a/plugins/provision.c
+++ b/plugins/provision.c
@@ -50,7 +50,7 @@ static int provision_get_settings(const char *mcc, const char *mnc,
 
 	DBG("Provisioning for MCC %s, MNC %s, SPN '%s'", mcc, mnc, spn);
 
-	apns = mbpi_lookup_apn(mcc, mnc, FALSE, &error);
+	apns = mbpi_lookup_apn(mcc, mnc, TRUE, &error);
 	if (apns == NULL) {
 		if (error != NULL) {
 			ofono_error("%s", error->message);
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2020-03-12 20:06 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-02 16:31 [PATCH] plugin: provision: create multiple contexts for multiple entries in mbpi Nicola Lunghi
2020-03-04 16:10 ` Denis Kenzior
2020-03-04 16:45   ` nick83ola
2020-03-04 16:54     ` Giacinto Cifelli
2020-03-04 17:00       ` nick83ola
2020-03-04 16:56         ` Denis Kenzior
2020-03-04 17:51           ` nick83ola
2020-03-04 18:49             ` Denis Kenzior
2020-03-12 13:22               ` Tarmo Kuuse
2020-03-12 14:49                 ` Denis Kenzior
2020-03-12 19:36                   ` Tarmo Kuuse
2020-03-12 20:06                     ` Denis Kenzior
2020-03-12 15:51                 ` Christophe Ronco
2020-03-12 19:17                   ` Tarmo Kuuse

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.