* [PATCH] scripts:modify output format
@ 2022-05-16 2:04 Dong Chuanjian
2022-05-16 5:19 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Dong Chuanjian @ 2022-05-16 2:04 UTC (permalink / raw)
To: Masahiro Yamada, Changbin Du, Nathan Chancellor, Nick Desaulniers
Cc: linux-kernel, Kernel
scripts:modify output format
Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>
---
scripts/kallsyms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 8caabddf817c..ba50993785ec 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -498,7 +498,7 @@ static void write_src(void)
output_label("kallsyms_token_index");
for (i = 0; i < 256; i++)
- printf("\t.short\t%d\n", best_idx[i]);
+ printf("\t.short\t%u\n", best_idx[i]);
printf("\n");
}
--
2.18.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts:modify output format
2022-05-16 2:04 [PATCH] scripts:modify output format Dong Chuanjian
@ 2022-05-16 5:19 ` Randy Dunlap
2022-05-17 2:04 ` Dong Chuanjian
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2022-05-16 5:19 UTC (permalink / raw)
To: Dong Chuanjian, Masahiro Yamada, Changbin Du, Nathan Chancellor,
Nick Desaulniers
Cc: linux-kernel, Kernel
Hi,
The change looks good to me, but there are a few other
"process" problems.
1. Was there a compiler warning that caused this patch?
If so, then tell us about it.
2. This is v2 of the patch. You should describe what changed
between v1 and v2 (below the first --- line).
Thanks.
On 5/15/22 19:04, Dong Chuanjian wrote:
> scripts:modify output format
>
> Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>
> ---
> scripts/kallsyms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 8caabddf817c..ba50993785ec 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -498,7 +498,7 @@ static void write_src(void)
>
> output_label("kallsyms_token_index");
> for (i = 0; i < 256; i++)
> - printf("\t.short\t%d\n", best_idx[i]);
> + printf("\t.short\t%u\n", best_idx[i]);
> printf("\n");
> }
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts:modify output format
2022-05-16 5:19 ` Randy Dunlap
@ 2022-05-17 2:04 ` Dong Chuanjian
0 siblings, 0 replies; 3+ messages in thread
From: Dong Chuanjian @ 2022-05-17 2:04 UTC (permalink / raw)
To: rdunlap
Cc: Kernel, changbin.du, chuanjian, linux-kernel, masahiroy, nathan,
ndesaulniers
The compiler does not have warnings, but the definition of the output variable is "unsigned int"，So there will be this patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-17 2:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 2:04 [PATCH] scripts:modify output format Dong Chuanjian
2022-05-16 5:19 ` Randy Dunlap
2022-05-17 2:04 ` Dong Chuanjian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.