[PATCH] ARM: stm32: Fix OF_LIST on DHCOR

[PATCH] ARM: stm32: Fix OF_LIST on DHCOR

[Tom Rini]

The ITS file used to build the images here lists three dtb files as
being used. Today, these are built by the logic that will over-build dtb
files based on SOC/etc symbols being set. To future proof this platform
and be generally correct, we list all 3 of the device trees used here in
OF_LIST.

Cc: Marek Vasut <marex@denx.de>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 configs/stm32mp15_dhcor_basic_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
index b54ff9301461..d4786500271a 100644
--- a/configs/stm32mp15_dhcor_basic_defconfig
+++ b/configs/stm32mp15_dhcor_basic_defconfig
@@ -92,6 +92,7 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=nor0:256k(fsbl1),256k(fsbl2),1408k(uboot),64k(
 # CONFIG_ISO_PARTITION is not set
 # CONFIG_SPL_PARTITION_UUIDS is not set
 CONFIG_OF_LIVE=y
+CONFIG_OF_LIST="stm32mp15xx-dhcor-avenger96 stm32mp15xx-dhcor-testbench stm32mp15xx-dhcor-drc-compact"
 CONFIG_OF_SPL_REMOVE_PROPS="interrupts interrupt-names interrupts-extended interrupt-controller \\\#interrupt-cells interrupt-parent dmas dma-names assigned-clocks assigned-clock-rates assigned-clock-parents hwlocks"
 CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
-- 
2.34.1

Re: [PATCH] ARM: stm32: Fix OF_LIST on DHCOR

[Marek Vasut]

On 5/5/23 02:11, Tom Rini wrote:
> The ITS file used to build the images here lists three dtb files as
> being used. Today, these are built by the logic that will over-build dtb
> files based on SOC/etc symbols being set. To future proof this platform
> and be generally correct, we list all 3 of the device trees used here in
> OF_LIST.
> 
> Cc: Marek Vasut <marex@denx.de>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>

This ^ should be ...

> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---

... here , followed by one more line of ---

>   configs/stm32mp15_dhcor_basic_defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
> index b54ff9301461..d4786500271a 100644
> --- a/configs/stm32mp15_dhcor_basic_defconfig
> +++ b/configs/stm32mp15_dhcor_basic_defconfig
> @@ -92,6 +92,7 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=nor0:256k(fsbl1),256k(fsbl2),1408k(uboot),64k(
>   # CONFIG_ISO_PARTITION is not set
>   # CONFIG_SPL_PARTITION_UUIDS is not set
>   CONFIG_OF_LIVE=y
> +CONFIG_OF_LIST="stm32mp15xx-dhcor-avenger96 stm32mp15xx-dhcor-testbench stm32mp15xx-dhcor-drc-compact"
>   CONFIG_OF_SPL_REMOVE_PROPS="interrupts interrupt-names interrupts-extended interrupt-controller \\\#interrupt-cells interrupt-parent dmas dma-names assigned-clocks assigned-clock-rates assigned-clock-parents hwlocks"
>   CONFIG_ENV_IS_IN_SPI_FLASH=y
>   CONFIG_SYS_REDUNDAND_ENVIRONMENT=y

Reviewed-by: Marek Vasut <marex@denx.de>

Re: [PATCH] ARM: stm32: Fix OF_LIST on DHCOR

[Patrick DELAUNAY]

Hi,

On 5/5/23 02:11, Tom Rini wrote:
> The ITS file used to build the images here lists three dtb files as
> being used. Today, these are built by the logic that will over-build dtb
> files based on SOC/etc symbols being set. To future proof this platform
> and be generally correct, we list all 3 of the device trees used here in
> OF_LIST.
>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>   configs/stm32mp15_dhcor_basic_defconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
> index b54ff9301461..d4786500271a 100644
> --- a/configs/stm32mp15_dhcor_basic_defconfig
> +++ b/configs/stm32mp15_dhcor_basic_defconfig
> @@ -92,6 +92,7 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=nor0:256k(fsbl1),256k(fsbl2),1408k(uboot),64k(
>   # CONFIG_ISO_PARTITION is not set
>   # CONFIG_SPL_PARTITION_UUIDS is not set
>   CONFIG_OF_LIVE=y
> +CONFIG_OF_LIST="stm32mp15xx-dhcor-avenger96 stm32mp15xx-dhcor-testbench stm32mp15xx-dhcor-drc-compact"
>   CONFIG_OF_SPL_REMOVE_PROPS="interrupts interrupt-names interrupts-extended interrupt-controller \\\#interrupt-cells interrupt-parent dmas dma-names assigned-clocks assigned-clock-rates assigned-clock-parents hwlocks"
>   CONFIG_ENV_IS_IN_SPI_FLASH=y
>   CONFIG_SYS_REDUNDAND_ENVIRONMENT=y


Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick

Re: [PATCH] ARM: stm32: Fix OF_LIST on DHCOR

[Patrice CHOTARD]

On 5/12/23 15:58, Patrick DELAUNAY wrote:
> Hi,
> 
> On 5/5/23 02:11, Tom Rini wrote:
>> The ITS file used to build the images here lists three dtb files as
>> being used. Today, these are built by the logic that will over-build dtb
>> files based on SOC/etc symbols being set. To future proof this platform
>> and be generally correct, we list all 3 of the device trees used here in
>> OF_LIST.
>>
>> Cc: Marek Vasut <marex@denx.de>
>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>> Signed-off-by: Tom Rini <trini@konsulko.com>
>> ---
>>   configs/stm32mp15_dhcor_basic_defconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
>> index b54ff9301461..d4786500271a 100644
>> --- a/configs/stm32mp15_dhcor_basic_defconfig
>> +++ b/configs/stm32mp15_dhcor_basic_defconfig
>> @@ -92,6 +92,7 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=nor0:256k(fsbl1),256k(fsbl2),1408k(uboot),64k(
>>   # CONFIG_ISO_PARTITION is not set
>>   # CONFIG_SPL_PARTITION_UUIDS is not set
>>   CONFIG_OF_LIVE=y
>> +CONFIG_OF_LIST="stm32mp15xx-dhcor-avenger96 stm32mp15xx-dhcor-testbench stm32mp15xx-dhcor-drc-compact"
>>   CONFIG_OF_SPL_REMOVE_PROPS="interrupts interrupt-names interrupts-extended interrupt-controller \\\#interrupt-cells interrupt-parent dmas dma-names assigned-clocks assigned-clock-rates assigned-clock-parents hwlocks"
>>   CONFIG_ENV_IS_IN_SPI_FLASH=y
>>   CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
> 
> 
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> Thanks
> Patrick
> 

Applied to u-boot-stm/next

Thanks
Patrice

Re: [PATCH] ARM: stm32: Fix OF_LIST on DHCOR

[Marek Vasut]

On 6/16/23 13:44, Patrice CHOTARD wrote:
> 
> 
> On 5/12/23 15:58, Patrick DELAUNAY wrote:
>> Hi,
>>
>> On 5/5/23 02:11, Tom Rini wrote:
>>> The ITS file used to build the images here lists three dtb files as
>>> being used. Today, these are built by the logic that will over-build dtb
>>> files based on SOC/etc symbols being set. To future proof this platform
>>> and be generally correct, we list all 3 of the device trees used here in
>>> OF_LIST.
>>>
>>> Cc: Marek Vasut <marex@denx.de>
>>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>> ---
>>>    configs/stm32mp15_dhcor_basic_defconfig | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
>>> index b54ff9301461..d4786500271a 100644
>>> --- a/configs/stm32mp15_dhcor_basic_defconfig
>>> +++ b/configs/stm32mp15_dhcor_basic_defconfig
>>> @@ -92,6 +92,7 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=nor0:256k(fsbl1),256k(fsbl2),1408k(uboot),64k(
>>>    # CONFIG_ISO_PARTITION is not set
>>>    # CONFIG_SPL_PARTITION_UUIDS is not set
>>>    CONFIG_OF_LIVE=y
>>> +CONFIG_OF_LIST="stm32mp15xx-dhcor-avenger96 stm32mp15xx-dhcor-testbench stm32mp15xx-dhcor-drc-compact"
>>>    CONFIG_OF_SPL_REMOVE_PROPS="interrupts interrupt-names interrupts-extended interrupt-controller \\\#interrupt-cells interrupt-parent dmas dma-names assigned-clocks assigned-clock-rates assigned-clock-parents hwlocks"
>>>    CONFIG_ENV_IS_IN_SPI_FLASH=y
>>>    CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
>>
>>
>> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>>
>> Thanks
>> Patrick
>>
> 
> Applied to u-boot-stm/next

Since this is a bugfix, should be for current.

Re: [PATCH] ARM: stm32: Fix OF_LIST on DHCOR

[Marek Vasut]

On 6/16/23 14:18, Marek Vasut wrote:
> On 6/16/23 13:44, Patrice CHOTARD wrote:
>>
>>
>> On 5/12/23 15:58, Patrick DELAUNAY wrote:
>>> Hi,
>>>
>>> On 5/5/23 02:11, Tom Rini wrote:
>>>> The ITS file used to build the images here lists three dtb files as
>>>> being used. Today, these are built by the logic that will over-build 
>>>> dtb
>>>> files based on SOC/etc symbols being set. To future proof this platform
>>>> and be generally correct, we list all 3 of the device trees used 
>>>> here in
>>>> OF_LIST.
>>>>
>>>> Cc: Marek Vasut <marex@denx.de>
>>>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>>>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>>> ---
>>>>    configs/stm32mp15_dhcor_basic_defconfig | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/configs/stm32mp15_dhcor_basic_defconfig 
>>>> b/configs/stm32mp15_dhcor_basic_defconfig
>>>> index b54ff9301461..d4786500271a 100644
>>>> --- a/configs/stm32mp15_dhcor_basic_defconfig
>>>> +++ b/configs/stm32mp15_dhcor_basic_defconfig
>>>> @@ -92,6 +92,7 @@ 
>>>> CONFIG_MTDPARTS_DEFAULT="mtdparts=nor0:256k(fsbl1),256k(fsbl2),1408k(uboot),64k(
>>>>    # CONFIG_ISO_PARTITION is not set
>>>>    # CONFIG_SPL_PARTITION_UUIDS is not set
>>>>    CONFIG_OF_LIVE=y
>>>> +CONFIG_OF_LIST="stm32mp15xx-dhcor-avenger96 
>>>> stm32mp15xx-dhcor-testbench stm32mp15xx-dhcor-drc-compact"
>>>>    CONFIG_OF_SPL_REMOVE_PROPS="interrupts interrupt-names 
>>>> interrupts-extended interrupt-controller \\\#interrupt-cells 
>>>> interrupt-parent dmas dma-names assigned-clocks assigned-clock-rates 
>>>> assigned-clock-parents hwlocks"
>>>>    CONFIG_ENV_IS_IN_SPI_FLASH=y
>>>>    CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
>>>
>>>
>>> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>>>
>>> Thanks
>>> Patrick
>>>
>>
>> Applied to u-boot-stm/next
> 
> Since this is a bugfix, should be for current.

I do not see this bugfix in u-boot 2023.07 release, even though ST has 
been notified this is a bugfix for that release a month before the 
release. Why ?

Re: [PATCH] ARM: stm32: Fix OF_LIST on DHCOR

[Patrick DELAUNAY]

Hi,

On 7/10/23 23:48, Marek Vasut wrote:
> On 6/16/23 14:18, Marek Vasut wrote:
>> On 6/16/23 13:44, Patrice CHOTARD wrote:
>>>
>>>
>>> On 5/12/23 15:58, Patrick DELAUNAY wrote:
>>>> Hi,
>>>>
>>>> On 5/5/23 02:11, Tom Rini wrote:
>>>>> The ITS file used to build the images here lists three dtb files as
>>>>> being used. Today, these are built by the logic that will 
>>>>> over-build dtb
>>>>> files based on SOC/etc symbols being set. To future proof this 
>>>>> platform
>>>>> and be generally correct, we list all 3 of the device trees used 
>>>>> here in
>>>>> OF_LIST.
>>>>>
>>>>> Cc: Marek Vasut <marex@denx.de>
>>>>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>>>>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>>>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>>>> ---
>>>>>    configs/stm32mp15_dhcor_basic_defconfig | 1 +
>>>>>    1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/configs/stm32mp15_dhcor_basic_defconfig 
>>>>> b/configs/stm32mp15_dhcor_basic_defconfig
>>>>> index b54ff9301461..d4786500271a 100644
>>>>> --- a/configs/stm32mp15_dhcor_basic_defconfig
>>>>> +++ b/configs/stm32mp15_dhcor_basic_defconfig
>>>>> @@ -92,6 +92,7 @@ 
>>>>> CONFIG_MTDPARTS_DEFAULT="mtdparts=nor0:256k(fsbl1),256k(fsbl2),1408k(uboot),64k(
>>>>>    # CONFIG_ISO_PARTITION is not set
>>>>>    # CONFIG_SPL_PARTITION_UUIDS is not set
>>>>>    CONFIG_OF_LIVE=y
>>>>> +CONFIG_OF_LIST="stm32mp15xx-dhcor-avenger96 
>>>>> stm32mp15xx-dhcor-testbench stm32mp15xx-dhcor-drc-compact"
>>>>>    CONFIG_OF_SPL_REMOVE_PROPS="interrupts interrupt-names 
>>>>> interrupts-extended interrupt-controller \\\#interrupt-cells 
>>>>> interrupt-parent dmas dma-names assigned-clocks 
>>>>> assigned-clock-rates assigned-clock-parents hwlocks"
>>>>>    CONFIG_ENV_IS_IN_SPI_FLASH=y
>>>>>    CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
>>>>
>>>>
>>>> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>>>>
>>>> Thanks
>>>> Patrick
>>>>
>>>
>>> Applied to u-boot-stm/next
>>
>> Since this is a bugfix, should be for current.
>
> I do not see this bugfix in u-boot 2023.07 release, even though ST has 
> been notified this is a bugfix for that release a month before the 
> release. Why ?


Sorry, it is is a mistake.

Patrice miss your previous message

and we don't sent a new pull request for v2023.07 bugfix.


Patrick