* [PATCH 1/2] tty: serial: xuartps: Remove .owner field for driver
@ 2014-08-13 11:53 ` Michal Simek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2014-08-13 11:53 UTC (permalink / raw)
To: linux-kernel, monstr
Cc: Greg Kroah-Hartman, linux-serial, Jiri Slaby, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
There is no need to init .owner field.
Based on the patch from Peter Griffin <peter.griffin@linaro.org>
"mmc: remove .owner field for drivers using module_platform_driver"
This patch removes the superflous .owner field for drivers which
use the module_platform_driver API, as this is overriden in
platform_driver_register anyway."
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/tty/serial/xilinx_uartps.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 01951d27cc03..c3c252db8b61 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -1428,7 +1428,6 @@ static struct platform_driver cdns_uart_platform_driver = {
.probe = cdns_uart_probe,
.remove = cdns_uart_remove,
.driver = {
- .owner = THIS_MODULE,
.name = CDNS_UART_NAME,
.of_match_table = cdns_uart_of_match,
.pm = &cdns_uart_dev_pm_ops,
--
1.8.2.3
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] tty: serial: xuartps: Remove .owner field for driver
@ 2014-08-13 11:53 ` Michal Simek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2014-08-13 11:53 UTC (permalink / raw)
To: linux-arm-kernel
There is no need to init .owner field.
Based on the patch from Peter Griffin <peter.griffin@linaro.org>
"mmc: remove .owner field for drivers using module_platform_driver"
This patch removes the superflous .owner field for drivers which
use the module_platform_driver API, as this is overriden in
platform_driver_register anyway."
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/tty/serial/xilinx_uartps.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 01951d27cc03..c3c252db8b61 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -1428,7 +1428,6 @@ static struct platform_driver cdns_uart_platform_driver = {
.probe = cdns_uart_probe,
.remove = cdns_uart_remove,
.driver = {
- .owner = THIS_MODULE,
.name = CDNS_UART_NAME,
.of_match_table = cdns_uart_of_match,
.pm = &cdns_uart_dev_pm_ops,
--
1.8.2.3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140813/e9e0b5d7/attachment.sig>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] tty: serial: uartlite: Remove .owner field for driver
2014-08-13 11:53 ` Michal Simek
(?)
@ 2014-08-13 11:53 ` Michal Simek
2014-08-16 22:23 ` Peter Korsgaard
-1 siblings, 1 reply; 4+ messages in thread
From: Michal Simek @ 2014-08-13 11:53 UTC (permalink / raw)
To: linux-kernel, monstr
Cc: Greg Kroah-Hartman, linux-serial, arnd, Peter Korsgaard,
Grant Likely, Rob Herring, Jiri Slaby
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
There is no need to init .owner field.
Based on the patch from Peter Griffin <peter.griffin@linaro.org>
"mmc: remove .owner field for drivers using module_platform_driver"
This patch removes the superflous .owner field for drivers which
use the module_platform_driver API, as this is overriden in
platform_driver_register anyway."
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/tty/serial/uartlite.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
index 9fc22f40796e..189f52e3111f 100644
--- a/drivers/tty/serial/uartlite.c
+++ b/drivers/tty/serial/uartlite.c
@@ -665,7 +665,6 @@ static struct platform_driver ulite_platform_driver = {
.probe = ulite_probe,
.remove = ulite_remove,
.driver = {
- .owner = THIS_MODULE,
.name = "uartlite",
.of_match_table = of_match_ptr(ulite_of_match),
},
--
1.8.2.3
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] tty: serial: uartlite: Remove .owner field for driver
2014-08-13 11:53 ` [PATCH 2/2] tty: serial: uartlite: " Michal Simek
@ 2014-08-16 22:23 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2014-08-16 22:23 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, Greg Kroah-Hartman, linux-serial, arnd,
Peter Korsgaard, Grant Likely, Rob Herring, Jiri Slaby
>>>>> "Michal" == Michal Simek <michal.simek@xilinx.com> writes:
> There is no need to init .owner field.
> Based on the patch from Peter Griffin <peter.griffin@linaro.org>
> "mmc: remove .owner field for drivers using module_platform_driver"
> This patch removes the superflous .owner field for drivers which
> use the module_platform_driver API, as this is overriden in
> platform_driver_register anyway."
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
It would be good with a reference to the commit adding this to
platform_driver_register (9447057eaff8) - But Ok.
Acked-by: Peter Korsgaard <peter@korsgaard.com>
> drivers/tty/serial/uartlite.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index 9fc22f40796e..189f52e3111f 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -665,7 +665,6 @@ static struct platform_driver ulite_platform_driver = {
> .probe = ulite_probe,
> .remove = ulite_remove,
> .driver = {
> - .owner = THIS_MODULE,
> .name = "uartlite",
> .of_match_table = of_match_ptr(ulite_of_match),
> },
> --
> 1.8.2.3
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-16 22:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-13 11:53 [PATCH 1/2] tty: serial: xuartps: Remove .owner field for driver Michal Simek
2014-08-13 11:53 ` Michal Simek
2014-08-13 11:53 ` [PATCH 2/2] tty: serial: uartlite: " Michal Simek
2014-08-16 22:23 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.