From: Qian Cai <quic_qiancai@quicinc.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Yury Norov <yury.norov@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bitmap: simplify GENMASK(size - 1, 0) lines
Date: Wed, 27 Oct 2021 11:06:53 -0400 [thread overview]
Message-ID: <4afd7242-a8f9-6d41-e1a8-e6cfbe3cea6e@quicinc.com> (raw)
In-Reply-To: <YXkfaGlmbkXXJGih@smile.fi.intel.com>
On 10/27/21 5:44 AM, Andy Shevchenko wrote:
> Agree, but you see a problem here, W=2, for example, is high due to
> a lot of non-sense (or very little sense) noise. The warning you got
> is hidden on purpose. On top of that, the code has not been thought
> through at all, despite missed test run. This is easy to catch.
>
> What I expect from "a stranger" who is in doubt (obviously) how this
> code works to ask and then decide how to act.
>
> And on top of all these, we used to have UMN case which makes me
> first think of bad experiments on the community (I really haven't
> believed that this patch was sent consciously).
>
> So, please be careful next time and better ask first before acting,
> if in doubt.
Yes, I am an idiot. My brain was short-circled for a moment to be
totally mistaken with "GENMASK() == 0" instead GENMASK_INPUT_CHECK(). I
am not sure how to avoid those short-circles again in the future though
apart from thinking about going to an office in the near future, so kids
at home would drive my less crazy. Of course, I knew the trick for
lib_test.c now which should help me in this subsystem in the future.
Thanks for your time, Andy.
next prev parent reply other threads:[~2021-10-27 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 14:41 [PATCH] bitmap: simplify GENMASK(size - 1, 0) lines Qian Cai
2021-10-26 15:10 ` Andy Shevchenko
2021-10-26 15:26 ` Qian Cai
2021-10-26 18:54 ` Yury Norov
2021-10-26 19:21 ` Andy Shevchenko
2021-10-26 19:28 ` Yury Norov
2021-10-26 19:42 ` Andy Shevchenko
2021-10-26 19:54 ` Qian Cai
2021-10-27 9:44 ` Andy Shevchenko
2021-10-27 15:06 ` Qian Cai [this message]
2021-10-26 19:33 ` Qian Cai
2021-10-27 9:34 ` Andy Shevchenko
2021-10-29 1:36 ` [bitmap] ca95e676a1: BUG:unable_to_handle_page_fault_for_address kernel test robot
2021-10-29 1:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4afd7242-a8f9-6d41-e1a8-e6cfbe3cea6e@quicinc.com \
--to=quic_qiancai@quicinc.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.