From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Qian Cai <quic_qiancai@quicinc.com>
Cc: Yury Norov <yury.norov@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bitmap: simplify GENMASK(size - 1, 0) lines
Date: Wed, 27 Oct 2021 12:34:55 +0300 [thread overview]
Message-ID: <YXkdP/Rr+m30Hh72@smile.fi.intel.com> (raw)
In-Reply-To: <397751ea-536b-af3c-752d-c4b1045e6e56@quicinc.com>
On Tue, Oct 26, 2021 at 03:33:48PM -0400, Qian Cai wrote:
> On 10/26/21 3:21 PM, Andy Shevchenko wrote:
> > Can you explain to me how it is supposed to work?
> >
> > For example,
> >
> > x = 0xaa55;
> > size = 5;
> >
> > printf("%lu\n", find_first_bit(&x, size));
> >
> > In the resulting code we will always have 5 as the result,
> > but is it correct one?
>
> Sorry, my bad. GENMASK(size - 1, 0) would just become __GENMASK(size -
> 1, 0) instead of 0. Let me revisit it and run some tests first.
And we do not want to have __GENMASK() in the code.
Btw, I found one lurking around. Will fix it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-10-27 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 14:41 [PATCH] bitmap: simplify GENMASK(size - 1, 0) lines Qian Cai
2021-10-26 15:10 ` Andy Shevchenko
2021-10-26 15:26 ` Qian Cai
2021-10-26 18:54 ` Yury Norov
2021-10-26 19:21 ` Andy Shevchenko
2021-10-26 19:28 ` Yury Norov
2021-10-26 19:42 ` Andy Shevchenko
2021-10-26 19:54 ` Qian Cai
2021-10-27 9:44 ` Andy Shevchenko
2021-10-27 15:06 ` Qian Cai
2021-10-26 19:33 ` Qian Cai
2021-10-27 9:34 ` Andy Shevchenko [this message]
2021-10-29 1:36 ` [bitmap] ca95e676a1: BUG:unable_to_handle_page_fault_for_address kernel test robot
2021-10-29 1:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXkdP/Rr+m30Hh72@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=quic_qiancai@quicinc.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.