All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <thesven73@gmail.com>, <miquel.raynal@bootlin.com>,
	<richard@nod.at>, <vigneshr@ti.com>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
Date: Mon, 29 Jun 2020 12:50:11 +0000	[thread overview]
Message-ID: <4b0f2a2d-66be-4cdd-8384-a80f6b729d74@microchip.com> (raw)
In-Reply-To: <20200613235331.24678-1-TheSven73@gmail.com>

Hi, Sven,

On 6/14/20 2:53 AM, Sven Van Asbroeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> This chip is (nearly) identical to the Winbond w25q64 which is
> already supported by Linux. Compared to the w25q64, the 'jv'
> does not support Quad SPI mode, and has a different JEDEC ID.

I'm reading the following datasheet:
https://www.winbond.com/resource-files/w25q64jv%20revj%2003272018%20plus.pdf

w25q64jvm (0xef7017) comes with QE bit set to a 0 state, but can be
set to 1, so Quad mode can be supported. Would you please set SPI_NOR_DUAL_READ
and SPI_NOR_QUAD_READ flags and test and see if Quad works? If all good,
please specify in the commit message with which controller you did the tests.

> 
> To: Tudor Ambarus <tudor.ambarus@microchip.com>
> To: Miquel Raynal <miquel.raynal@bootlin.com>
> To: Richard Weinberger <richard@nod.at>
> To: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org

Are these tags really necessary? Would you drop them?

> Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
> ---
> 
> Tree: next-20200613
> 
>  drivers/mtd/spi-nor/winbond.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 5062af10f138..18bdff02f57f 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -65,6 +65,7 @@ static const struct flash_info winbond_parts[] = {
>                             SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
>         { "w25x64", INFO(0xef3017, 0, 64 * 1024, 128, SECT_4K) },
>         { "w25q64", INFO(0xef4017, 0, 64 * 1024, 128, SECT_4K) },
> +       { "w25q64jv", INFO(0xef7017, 0, 64 * 1024, 128, SECT_4K) },

I would name it "w25q64jvm". Check "11.ORDERING INFORMATION". Although the
datasheet refers to these flashes as "W25Q64JV-IQ/JQ" and "W25Q64JV-IM/JM",
I find that the temperature range is not a differentiator in the flash ID,
so I would drop it.

Cheers,
ta

WARNING: multiple messages have this Message-ID (diff)
From: <Tudor.Ambarus@microchip.com>
To: <thesven73@gmail.com>, <miquel.raynal@bootlin.com>,
	<richard@nod.at>, <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
Date: Mon, 29 Jun 2020 12:50:11 +0000	[thread overview]
Message-ID: <4b0f2a2d-66be-4cdd-8384-a80f6b729d74@microchip.com> (raw)
In-Reply-To: <20200613235331.24678-1-TheSven73@gmail.com>

Hi, Sven,

On 6/14/20 2:53 AM, Sven Van Asbroeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> This chip is (nearly) identical to the Winbond w25q64 which is
> already supported by Linux. Compared to the w25q64, the 'jv'
> does not support Quad SPI mode, and has a different JEDEC ID.

I'm reading the following datasheet:
https://www.winbond.com/resource-files/w25q64jv%20revj%2003272018%20plus.pdf

w25q64jvm (0xef7017) comes with QE bit set to a 0 state, but can be
set to 1, so Quad mode can be supported. Would you please set SPI_NOR_DUAL_READ
and SPI_NOR_QUAD_READ flags and test and see if Quad works? If all good,
please specify in the commit message with which controller you did the tests.

> 
> To: Tudor Ambarus <tudor.ambarus@microchip.com>
> To: Miquel Raynal <miquel.raynal@bootlin.com>
> To: Richard Weinberger <richard@nod.at>
> To: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org

Are these tags really necessary? Would you drop them?

> Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
> ---
> 
> Tree: next-20200613
> 
>  drivers/mtd/spi-nor/winbond.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 5062af10f138..18bdff02f57f 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -65,6 +65,7 @@ static const struct flash_info winbond_parts[] = {
>                             SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
>         { "w25x64", INFO(0xef3017, 0, 64 * 1024, 128, SECT_4K) },
>         { "w25q64", INFO(0xef4017, 0, 64 * 1024, 128, SECT_4K) },
> +       { "w25q64jv", INFO(0xef7017, 0, 64 * 1024, 128, SECT_4K) },

I would name it "w25q64jvm". Check "11.ORDERING INFORMATION". Although the
datasheet refers to these flashes as "W25Q64JV-IQ/JQ" and "W25Q64JV-IM/JM",
I find that the temperature range is not a differentiator in the flash ID,
so I would drop it.

Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2020-06-29 19:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-13 23:53 [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash Sven Van Asbroeck
2020-06-13 23:53 ` Sven Van Asbroeck
2020-06-24 17:15 ` Sven Van Asbroeck
2020-06-24 17:15   ` Sven Van Asbroeck
2020-06-29 12:50 ` Tudor.Ambarus [this message]
2020-06-29 12:50   ` Tudor.Ambarus
2020-06-29 14:53   ` Sven Van Asbroeck
2020-06-29 14:53     ` Sven Van Asbroeck
2020-06-29 19:01     ` Tudor.Ambarus
2020-06-29 19:01       ` Tudor.Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b0f2a2d-66be-4cdd-8384-a80f6b729d74@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=thesven73@gmail.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.