All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Florian Eckert <fe@dev.tdt.de>, Randy Dunlap <rdunlap@infradead.org>
Cc: kernel test robot <lkp@intel.com>, Arnd Bergmann <arnd@arndb.de>,
	llvm@lists.linux.dev, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org,
	Masahiro Yamada <masahiroy@kernel.org>,
	Alex Shi <alexs@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Miguel Ojeda <ojeda@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>
Subject: Re: drivers/hwmon/ltq-cputemp.c:23:2: error: call to undeclared function 'ltq_cgu_w32'; ISO C99 and later do not support implicit function declarations
Date: Mon, 9 May 2022 16:03:55 -0700	[thread overview]
Message-ID: <4b2a51ec-5643-3429-8271-6d44b9f002b6@roeck-us.net> (raw)
In-Reply-To: <81b9b2cd3f981b6206e9d8c52b3306b3@dev.tdt.de>

On 5/9/22 01:17, Florian Eckert wrote:
> 
>>>
>>> vim +/ltq_cgu_w32 +23 drivers/hwmon/ltq-cputemp.c
>>>
>>> 7074d0a9275860 Florian Eckert 2017-09-01  20
>>> 7074d0a9275860 Florian Eckert 2017-09-01  21  static void ltq_cputemp_enable(void)
>>> 7074d0a9275860 Florian Eckert 2017-09-01  22  {
>>> 7074d0a9275860 Florian Eckert 2017-09-01 @23     ltq_cgu_w32(ltq_cgu_r32(CGU_GPHY1_CR) | CGU_TEMP_PD, CGU_GPHY1_CR);
>>> 7074d0a9275860 Florian Eckert 2017-09-01  24  }
>>> 7074d0a9275860 Florian Eckert 2017-09-01  25
>>>
>>> :::::: The code at line 23 was first introduced by commit
>>> :::::: 7074d0a92758603369655ef5d4f49e6caaae0b4e hwmon: (ltq-cputemp) add cpu temp sensor driver
>>>
>>> :::::: TO: Florian Eckert <fe@dev.tdt.de>
>>> :::::: CC: Guenter Roeck <linux@roeck-us.net>
>>
>> This driver builds fine if I change it from SOC_FALCON to SOC_XWAY.
>> Maybe its Kconfig entry should be stronger?
>>
>> config SENSORS_LTQ_CPUTEMP
>>     bool "Lantiq cpu temperature sensor driver"
>> -    depends on LANTIQ
>> +    depends on SOC_XWAY
> 
> Fine with me. I think it's better to narrow it down.

I'll be happy to accept a patch doing that.

Guenter


WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: kbuild-all@lists.01.org
Subject: Re: drivers/hwmon/ltq-cputemp.c:23:2: error: call to undeclared function 'ltq_cgu_w32'; ISO C99 and later do not support implicit function declarations
Date: Mon, 09 May 2022 16:03:55 -0700	[thread overview]
Message-ID: <4b2a51ec-5643-3429-8271-6d44b9f002b6@roeck-us.net> (raw)
In-Reply-To: <81b9b2cd3f981b6206e9d8c52b3306b3@dev.tdt.de>

[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]

On 5/9/22 01:17, Florian Eckert wrote:
> 
>>>
>>> vim +/ltq_cgu_w32 +23 drivers/hwmon/ltq-cputemp.c
>>>
>>> 7074d0a9275860 Florian Eckert 2017-09-01  20
>>> 7074d0a9275860 Florian Eckert 2017-09-01  21  static void ltq_cputemp_enable(void)
>>> 7074d0a9275860 Florian Eckert 2017-09-01  22  {
>>> 7074d0a9275860 Florian Eckert 2017-09-01 @23     ltq_cgu_w32(ltq_cgu_r32(CGU_GPHY1_CR) | CGU_TEMP_PD, CGU_GPHY1_CR);
>>> 7074d0a9275860 Florian Eckert 2017-09-01  24  }
>>> 7074d0a9275860 Florian Eckert 2017-09-01  25
>>>
>>> :::::: The code at line 23 was first introduced by commit
>>> :::::: 7074d0a92758603369655ef5d4f49e6caaae0b4e hwmon: (ltq-cputemp) add cpu temp sensor driver
>>>
>>> :::::: TO: Florian Eckert <fe@dev.tdt.de>
>>> :::::: CC: Guenter Roeck <linux@roeck-us.net>
>>
>> This driver builds fine if I change it from SOC_FALCON to SOC_XWAY.
>> Maybe its Kconfig entry should be stronger?
>>
>> config SENSORS_LTQ_CPUTEMP
>>     bool "Lantiq cpu temperature sensor driver"
>> -    depends on LANTIQ
>> +    depends on SOC_XWAY
> 
> Fine with me. I think it's better to narrow it down.

I'll be happy to accept a patch doing that.

Guenter

  reply	other threads:[~2022-05-09 23:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-07 20:54 drivers/hwmon/ltq-cputemp.c:23:2: error: call to undeclared function 'ltq_cgu_w32'; ISO C99 and later do not support implicit function declarations kernel test robot
2022-05-09  0:03 ` Randy Dunlap
2022-05-09  0:03   ` Randy Dunlap
2022-05-09  8:17   ` Florian Eckert
2022-05-09  8:17     ` Florian Eckert
2022-05-09 23:03     ` Guenter Roeck [this message]
2022-05-09 23:03       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b2a51ec-5643-3429-8271-6d44b9f002b6@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=alexs@kernel.org \
    --cc=arnd@arndb.de \
    --cc=fe@dev.tdt.de \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=ojeda@kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.