From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
andersson@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org, djakov@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: add IPQ9574 interconnect clocks support
Date: Sat, 23 Mar 2024 01:29:00 +0100 [thread overview]
Message-ID: <4b37a6e5-f917-4ead-9678-554a0d8f4660@linaro.org> (raw)
In-Reply-To: <20240321043149.2739204-3-quic_varada@quicinc.com>
On 21.03.2024 05:31, Varadarajan Narayanan wrote:
> Unlike MSM platforms that manage NoC related clocks and scaling
> from RPM, IPQ SoCs dont involve RPM in managing NoC related
> clocks and there is no NoC scaling.
>
> However, there is a requirement to enable some NoC interface
> clocks for accessing the peripheral controllers present on
> these NoCs.
>
> Hence adding a minimalistic interconnect driver that can enable
> the relevant clocks. This is similar to msm8996-cbf's usage of
> icc-clk framework.
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
[...]
> @@ -9,9 +9,16 @@
> #include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> +#if IS_ENABLED(CONFIG_INTERCONNECT)
This is bad practice, especially given the reasoning for your changes.
It's best if you add a dependency on interconnect to this driver,
otherwise things will go into uncountable EPROBE_DEFERs if there are
nodes consuming icc handles, but the supplier never registers.
[...]
>
> static int gcc_ipq9574_probe(struct platform_device *pdev)
..and that approach could save the probe func from the absolute mess it
has become with this patch
Konrad
next prev parent reply other threads:[~2024-03-23 0:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 4:31 [PATCH 0/2] Add interconnect driver for IPQ9574 SoC Varadarajan Narayanan
2024-03-21 4:31 ` [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm IPQ9574 support Varadarajan Narayanan
2024-03-21 7:23 ` Krzysztof Kozlowski
2024-03-21 9:57 ` Varadarajan Narayanan
2024-03-21 14:35 ` Rob Herring
2024-03-21 15:50 ` Varadarajan Narayanan
2024-03-21 4:31 ` [PATCH 2/2] clk: qcom: add IPQ9574 interconnect clocks support Varadarajan Narayanan
2024-03-21 7:25 ` Krzysztof Kozlowski
2024-03-21 9:56 ` Varadarajan Narayanan
2024-03-22 5:45 ` Krzysztof Kozlowski
2024-03-22 5:55 ` kernel test robot
2024-03-22 11:33 ` kernel test robot
2024-03-23 0:29 ` Konrad Dybcio [this message]
2024-03-25 10:22 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b37a6e5-f917-4ead-9678-554a0d8f4660@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.