* [PATCH] drm/panel: samsung: make vint_table static
@ 2020-09-12 3:38 Jason Yan
2020-09-15 2:04 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Jason Yan @ 2020-09-12 3:38 UTC (permalink / raw)
To: thierry.reding, sam, airlied, daniel, linus.walleij,
laurent.pinchart, dri-devel
Cc: Hulk Robot, Jason Yan
This eliminates the following sparse warning:
drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c:217:15: warning: symbol
'vint_table' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c
index 1d1c79a18613..b3f5797c23e0 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c
@@ -214,7 +214,7 @@ static const u8 gamma_tbl[S6E3HA2_NUM_GAMMA_STEPS][S6E3HA2_GAMMA_CMD_CNT] = {
0x00, 0x00 }
};
-unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = {
+static unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = {
0x18, 0x19, 0x1a, 0x1b, 0x1c,
0x1d, 0x1e, 0x1f, 0x20, 0x21
};
--
2.25.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: samsung: make vint_table static
2020-09-12 3:38 [PATCH] drm/panel: samsung: make vint_table static Jason Yan
@ 2020-09-15 2:04 ` Laurent Pinchart
2020-09-15 3:21 ` Jason Yan
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2020-09-15 2:04 UTC (permalink / raw)
To: Jason Yan; +Cc: airlied, dri-devel, Hulk Robot, thierry.reding, sam
Hi Jason,
Thank you for the patch.
On Sat, Sep 12, 2020 at 11:38:17AM +0800, Jason Yan wrote:
> This eliminates the following sparse warning:
>
> drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c:217:15: warning: symbol
> 'vint_table' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c
> index 1d1c79a18613..b3f5797c23e0 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c
> @@ -214,7 +214,7 @@ static const u8 gamma_tbl[S6E3HA2_NUM_GAMMA_STEPS][S6E3HA2_GAMMA_CMD_CNT] = {
> 0x00, 0x00 }
> };
>
> -unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = {
> +static unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = {
Shouldn't it be const, while at it ?
> 0x18, 0x19, 0x1a, 0x1b, 0x1c,
> 0x1d, 0x1e, 0x1f, 0x20, 0x21
> };
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: samsung: make vint_table static
2020-09-15 2:04 ` Laurent Pinchart
@ 2020-09-15 3:21 ` Jason Yan
0 siblings, 0 replies; 3+ messages in thread
From: Jason Yan @ 2020-09-15 3:21 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: airlied, dri-devel, Hulk Robot, thierry.reding, sam
在 2020/9/15 10:04, Laurent Pinchart 写道:
> Hi Jason,
>
> Thank you for the patch.
>
> On Sat, Sep 12, 2020 at 11:38:17AM +0800, Jason Yan wrote:
>> This eliminates the following sparse warning:
>>
>> drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c:217:15: warning: symbol
>> 'vint_table' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>> drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c
>> index 1d1c79a18613..b3f5797c23e0 100644
>> --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c
>> +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c
>> @@ -214,7 +214,7 @@ static const u8 gamma_tbl[S6E3HA2_NUM_GAMMA_STEPS][S6E3HA2_GAMMA_CMD_CNT] = {
>> 0x00, 0x00 }
>> };
>>
>> -unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = {
>> +static unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = {
>
> Shouldn't it be const, while at it ?
Yes, I will send v2.
>
>> 0x18, 0x19, 0x1a, 0x1b, 0x1c,
>> 0x1d, 0x1e, 0x1f, 0x20, 0x21
>> };
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-15 7:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-12 3:38 [PATCH] drm/panel: samsung: make vint_table static Jason Yan
2020-09-15 2:04 ` Laurent Pinchart
2020-09-15 3:21 ` Jason Yan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.