All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Guenter Roeck <linux@roeck-us.net>, Dinh Nguyen <dinguyen@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nios2: Make NIOS2_DTB_SOURCE_BOOL depend on !COMPILE_TEST
Date: Wed, 20 Oct 2021 13:15:46 -0700	[thread overview]
Message-ID: <4b747abf-73f1-fa97-cb2b-23d8c838426e@infradead.org> (raw)
In-Reply-To: <20211020191116.2510450-1-linux@roeck-us.net>

On 10/20/21 12:11 PM, Guenter Roeck wrote:
> nios2:allmodconfig builds fail with
> 
> make[1]: *** No rule to make target 'arch/nios2/boot/dts/""',
> 	needed by 'arch/nios2/boot/dts/built-in.a'.  Stop.
> make: [Makefile:1868: arch/nios2/boot/dts] Error 2 (ignored)
> 
> This is seen with compile tests since those enable NIOS2_DTB_SOURCE_BOOL,
> which in turn enables NIOS2_DTB_SOURCE. This causes the build error
> because the default value for NIOS2_DTB_SOURCE is an empty string.
> Disable NIOS2_DTB_SOURCE_BOOL for compile tests to avoid the error.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Thanks, I've seen this problem also.

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

> ---
> v2: Include error message
> 
>   arch/nios2/platform/Kconfig.platform | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/nios2/platform/Kconfig.platform b/arch/nios2/platform/Kconfig.platform
> index 9e32fb7f3d4c..e849daff6fd1 100644
> --- a/arch/nios2/platform/Kconfig.platform
> +++ b/arch/nios2/platform/Kconfig.platform
> @@ -37,6 +37,7 @@ config NIOS2_DTB_PHYS_ADDR
>   
>   config NIOS2_DTB_SOURCE_BOOL
>   	bool "Compile and link device tree into kernel image"
> +	depends on !COMPILE_TEST
>   	help
>   	  This allows you to specify a dts (device tree source) file
>   	  which will be compiled and linked into the kernel image.
> 


-- 
~Randy

  reply	other threads:[~2021-10-20 20:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 19:11 [PATCH v2] nios2: Make NIOS2_DTB_SOURCE_BOOL depend on !COMPILE_TEST Guenter Roeck
2021-10-20 20:15 ` Randy Dunlap [this message]
2021-10-21 14:01   ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b747abf-73f1-fa97-cb2b-23d8c838426e@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=dinguyen@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.