[PATCH v2] nios2: Make NIOS2_DTB_SOURCE_BOOL depend on !COMPILE_TEST

[PATCH v2] nios2: Make NIOS2_DTB_SOURCE_BOOL depend on !COMPILE_TEST

[Guenter Roeck]

nios2:allmodconfig builds fail with

make[1]: *** No rule to make target 'arch/nios2/boot/dts/""',
	needed by 'arch/nios2/boot/dts/built-in.a'.  Stop.
make: [Makefile:1868: arch/nios2/boot/dts] Error 2 (ignored)

This is seen with compile tests since those enable NIOS2_DTB_SOURCE_BOOL,
which in turn enables NIOS2_DTB_SOURCE. This causes the build error
because the default value for NIOS2_DTB_SOURCE is an empty string.
Disable NIOS2_DTB_SOURCE_BOOL for compile tests to avoid the error.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
v2: Include error message

 arch/nios2/platform/Kconfig.platform | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/nios2/platform/Kconfig.platform b/arch/nios2/platform/Kconfig.platform
index 9e32fb7f3d4c..e849daff6fd1 100644
--- a/arch/nios2/platform/Kconfig.platform
+++ b/arch/nios2/platform/Kconfig.platform
@@ -37,6 +37,7 @@ config NIOS2_DTB_PHYS_ADDR
 
 config NIOS2_DTB_SOURCE_BOOL
 	bool "Compile and link device tree into kernel image"
+	depends on !COMPILE_TEST
 	help
 	  This allows you to specify a dts (device tree source) file
 	  which will be compiled and linked into the kernel image.
-- 
2.33.0

Re: [PATCH v2] nios2: Make NIOS2_DTB_SOURCE_BOOL depend on !COMPILE_TEST

[Randy Dunlap]

On 10/20/21 12:11 PM, Guenter Roeck wrote:
> nios2:allmodconfig builds fail with
> 
> make[1]: *** No rule to make target 'arch/nios2/boot/dts/""',
> 	needed by 'arch/nios2/boot/dts/built-in.a'.  Stop.
> make: [Makefile:1868: arch/nios2/boot/dts] Error 2 (ignored)
> 
> This is seen with compile tests since those enable NIOS2_DTB_SOURCE_BOOL,
> which in turn enables NIOS2_DTB_SOURCE. This causes the build error
> because the default value for NIOS2_DTB_SOURCE is an empty string.
> Disable NIOS2_DTB_SOURCE_BOOL for compile tests to avoid the error.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Thanks, I've seen this problem also.

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

> ---
> v2: Include error message
> 
>   arch/nios2/platform/Kconfig.platform | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/nios2/platform/Kconfig.platform b/arch/nios2/platform/Kconfig.platform
> index 9e32fb7f3d4c..e849daff6fd1 100644
> --- a/arch/nios2/platform/Kconfig.platform
> +++ b/arch/nios2/platform/Kconfig.platform
> @@ -37,6 +37,7 @@ config NIOS2_DTB_PHYS_ADDR
>   
>   config NIOS2_DTB_SOURCE_BOOL
>   	bool "Compile and link device tree into kernel image"
> +	depends on !COMPILE_TEST
>   	help
>   	  This allows you to specify a dts (device tree source) file
>   	  which will be compiled and linked into the kernel image.
> 


-- 
~Randy

Re: [PATCH v2] nios2: Make NIOS2_DTB_SOURCE_BOOL depend on !COMPILE_TEST

[Dinh Nguyen]

On 10/20/21 3:15 PM, Randy Dunlap wrote:
> On 10/20/21 12:11 PM, Guenter Roeck wrote:
>> nios2:allmodconfig builds fail with
>>
>> make[1]: *** No rule to make target 'arch/nios2/boot/dts/""',
>>     needed by 'arch/nios2/boot/dts/built-in.a'.  Stop.
>> make: [Makefile:1868: arch/nios2/boot/dts] Error 2 (ignored)
>>
>> This is seen with compile tests since those enable NIOS2_DTB_SOURCE_BOOL,
>> which in turn enables NIOS2_DTB_SOURCE. This causes the build error
>> because the default value for NIOS2_DTB_SOURCE is an empty string.
>> Disable NIOS2_DTB_SOURCE_BOOL for compile tests to avoid the error.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Thanks, I've seen this problem also.
> 
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> 

Does this need a Fixes tag?

Fixes: 2fc8483fdcde ("nios2: Build infrastructure")

Dinh