* [PATCH] platform/x86: fix surface3_button build errors
@ 2016-12-27 22:28 Randy Dunlap
2016-12-28 20:45 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2016-12-27 22:28 UTC (permalink / raw)
To: LKML, Platform Driver, Darren Hart; +Cc: kbuild test robot, Benjamin Tissoires
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors when I2C=m and SURFACE_3_BUTTON=y.
The driver uses i2c interfaces so it should depend on I2C.
drivers/built-in.o: In function `surface3_driver_init':
surface3_button.c:(.init.text+0x75cb0): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `surface3_driver_exit':
surface3_button.c:(.exit.text+0x31a8): undefined reference to `i2c_del_driver'
Fixes: 1a64b719d3ae (platform/x86: Introduce button support for the Surface 3)
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: platform-driver-x86@vger.kernel.org
Cc: Darren Hart <dvhart@infradead.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-410-rc1.orig/drivers/platform/x86/Kconfig
+++ lnx-410-rc1/drivers/platform/x86/Kconfig
@@ -1034,7 +1034,7 @@ config SURFACE_PRO3_BUTTON
config SURFACE_3_BUTTON
tristate "Power/home/volume buttons driver for Microsoft Surface 3 tablet"
- depends on ACPI && KEYBOARD_GPIO
+ depends on ACPI && KEYBOARD_GPIO && I2C
---help---
This driver handles the power/home/volume buttons on the Microsoft Surface 3 tablet.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: fix surface3_button build errors
2016-12-27 22:28 [PATCH] platform/x86: fix surface3_button build errors Randy Dunlap
@ 2016-12-28 20:45 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2016-12-28 20:45 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, Platform Driver, Darren Hart, kbuild test robot,
Benjamin Tissoires
On Wed, Dec 28, 2016 at 12:28 AM, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when I2C=m and SURFACE_3_BUTTON=y.
> The driver uses i2c interfaces so it should depend on I2C.
>
> drivers/built-in.o: In function `surface3_driver_init':
> surface3_button.c:(.init.text+0x75cb0): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `surface3_driver_exit':
> surface3_button.c:(.exit.text+0x31a8): undefined reference to `i2c_del_driver'
>
> Fixes: 1a64b719d3ae (platform/x86: Introduce button support for the Surface 3)
>
Pushed to fixes.
Thanks!
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>
> Cc: platform-driver-x86@vger.kernel.org
> Cc: Darren Hart <dvhart@infradead.org>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-410-rc1.orig/drivers/platform/x86/Kconfig
> +++ lnx-410-rc1/drivers/platform/x86/Kconfig
> @@ -1034,7 +1034,7 @@ config SURFACE_PRO3_BUTTON
>
> config SURFACE_3_BUTTON
> tristate "Power/home/volume buttons driver for Microsoft Surface 3 tablet"
> - depends on ACPI && KEYBOARD_GPIO
> + depends on ACPI && KEYBOARD_GPIO && I2C
> ---help---
> This driver handles the power/home/volume buttons on the Microsoft Surface 3 tablet.
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-28 20:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-27 22:28 [PATCH] platform/x86: fix surface3_button build errors Randy Dunlap
2016-12-28 20:45 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.