All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Dadap <ddadap@nvidia.com>
To: Alex Deucher <alexdeucher@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	"markgross@kernel.org" <markgross@kernel.org>,
	"pobrn@protonmail.com" <pobrn@protonmail.com>,
	Alexandru Dinu <alex.dinu07@gmail.com>,
	"Mario.Limonciello@amd.com" <Mario.Limonciello@amd.com>
Subject: Re: [PATCH v2] nvidia-wmi-ec-backlight: Add workarounds for confused firmware
Date: Thu, 17 Mar 2022 13:50:20 -0500	[thread overview]
Message-ID: <4bbde905-e89d-d8ba-01bb-f478fee2e417@nvidia.com> (raw)
In-Reply-To: <CADnq5_M3620a5tqqOMARZMG+zJYWKu_dN_F5g-KR0H=t2_qoSQ@mail.gmail.com>

On 3/17/22 12:35, Alex Deucher wrote:
> Sorry for jumping in here, but I can't seem to find the original
> thread with this comment.  amdgpu_atombios_encoder_init_backlight() is
> not applicable to these systems.  That is the old pre-DC code path.
> You want amdgpu_dm_register_backlight_device() for modern hardware.


Oops, thanks for the correction. Alex Dinu: see the above for the 
correct code path to disable to test whether not registering the amdgpu 
backlight device helps. I have some other things to attend to, so it 
will be a little while before I can get you the instrumented driver I 
mentioned in one of my replies to Hans, but hopefully we'll be able to 
figure something out to actually switch the backlight control to EC 
without having to do a suspend/resume cycle.


WARNING: multiple messages have this Message-ID (diff)
From: Daniel Dadap <ddadap@nvidia.com>
To: Alex Deucher <alexdeucher@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	"markgross@kernel.org" <markgross@kernel.org>,
	"pobrn@protonmail.com" <pobrn@protonmail.com>,
	"Mario.Limonciello@amd.com" <Mario.Limonciello@amd.com>,
	Alexandru Dinu <alex.dinu07@gmail.com>
Subject: Re: [PATCH v2] nvidia-wmi-ec-backlight: Add workarounds for confused firmware
Date: Thu, 17 Mar 2022 13:50:20 -0500	[thread overview]
Message-ID: <4bbde905-e89d-d8ba-01bb-f478fee2e417@nvidia.com> (raw)
In-Reply-To: <CADnq5_M3620a5tqqOMARZMG+zJYWKu_dN_F5g-KR0H=t2_qoSQ@mail.gmail.com>

On 3/17/22 12:35, Alex Deucher wrote:
> Sorry for jumping in here, but I can't seem to find the original
> thread with this comment.  amdgpu_atombios_encoder_init_backlight() is
> not applicable to these systems.  That is the old pre-DC code path.
> You want amdgpu_dm_register_backlight_device() for modern hardware.


Oops, thanks for the correction. Alex Dinu: see the above for the 
correct code path to disable to test whether not registering the amdgpu 
backlight device helps. I have some other things to attend to, so it 
will be a little while before I can get you the instrumented driver I 
mentioned in one of my replies to Hans, but hopefully we'll be able to 
figure something out to actually switch the backlight control to EC 
without having to do a suspend/resume cycle.


  reply	other threads:[~2022-03-17 18:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16  1:25 [PATCH] nvidia-wmi-ec-backlight: Add workarounds for confused firmware Daniel Dadap
2022-03-16  2:50 ` Barnabás Pőcze
2022-03-16 15:11   ` Daniel Dadap
2022-03-16 15:29     ` Limonciello, Mario
2022-03-16 17:08       ` Daniel Dadap
2022-03-16 17:21         ` Limonciello, Mario
2022-03-16 17:37           ` Daniel Dadap
2022-03-16 18:25             ` Limonciello, Mario
2022-03-16 19:23               ` Daniel Dadap
2022-03-16 19:25                 ` Limonciello, Mario
2022-03-16 20:33     ` [PATCH v2] " Daniel Dadap
2022-03-16 21:28       ` Daniel Dadap
2022-03-16 22:09         ` Alexandru Dinu
2022-03-16 22:14           ` Alexandru Dinu
2023-01-30 22:00           ` Daniel Dadap
2023-01-31 19:56             ` Alexandru Dinu
2023-02-07 23:23               ` Daniel Dadap
2022-03-17 12:17       ` Hans de Goede
2022-03-17 13:28         ` Daniel Dadap
2022-03-17 16:42           ` Hans de Goede
2022-03-17 16:42             ` Hans de Goede
2022-03-17 17:35             ` Alex Deucher
2022-03-17 18:50               ` Daniel Dadap [this message]
2022-03-17 18:50                 ` Daniel Dadap
2022-03-17 18:36             ` Daniel Dadap
2022-03-17 18:36               ` Daniel Dadap
2022-03-18 17:42               ` Hans de Goede
2022-03-18 17:42                 ` Hans de Goede
2022-03-16 16:09 ` [PATCH] " Hans de Goede
2022-03-16 17:22   ` Daniel Dadap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bbde905-e89d-d8ba-01bb-f478fee2e417@nvidia.com \
    --to=ddadap@nvidia.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=alex.dinu07@gmail.com \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pobrn@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.