* [Buildroot] [PATCH 1/1] package/bash: remove development files and modules on the target.
@ 2021-03-31 8:15 Nicolas Cavallari
2021-04-05 9:45 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Cavallari @ 2021-03-31 8:15 UTC (permalink / raw)
To: buildroot
bash installs /lib/pkgconfig/bash.pc on the target, which buildroot does
not remove because it is not in the usual /usr/lib/pkgconfig.
It also install makefiles and example builtins in /lib/bash that are not
required.
The Makefiles and .pc encode the build path and create reproducibility
issues. Remove them.
Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
---
package/bash/bash.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/bash/bash.mk b/package/bash/bash.mk
index efe7cbbe59..6af31f182d 100644
--- a/package/bash/bash.mk
+++ b/package/bash/bash.mk
@@ -41,7 +41,8 @@ endif
define BASH_INSTALL_TARGET_CMDS
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
DESTDIR=$(TARGET_DIR) exec_prefix=/ install
- rm -f $(TARGET_DIR)/bin/bashbug
+ rm -f $(TARGET_DIR)/bin/bashbug $(TARGET_DIR)/lib/pkgconfig/bash.pc
+ rm -rf $(TARGET_DIR)/lib/bash
endef
# Add /bin/bash to /etc/shells otherwise some login tools like dropbear
--
2.31.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/bash: remove development files and modules on the target.
2021-03-31 8:15 [Buildroot] [PATCH 1/1] package/bash: remove development files and modules on the target Nicolas Cavallari
@ 2021-04-05 9:45 ` Thomas Petazzoni
2021-04-06 10:32 ` Nicolas Cavallari
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2021-04-05 9:45 UTC (permalink / raw)
To: buildroot
Hello Nicolas,
On Wed, 31 Mar 2021 10:15:59 +0200
Nicolas Cavallari <nicolas.cavallari@green-communications.fr> wrote:
> diff --git a/package/bash/bash.mk b/package/bash/bash.mk
> index efe7cbbe59..6af31f182d 100644
> --- a/package/bash/bash.mk
> +++ b/package/bash/bash.mk
> @@ -41,7 +41,8 @@ endif
> define BASH_INSTALL_TARGET_CMDS
> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
> DESTDIR=$(TARGET_DIR) exec_prefix=/ install
> - rm -f $(TARGET_DIR)/bin/bashbug
> + rm -f $(TARGET_DIR)/bin/bashbug $(TARGET_DIR)/lib/pkgconfig/bash.pc
I am wondering if target-finalize shouldn't take care of removing
/lib/pkgconfig just like it removes /usr/lib/pkgconfig. This would have
the benefit of also dropping the /lib/pkgconfig folder, which your
change doesn't do.
What do you think?
> + rm -rf $(TARGET_DIR)/lib/bash
> endef
>
> # Add /bin/bash to /etc/shells otherwise some login tools like dropbear
Thanks,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/bash: remove development files and modules on the target.
2021-04-05 9:45 ` Thomas Petazzoni
@ 2021-04-06 10:32 ` Nicolas Cavallari
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Cavallari @ 2021-04-06 10:32 UTC (permalink / raw)
To: buildroot
Hello,
On 05/04/2021 11:45, Thomas Petazzoni wrote:
> On Wed, 31 Mar 2021 10:15:59 +0200
> Nicolas Cavallari <nicolas.cavallari@green-communications.fr> wrote:
>> --- a/package/bash/bash.mk
>> +++ b/package/bash/bash.mk
>> @@ -41,7 +41,8 @@ endif
>> define BASH_INSTALL_TARGET_CMDS
>> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
>> DESTDIR=$(TARGET_DIR) exec_prefix=/ install
>> - rm -f $(TARGET_DIR)/bin/bashbug
>> + rm -f $(TARGET_DIR)/bin/bashbug $(TARGET_DIR)/lib/pkgconfig/bash.pc
>
> I am wondering if target-finalize shouldn't take care of removing
> /lib/pkgconfig just like it removes /usr/lib/pkgconfig. This would have
> the benefit of also dropping the /lib/pkgconfig folder, which your
> change doesn't do.
>
> What do you think?
This would work too, but do we want to add things to target-finalize
just for (apparently) only one little package ?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-06 10:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 8:15 [Buildroot] [PATCH 1/1] package/bash: remove development files and modules on the target Nicolas Cavallari
2021-04-05 9:45 ` Thomas Petazzoni
2021-04-06 10:32 ` Nicolas Cavallari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.