Re: new patch

[Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>]

On ١٦‏/٣‏/٢٠٢٣ ٠٢:٢٤, Ira Weiny wrote:
> Menna Mahmoud wrote:
>> On ١٥‏/٣‏/٢٠٢٣ ٢٠:٣٧, Ira Weiny wrote:
>>> Menna Mahmoud wrote:
> [...]
>
>>>> Is it okay to work on this error reported by checkpatch script:
>>>>
>>>>
>>>> ```
>>>>
>>>> drivers/staging/iio/frequency/ad9832.c
>>>> --------------------------------------
>>>> ERROR: Use 4 digit octal (0777) not decimal permissions
>>> This error is trying to flag a mode permission which is not in Octal form.
>>> Are you familiar with decimal vs octal vs hex notations?
>>
>> yes, I am familiar with them.
> Awesome!
>
>>>> #256: FILE: drivers/staging/iio/frequency/ad9832.c:256:
>>>> +static IIO_DEV_ATTR_FREQ(0, 1, 0200, NULL, ad9832_write, AD9832_FREQ1HM);
>>> What do you think is wrong with this line?
>>>
>>> Hint: I'm not sure I see the problem.
>>>
>>> So your email should have had a subject which reflects this question.
>>> Perhaps a subject like:
>>>
>>> "Is this a valid checkpatch error?"
>>>
>>> FWIW I'm concerned this is some corner case checkpatch bug.  But I'm not
>>> seeing the issue in checkpatch (My perl is very rusty).
>>>
>>> Do you see the error checkpatch is flagging?  Or do you think this may be
>>> a bug in checkpatch?
>>>
>>> Ira
>>
>> I'mn't sure too, I sent this because I submit previous patches but I got
>> comments from mentors that no need to fix them so
>>
>> I asked if these errors need to fix or should I ignore them.
> I've just caught up with the other thread on this.
>
> https://lore.kernel.org/all/48571e97-8766-e67d-c263-29fd67a31f06@metafoo.de/
>
> Do follow up there.  I think we should stop posting on this thread.
>
> Do notice how your subject of 'Outreachy' and 'new patch' become
> meaningless for these 2 threads.
>
> I suspect you had some issue with the mail client and that is why you
> emailed this question 2 times?
>
> Anyway, I'm caught up.  :-D
> Ira

yes, you are right i had some issue but fixed, thanks a lot and 
appreciate your help.

Menna