Re: new patch

[Ira Weiny <ira.weiny@intel.com>]

Menna Mahmoud wrote:
> Hi Mentors,
> 

Hey Menna, welcome to Outreachy!

First I'll make a small comment on your email subject.  Remember that when
posting to a mailing list the folks getting the emails may be looking at
100's or even 1000's of emails on the list each day.

A subject of 'new patch' is pretty generic and is unlikely to result in
any interest in reading your post.

With that in mind lets look through the below errors.

> 
> Is it okay to work on this error reported by checkpatch script:
> 
> 
> ```
> 
> drivers/staging/iio/frequency/ad9832.c
> --------------------------------------
> ERROR: Use 4 digit octal (0777) not decimal permissions

This error is trying to flag a mode permission which is not in Octal form.
Are you familiar with decimal vs octal vs hex notations?

> #256: FILE: drivers/staging/iio/frequency/ad9832.c:256:
> +static IIO_DEV_ATTR_FREQ(0, 1, 0200, NULL, ad9832_write, AD9832_FREQ1HM);

What do you think is wrong with this line?

Hint: I'm not sure I see the problem.

So your email should have had a subject which reflects this question.
Perhaps a subject like:

"Is this a valid checkpatch error?"

FWIW I'm concerned this is some corner case checkpatch bug.  But I'm not
seeing the issue in checkpatch (My perl is very rusty).

Do you see the error checkpatch is flagging?  Or do you think this may be
a bug in checkpatch?

Ira