From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@fb.com>,
James Bottomley <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Mike Snitzer <snitzer@redhat.com>,
Doug Ledford <dledford@redhat.com>,
Keith Busch <keith.busch@intel.com>,
Ming Lin <ming.l@ssi.samsung.com>,
Laurence Oberman <loberman@redhat.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v3 02/11] blk-mq: Introduce blk_mq_hctx_stopped()
Date: Wed, 19 Oct 2016 08:58:55 -0700 [thread overview]
Message-ID: <4c09e48d-4b23-915a-bf60-c58d0aae6007@sandisk.com> (raw)
In-Reply-To: <20161019131900.GB6323@lst.de>
On 10/19/2016 06:19 AM, Christoph Hellwig wrote:
> On Tue, Oct 18, 2016 at 02:49:09PM -0700, Bart Van Assche wrote:
>> Multiple functions test the BLK_MQ_S_STOPPED bit so introduce
>> a helper function that performs this test.
>
> Looks sensible. Any reason to have it in the public blk-mq.h instead
> of the private one, though? I see that dm is using it with this patch,
> but that usage should go away once your full series is merged, right?
Hello Christoph,
Moving the blk_mq_hctx_stopped() declaration from the public to the
private blk-mq.h header file should be possible. I will look into this.
Bart.
WARNING: multiple messages have this Message-ID (diff)
From: bart.vanassche@sandisk.com (Bart Van Assche)
Subject: [PATCH v3 02/11] blk-mq: Introduce blk_mq_hctx_stopped()
Date: Wed, 19 Oct 2016 08:58:55 -0700 [thread overview]
Message-ID: <4c09e48d-4b23-915a-bf60-c58d0aae6007@sandisk.com> (raw)
In-Reply-To: <20161019131900.GB6323@lst.de>
On 10/19/2016 06:19 AM, Christoph Hellwig wrote:
> On Tue, Oct 18, 2016@02:49:09PM -0700, Bart Van Assche wrote:
>> Multiple functions test the BLK_MQ_S_STOPPED bit so introduce
>> a helper function that performs this test.
>
> Looks sensible. Any reason to have it in the public blk-mq.h instead
> of the private one, though? I see that dm is using it with this patch,
> but that usage should go away once your full series is merged, right?
Hello Christoph,
Moving the blk_mq_hctx_stopped() declaration from the public to the
private blk-mq.h header file should be possible. I will look into this.
Bart.
next prev parent reply other threads:[~2016-10-19 15:58 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 21:48 [PATCH v3 0/11] Fix race conditions related to stopping block layer queues Bart Van Assche
2016-10-18 21:48 ` Bart Van Assche
2016-10-18 21:48 ` [PATCH v3 01/11] blk-mq: Do not invoke .queue_rq() for a stopped queue Bart Van Assche
2016-10-18 21:48 ` Bart Van Assche
2016-10-19 13:17 ` Christoph Hellwig
2016-10-19 13:17 ` Christoph Hellwig
2016-10-19 13:17 ` Christoph Hellwig
2016-10-19 23:48 ` Ming Lei
2016-10-19 23:48 ` Ming Lei
2016-10-19 23:48 ` Ming Lei
2016-10-18 21:49 ` [PATCH v3 02/11] blk-mq: Introduce blk_mq_hctx_stopped() Bart Van Assche
2016-10-18 21:49 ` Bart Van Assche
2016-10-19 13:19 ` Christoph Hellwig
2016-10-19 13:19 ` Christoph Hellwig
2016-10-19 13:19 ` Christoph Hellwig
2016-10-19 15:58 ` Bart Van Assche [this message]
2016-10-19 15:58 ` Bart Van Assche
2016-10-18 21:49 ` [PATCH v3 03/11] blk-mq: Introduce blk_mq_queue_stopped() Bart Van Assche
2016-10-18 21:49 ` Bart Van Assche
2016-10-19 13:19 ` Christoph Hellwig
2016-10-19 13:19 ` Christoph Hellwig
2016-10-19 13:19 ` Christoph Hellwig
2016-10-18 21:50 ` [PATCH v3 04/11] blk-mq: Introduce blk_mq_quiesce_queue() Bart Van Assche
2016-10-18 21:50 ` Bart Van Assche
2016-10-19 13:23 ` Christoph Hellwig
2016-10-19 13:23 ` Christoph Hellwig
2016-10-19 13:23 ` Christoph Hellwig
2016-10-19 16:13 ` Bart Van Assche
2016-10-19 16:13 ` Bart Van Assche
2016-10-19 21:04 ` Bart Van Assche
2016-10-19 21:04 ` Bart Van Assche
2016-10-19 23:47 ` Ming Lei
2016-10-19 23:47 ` Ming Lei
2016-10-18 21:51 ` [PATCH v3 05/11] blk-mq: Add a kick_requeue_list argument to blk_mq_requeue_request() Bart Van Assche
2016-10-18 21:51 ` Bart Van Assche
2016-10-18 21:51 ` Bart Van Assche
2016-10-19 13:23 ` Christoph Hellwig
2016-10-19 13:23 ` Christoph Hellwig
2016-10-19 13:23 ` Christoph Hellwig
2016-10-18 21:51 ` [PATCH v3 06/11] dm: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code Bart Van Assche
2016-10-18 21:51 ` Bart Van Assche
2016-10-19 13:28 ` Christoph Hellwig
2016-10-19 13:28 ` Christoph Hellwig
2016-10-19 13:28 ` Christoph Hellwig
2016-10-18 21:52 ` [PATCH v3 07/11] dm: Fix a race condition related to stopping and starting queues Bart Van Assche
2016-10-18 21:52 ` Bart Van Assche
2016-10-19 13:30 ` Christoph Hellwig
2016-10-19 13:30 ` Christoph Hellwig
2016-10-19 13:30 ` Christoph Hellwig
2016-10-18 21:52 ` [PATCH v3 08/11] SRP transport: Move queuecommand() wait code to SCSI core Bart Van Assche
2016-10-18 21:52 ` Bart Van Assche
2016-10-19 13:38 ` Christoph Hellwig
2016-10-19 13:38 ` Christoph Hellwig
2016-10-19 13:38 ` Christoph Hellwig
2016-10-18 21:52 ` [PATCH v3 09/11] SRP transport, scsi-mq: Wait for .queue_rq() if necessary Bart Van Assche
2016-10-18 21:52 ` Bart Van Assche
2016-10-19 13:39 ` Christoph Hellwig
2016-10-19 13:39 ` Christoph Hellwig
2016-10-19 13:39 ` Christoph Hellwig
2016-10-18 21:53 ` [PATCH v3 10/11] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code Bart Van Assche
2016-10-18 21:53 ` Bart Van Assche
2016-10-19 13:39 ` Christoph Hellwig
2016-10-19 13:39 ` Christoph Hellwig
2016-10-19 13:39 ` Christoph Hellwig
2016-10-18 21:53 ` [PATCH v3 11/11] nvme: Fix a race condition Bart Van Assche
2016-10-18 21:53 ` Bart Van Assche
2016-10-19 13:41 ` Christoph Hellwig
2016-10-19 13:41 ` Christoph Hellwig
2016-10-19 13:41 ` Christoph Hellwig
2016-10-18 21:56 ` [PATCH v3 0/11] Fix race conditions related to stopping block layer queues Bart Van Assche
2016-10-18 21:56 ` Bart Van Assche
2016-10-18 21:56 ` Bart Van Assche
2016-10-19 22:24 ` Keith Busch
2016-10-19 22:24 ` Keith Busch
2016-10-19 23:51 ` Bart Van Assche
2016-10-19 23:51 ` Bart Van Assche
2016-10-20 14:52 ` Keith Busch
2016-10-20 14:52 ` Keith Busch
2016-10-20 15:35 ` Bart Van Assche
2016-10-20 15:35 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c09e48d-4b23-915a-bf60-c58d0aae6007@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@fb.com \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=ming.l@ssi.samsung.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.