[meta-python][PATCH] python(3)-requests: add DEPENDS_class-native

[meta-python][PATCH] python(3)-requests: add DEPENDS_class-native

[Peter Kolbus]

Change-Id: Ie8bd80d56da599b29430da65b303d69bba43fdda
---
 .../recipes-devtools/python/python-requests.inc        | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/meta-python/recipes-devtools/python/python-requests.inc b/meta-python/recipes-devtools/python/python-requests.inc
index 5fe5dc21f..ea2983821 100644
--- a/meta-python/recipes-devtools/python/python-requests.inc
+++ b/meta-python/recipes-devtools/python/python-requests.inc
@@ -23,6 +23,16 @@ RDEPENDS_${PN} += " \
     ${PYTHON_PN}-idna \
 "
 
+DEPENDS_class-native += " \
+    ${PYTHON_PN}-ndg-httpsclient-native \
+    ${PYTHON_PN}-pyasn1-native \
+    ${PYTHON_PN}-pyopenssl-native \
+    ${PYTHON_PN}-pysocks-native \
+    ${PYTHON_PN}-urllib3-native \
+    ${PYTHON_PN}-chardet-native \
+    ${PYTHON_PN}-idna-native \
+"
+
 CVE_PRODUCT = "requests"
 
 BBCLASSEXTEND = "native nativesdk"
-- 
2.24.1

I have a small handful of recipes that need similar treatment to ensure
the sysroot contains indirect dependencies. If there's a better
approach, please let me know -- my experience with OE and bitbake are
limited.

Re: [meta-python][PATCH] python(3)-requests: add DEPENDS_class-native

[Khem Raj]

Hi Peter

On 12/18/19 12:13 PM, Peter Kolbus wrote:
> Change-Id: Ie8bd80d56da599b29430da65b303d69bba43fdda

Is this gerrit tag useful for you once upstreamed ? I ask because in 
general this will be redundant information that I would prefer to not 
have in logs.

> ---
>   .../recipes-devtools/python/python-requests.inc        | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/meta-python/recipes-devtools/python/python-requests.inc b/meta-python/recipes-devtools/python/python-requests.inc
> index 5fe5dc21f..ea2983821 100644
> --- a/meta-python/recipes-devtools/python/python-requests.inc
> +++ b/meta-python/recipes-devtools/python/python-requests.inc
> @@ -23,6 +23,16 @@ RDEPENDS_${PN} += " \
>       ${PYTHON_PN}-idna \
>   "
>   
> +DEPENDS_class-native += " \
> +    ${PYTHON_PN}-ndg-httpsclient-native \
> +    ${PYTHON_PN}-pyasn1-native \
> +    ${PYTHON_PN}-pyopenssl-native \
> +    ${PYTHON_PN}-pysocks-native \
> +    ${PYTHON_PN}-urllib3-native \
> +    ${PYTHON_PN}-chardet-native \
> +    ${PYTHON_PN}-idna-native \
> +"
> +
>   CVE_PRODUCT = "requests"
>   
>   BBCLASSEXTEND = "native nativesdk"
> 

Re: [meta-python][PATCH] python(3)-requests: add DEPENDS_class-native

[Kolbus, Peter]

> -----Original Message-----
> From: Khem Raj <raj.khem@gmail.com>
> Sent: Wednesday, December 18, 2019 2:56 PM
> To: Kolbus, Peter <Peter.Kolbus@garmin.com>; openembedded-
> devel@lists.openembedded.org
> Subject: Re: [oe] [meta-python][PATCH] python(3)-requests: add
> DEPENDS_class-native
> 
> CAUTION - EXTERNAL EMAIL: Do not click any links or open any attachments
> unless you trust the sender and know the content is safe.
> 
> 
> Hi Peter
> 
> On 12/18/19 12:13 PM, Peter Kolbus wrote:
> > Change-Id: Ie8bd80d56da599b29430da65b303d69bba43fdda
> 
> Is this gerrit tag useful for you once upstreamed ? I ask because in general this
> will be redundant information that I would prefer to not have in logs.
> 

This tag isn't needed; you're welcome to remove from this and the other patches I sent (or, let me know if I need to submit v2 patches). I'll take care that it's not present in future patches.
 

> > ---
> >   .../recipes-devtools/python/python-requests.inc        | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> >
> > diff --git a/meta-python/recipes-devtools/python/python-requests.inc
> > b/meta-python/recipes-devtools/python/python-requests.inc
> > index 5fe5dc21f..ea2983821 100644
> > --- a/meta-python/recipes-devtools/python/python-requests.inc
> > +++ b/meta-python/recipes-devtools/python/python-requests.inc
> > @@ -23,6 +23,16 @@ RDEPENDS_${PN} += " \
> >       ${PYTHON_PN}-idna \
> >   "
> >
> > +DEPENDS_class-native += " \
> > +    ${PYTHON_PN}-ndg-httpsclient-native \
> > +    ${PYTHON_PN}-pyasn1-native \
> > +    ${PYTHON_PN}-pyopenssl-native \
> > +    ${PYTHON_PN}-pysocks-native \
> > +    ${PYTHON_PN}-urllib3-native \
> > +    ${PYTHON_PN}-chardet-native \
> > +    ${PYTHON_PN}-idna-native \
> > +"
> > +
> >   CVE_PRODUCT = "requests"
> >
> >   BBCLASSEXTEND = "native nativesdk"
> >

Re: [meta-python][PATCH] python(3)-requests: add DEPENDS_class-native

[Ross Burton]

On 18/12/2019 20:13, Peter Kolbus wrote:
> Change-Id: Ie8bd80d56da599b29430da65b303d69bba43fdda
> ---
>   .../recipes-devtools/python/python-requests.inc        | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/meta-python/recipes-devtools/python/python-requests.inc b/meta-python/recipes-devtools/python/python-requests.inc
> index 5fe5dc21f..ea2983821 100644
> --- a/meta-python/recipes-devtools/python/python-requests.inc
> +++ b/meta-python/recipes-devtools/python/python-requests.inc
> @@ -23,6 +23,16 @@ RDEPENDS_${PN} += " \
>       ${PYTHON_PN}-idna \
>   "
>   
> +DEPENDS_class-native += " \
> +    ${PYTHON_PN}-ndg-httpsclient-native \
> +    ${PYTHON_PN}-pyasn1-native \
> +    ${PYTHON_PN}-pyopenssl-native \
> +    ${PYTHON_PN}-pysocks-native \
> +    ${PYTHON_PN}-urllib3-native \
> +    ${PYTHON_PN}-chardet-native \
> +    ${PYTHON_PN}-idna-native \

Why would you ned to do this?

Ross

Re: [meta-python][PATCH] python(3)-requests: add DEPENDS_class-native

[Kolbus, Peter]

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> <openembedded-devel-bounces@lists.openembedded.org> On Behalf Of Ross
> Burton
> Sent: Thursday, December 19, 2019 5:26 AM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-python][PATCH] python(3)-requests: add
> DEPENDS_class-native
> 
> CAUTION - EXTERNAL EMAIL: Do not click any links or open any attachments
> unless you trust the sender and know the content is safe.
> 
> 
> On 18/12/2019 20:13, Peter Kolbus wrote:
> > Change-Id: Ie8bd80d56da599b29430da65b303d69bba43fdda
> > ---
> >   .../recipes-devtools/python/python-requests.inc        | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> >
> > diff --git a/meta-python/recipes-devtools/python/python-requests.inc b/meta-
> python/recipes-devtools/python/python-requests.inc
> > index 5fe5dc21f..ea2983821 100644
> > --- a/meta-python/recipes-devtools/python/python-requests.inc
> > +++ b/meta-python/recipes-devtools/python/python-requests.inc
> > @@ -23,6 +23,16 @@ RDEPENDS_${PN} += " \
> >       ${PYTHON_PN}-idna \
> >   "
> >
> > +DEPENDS_class-native += " \
> > +    ${PYTHON_PN}-ndg-httpsclient-native \
> > +    ${PYTHON_PN}-pyasn1-native \
> > +    ${PYTHON_PN}-pyopenssl-native \
> > +    ${PYTHON_PN}-pysocks-native \
> > +    ${PYTHON_PN}-urllib3-native \
> > +    ${PYTHON_PN}-chardet-native \
> > +    ${PYTHON_PN}-idna-native \
> 
> Why would you ned to do this? 

Thanks for the check. My objective here was to ensure all dependencies are in the sysroot, but after more careful retesting, I'm not seeing a need for this particular patch. From what I can tell, it looks like Richard Purdie actually addressed the root cause back in February, in native.bbclass.

(When first tested my patches on master, I dropped a similar patch for python(3)-beautifulsoup4, but that recipe actually has class-native issues of a slightly different root cause. And in doing so, confused myself about what is truly needed.)

Consider this patch withdrawn. I'll clean up the rest of my patches and send -- including a better change for beautifulsoup4.

> 
> Ross
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel