* [Ocfs2-devel] [PATCH 1/3] fs/ocfs2/namei.c: remove set but not used variables
[not found] ` <1566393326-25371-2-git-send-email-zhengbin13@huawei.com>
@ 2019-08-22 1:05 ` Joseph Qi
2019-08-22 6:00 ` Changwei Ge
0 siblings, 1 reply; 9+ messages in thread
From: Joseph Qi @ 2019-08-22 1:05 UTC (permalink / raw)
To: ocfs2-devel
On 19/8/21 21:15, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/ocfs2/namei.c: In function ocfs2_create_inode_in_orphan:
> fs/ocfs2/namei.c:2503:23: warning: variable di set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/namei.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 6f8e1c4..8ea51cf 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -2486,7 +2486,6 @@ int ocfs2_create_inode_in_orphan(struct inode *dir,
> struct inode *inode = NULL;
> struct inode *orphan_dir = NULL;
> struct ocfs2_super *osb = OCFS2_SB(dir->i_sb);
> - struct ocfs2_dinode *di = NULL;
> handle_t *handle = NULL;
> char orphan_name[OCFS2_ORPHAN_NAMELEN + 1];
> struct buffer_head *parent_di_bh = NULL;
> @@ -2552,7 +2551,6 @@ int ocfs2_create_inode_in_orphan(struct inode *dir,
> goto leave;
> }
>
> - di = (struct ocfs2_dinode *)new_di_bh->b_data;
> status = ocfs2_orphan_add(osb, handle, inode, new_di_bh, orphan_name,
> &orphan_insert, orphan_dir, false);
> if (status < 0) {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Ocfs2-devel] [PATCH 2/3] fs/ocfs2/file.c: remove set but not used variables
[not found] ` <1566393326-25371-3-git-send-email-zhengbin13@huawei.com>
@ 2019-08-22 1:07 ` Joseph Qi
2019-08-22 6:00 ` Changwei Ge
0 siblings, 1 reply; 9+ messages in thread
From: Joseph Qi @ 2019-08-22 1:07 UTC (permalink / raw)
To: ocfs2-devel
On 19/8/21 21:15, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/ocfs2/file.c: In function ocfs2_prepare_inode_for_write:
> fs/ocfs2/file.c:2143:9: warning: variable end set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/file.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index 4435df3..aeb3362 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -2126,7 +2126,6 @@ static int ocfs2_prepare_inode_for_write(struct file *file,
> struct dentry *dentry = file->f_path.dentry;
> struct inode *inode = d_inode(dentry);
> struct buffer_head *di_bh = NULL;
> - loff_t end;
>
> /*
> * We start with a read level meta lock and only jump to an ex
> @@ -2190,8 +2189,6 @@ static int ocfs2_prepare_inode_for_write(struct file *file,
> }
> }
>
> - end = pos + count;
> -
> ret = ocfs2_check_range_for_refcount(inode, pos, count);
> if (ret == 1) {
> ocfs2_inode_unlock(inode, meta_level);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Ocfs2-devel] [PATCH 3/3] fs/ocfs2/dir.c: remove set but not used variables
[not found] ` <1566393326-25371-4-git-send-email-zhengbin13@huawei.com>
@ 2019-08-22 1:07 ` Joseph Qi
2019-08-22 6:01 ` Changwei Ge
0 siblings, 1 reply; 9+ messages in thread
From: Joseph Qi @ 2019-08-22 1:07 UTC (permalink / raw)
To: ocfs2-devel
On 19/8/21 21:15, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/ocfs2/dir.c: In function ocfs2_dx_dir_transfer_leaf:
> fs/ocfs2/dir.c:3653:42: warning: variable new_list set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/dir.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
> index 784426d..bdef72c 100644
> --- a/fs/ocfs2/dir.c
> +++ b/fs/ocfs2/dir.c
> @@ -3636,7 +3636,7 @@ static void ocfs2_dx_dir_transfer_leaf(struct inode *dir, u32 split_hash,
> int i, j, num_used;
> u32 major_hash;
> struct ocfs2_dx_leaf *orig_dx_leaf, *new_dx_leaf;
> - struct ocfs2_dx_entry_list *orig_list, *new_list, *tmp_list;
> + struct ocfs2_dx_entry_list *orig_list, *tmp_list;
> struct ocfs2_dx_entry *dx_entry;
>
> tmp_list = &tmp_dx_leaf->dl_list;
> @@ -3645,7 +3645,6 @@ static void ocfs2_dx_dir_transfer_leaf(struct inode *dir, u32 split_hash,
> orig_dx_leaf = (struct ocfs2_dx_leaf *) orig_dx_leaves[i]->b_data;
> orig_list = &orig_dx_leaf->dl_list;
> new_dx_leaf = (struct ocfs2_dx_leaf *) new_dx_leaves[i]->b_data;
> - new_list = &new_dx_leaf->dl_list;
>
> num_used = le16_to_cpu(orig_list->de_num_used);
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Ocfs2-devel] [PATCH 1/3] fs/ocfs2/namei.c: remove set but not used variables
2019-08-22 1:05 ` [Ocfs2-devel] [PATCH 1/3] fs/ocfs2/namei.c: remove set but not used variables Joseph Qi
@ 2019-08-22 6:00 ` Changwei Ge
0 siblings, 0 replies; 9+ messages in thread
From: Changwei Ge @ 2019-08-22 6:00 UTC (permalink / raw)
To: ocfs2-devel
On 2019/8/22 9:05 ??, Joseph Qi wrote:
>
> On 19/8/21 21:15, zhengbin wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> fs/ocfs2/namei.c: In function ocfs2_create_inode_in_orphan:
>> fs/ocfs2/namei.c:2503:23: warning: variable di set but not used [-Wunused-but-set-variable]
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Reviewed-by: Changwei Ge <chge@linux.alibaba.com>
>> ---
>> fs/ocfs2/namei.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
>> index 6f8e1c4..8ea51cf 100644
>> --- a/fs/ocfs2/namei.c
>> +++ b/fs/ocfs2/namei.c
>> @@ -2486,7 +2486,6 @@ int ocfs2_create_inode_in_orphan(struct inode *dir,
>> struct inode *inode = NULL;
>> struct inode *orphan_dir = NULL;
>> struct ocfs2_super *osb = OCFS2_SB(dir->i_sb);
>> - struct ocfs2_dinode *di = NULL;
>> handle_t *handle = NULL;
>> char orphan_name[OCFS2_ORPHAN_NAMELEN + 1];
>> struct buffer_head *parent_di_bh = NULL;
>> @@ -2552,7 +2551,6 @@ int ocfs2_create_inode_in_orphan(struct inode *dir,
>> goto leave;
>> }
>>
>> - di = (struct ocfs2_dinode *)new_di_bh->b_data;
>> status = ocfs2_orphan_add(osb, handle, inode, new_di_bh, orphan_name,
>> &orphan_insert, orphan_dir, false);
>> if (status < 0) {
>> --
>> 2.7.4
>>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Ocfs2-devel] [PATCH 2/3] fs/ocfs2/file.c: remove set but not used variables
2019-08-22 1:07 ` [Ocfs2-devel] [PATCH 2/3] fs/ocfs2/file.c: " Joseph Qi
@ 2019-08-22 6:00 ` Changwei Ge
0 siblings, 0 replies; 9+ messages in thread
From: Changwei Ge @ 2019-08-22 6:00 UTC (permalink / raw)
To: ocfs2-devel
On 2019/8/22 9:07 ??, Joseph Qi wrote:
>
> On 19/8/21 21:15, zhengbin wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> fs/ocfs2/file.c: In function ocfs2_prepare_inode_for_write:
>> fs/ocfs2/file.c:2143:9: warning: variable end set but not used [-Wunused-but-set-variable]
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Reviewed-by: Changwei Ge <chge@linux.alibaba.com>
>> ---
>> fs/ocfs2/file.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
>> index 4435df3..aeb3362 100644
>> --- a/fs/ocfs2/file.c
>> +++ b/fs/ocfs2/file.c
>> @@ -2126,7 +2126,6 @@ static int ocfs2_prepare_inode_for_write(struct file *file,
>> struct dentry *dentry = file->f_path.dentry;
>> struct inode *inode = d_inode(dentry);
>> struct buffer_head *di_bh = NULL;
>> - loff_t end;
>>
>> /*
>> * We start with a read level meta lock and only jump to an ex
>> @@ -2190,8 +2189,6 @@ static int ocfs2_prepare_inode_for_write(struct file *file,
>> }
>> }
>>
>> - end = pos + count;
>> -
>> ret = ocfs2_check_range_for_refcount(inode, pos, count);
>> if (ret == 1) {
>> ocfs2_inode_unlock(inode, meta_level);
>> --
>> 2.7.4
>>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Ocfs2-devel] [PATCH 3/3] fs/ocfs2/dir.c: remove set but not used variables
2019-08-22 1:07 ` [Ocfs2-devel] [PATCH 3/3] fs/ocfs2/dir.c: " Joseph Qi
@ 2019-08-22 6:01 ` Changwei Ge
2019-08-22 22:47 ` Andrew Morton
0 siblings, 1 reply; 9+ messages in thread
From: Changwei Ge @ 2019-08-22 6:01 UTC (permalink / raw)
To: ocfs2-devel
On 2019/8/22 9:07 ??, Joseph Qi wrote:
>
> On 19/8/21 21:15, zhengbin wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> fs/ocfs2/dir.c: In function ocfs2_dx_dir_transfer_leaf:
>> fs/ocfs2/dir.c:3653:42: warning: variable new_list set but not used [-Wunused-but-set-variable]
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Reviewed-by: Changwei Ge <chge@linux.alibaba.com>
>> ---
>> fs/ocfs2/dir.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
>> index 784426d..bdef72c 100644
>> --- a/fs/ocfs2/dir.c
>> +++ b/fs/ocfs2/dir.c
>> @@ -3636,7 +3636,7 @@ static void ocfs2_dx_dir_transfer_leaf(struct inode *dir, u32 split_hash,
>> int i, j, num_used;
>> u32 major_hash;
>> struct ocfs2_dx_leaf *orig_dx_leaf, *new_dx_leaf;
>> - struct ocfs2_dx_entry_list *orig_list, *new_list, *tmp_list;
>> + struct ocfs2_dx_entry_list *orig_list, *tmp_list;
>> struct ocfs2_dx_entry *dx_entry;
>>
>> tmp_list = &tmp_dx_leaf->dl_list;
>> @@ -3645,7 +3645,6 @@ static void ocfs2_dx_dir_transfer_leaf(struct inode *dir, u32 split_hash,
>> orig_dx_leaf = (struct ocfs2_dx_leaf *) orig_dx_leaves[i]->b_data;
>> orig_list = &orig_dx_leaf->dl_list;
>> new_dx_leaf = (struct ocfs2_dx_leaf *) new_dx_leaves[i]->b_data;
>> - new_list = &new_dx_leaf->dl_list;
>>
>> num_used = le16_to_cpu(orig_list->de_num_used);
>>
>> --
>> 2.7.4
>>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Ocfs2-devel] [PATCH 3/3] fs/ocfs2/dir.c: remove set but not used variables
2019-08-22 6:01 ` Changwei Ge
@ 2019-08-22 22:47 ` Andrew Morton
2019-08-23 1:02 ` Joseph Qi
0 siblings, 1 reply; 9+ messages in thread
From: Andrew Morton @ 2019-08-22 22:47 UTC (permalink / raw)
To: ocfs2-devel
The ocfs2 mailing list drives me nuts :(
For unknown reasons I failed to receive any of these patches. Could I
please have a resend, with me on cc? Thanks.
Before doing so, please update the changelogs to reflcet the
thus-far-received acks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Ocfs2-devel] [PATCH 3/3] fs/ocfs2/dir.c: remove set but not used variables
2019-08-22 22:47 ` Andrew Morton
@ 2019-08-23 1:02 ` Joseph Qi
0 siblings, 0 replies; 9+ messages in thread
From: Joseph Qi @ 2019-08-23 1:02 UTC (permalink / raw)
To: ocfs2-devel
On 19/8/23 06:47, Andrew Morton wrote:
> The ocfs2 mailing list drives me nuts :(
>
> For unknown reasons I failed to receive any of these patches. Could I
> please have a resend, with me on cc? Thanks.
>
> Before doing so, please update the changelogs to reflcet the
> thus-far-received acks.
>
Sure, I'll resend the 3 patches.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Ocfs2-devel] [PATCH 2/3] fs/ocfs2/file.c: remove set but not used variables
2019-08-23 1:09 [Ocfs2-devel] [PATCH 0/3 RESEND] fs/ocfs2: " Joseph Qi
@ 2019-08-23 1:09 ` Joseph Qi
0 siblings, 0 replies; 9+ messages in thread
From: Joseph Qi @ 2019-08-23 1:09 UTC (permalink / raw)
To: ocfs2-devel
From: zhengbin <zhengbin13@huawei.com>
Fixes gcc '-Wunused-but-set-variable' warning:
fs/ocfs2/file.c: In function ocfs2_prepare_inode_for_write:
fs/ocfs2/file.c:2143:9: warning: variable end set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Reviewed-by: Changwei Ge <chge@linux.alibaba.com>
---
fs/ocfs2/file.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index efe9988..2e982db 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -2130,7 +2130,6 @@ static int ocfs2_prepare_inode_for_write(struct file *file,
struct dentry *dentry = file->f_path.dentry;
struct inode *inode = d_inode(dentry);
struct buffer_head *di_bh = NULL;
- loff_t end;
/*
* We start with a read level meta lock and only jump to an ex
@@ -2194,8 +2193,6 @@ static int ocfs2_prepare_inode_for_write(struct file *file,
}
}
- end = pos + count;
-
ret = ocfs2_check_range_for_refcount(inode, pos, count);
if (ret == 1) {
ocfs2_inode_unlock(inode, meta_level);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-08-23 1:09 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1566393326-25371-1-git-send-email-zhengbin13@huawei.com>
[not found] ` <1566393326-25371-2-git-send-email-zhengbin13@huawei.com>
2019-08-22 1:05 ` [Ocfs2-devel] [PATCH 1/3] fs/ocfs2/namei.c: remove set but not used variables Joseph Qi
2019-08-22 6:00 ` Changwei Ge
[not found] ` <1566393326-25371-3-git-send-email-zhengbin13@huawei.com>
2019-08-22 1:07 ` [Ocfs2-devel] [PATCH 2/3] fs/ocfs2/file.c: " Joseph Qi
2019-08-22 6:00 ` Changwei Ge
[not found] ` <1566393326-25371-4-git-send-email-zhengbin13@huawei.com>
2019-08-22 1:07 ` [Ocfs2-devel] [PATCH 3/3] fs/ocfs2/dir.c: " Joseph Qi
2019-08-22 6:01 ` Changwei Ge
2019-08-22 22:47 ` Andrew Morton
2019-08-23 1:02 ` Joseph Qi
2019-08-23 1:09 [Ocfs2-devel] [PATCH 0/3 RESEND] fs/ocfs2: " Joseph Qi
2019-08-23 1:09 ` [Ocfs2-devel] [PATCH 2/3] fs/ocfs2/file.c: " Joseph Qi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.