RE: [PATCHv2 1/1] RDMA/irdma: Make irdma_create_mg_ctx return a void

RE: [PATCHv2 1/1] RDMA/irdma: Make irdma_create_mg_ctx return a void

[Saleem, Shiraz]

> Subject: [PATCHv2 1/1] RDMA/irdma: Make irdma_create_mg_ctx return a void
> 
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> The function irdma_create_mg_ctx always returns 0, so make it void and delete the
> return value check.
> 
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> V1->V2: Remove the unused ret_code and rebase to the commit 2322d17abf0a
>         ("RDMA/irdma: Remove excess error variables")
> ---
>  drivers/infiniband/hw/irdma/uda.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 

Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>

[PATCHv2 1/1] RDMA/irdma: Make irdma_create_mg_ctx return a void

[yanjun.zhu]

From: Zhu Yanjun <yanjun.zhu@linux.dev>

The function irdma_create_mg_ctx always returns 0,
so make it void and delete the return value check.

Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
V1->V2: Remove the unused ret_code and rebase to the commit 2322d17abf0a
        ("RDMA/irdma: Remove excess error variables")
---
 drivers/infiniband/hw/irdma/uda.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/infiniband/hw/irdma/uda.c b/drivers/infiniband/hw/irdma/uda.c
index 7a9988ddbd01..a247ae3142d9 100644
--- a/drivers/infiniband/hw/irdma/uda.c
+++ b/drivers/infiniband/hw/irdma/uda.c
@@ -86,8 +86,7 @@ enum irdma_status_code irdma_sc_access_ah(struct irdma_sc_cqp *cqp,
  * irdma_create_mg_ctx() - create a mcg context
  * @info: multicast group context info
  */
-static enum irdma_status_code
-irdma_create_mg_ctx(struct irdma_mcast_grp_info *info)
+static void irdma_create_mg_ctx(struct irdma_mcast_grp_info *info)
 {
 	struct irdma_mcast_grp_ctx_entry_info *entry_info = NULL;
 	u8 idx = 0; /* index in the array */
@@ -106,8 +105,6 @@ irdma_create_mg_ctx(struct irdma_mcast_grp_info *info)
 			ctx_idx++;
 		}
 	}
-
-	return 0;
 }
 
 /**
@@ -122,7 +119,6 @@ enum irdma_status_code irdma_access_mcast_grp(struct irdma_sc_cqp *cqp,
 					      u32 op, u64 scratch)
 {
 	__le64 *wqe;
-	enum irdma_status_code ret_code = 0;
 
 	if (info->mg_id >= IRDMA_UDA_MAX_FSI_MGS) {
 		ibdev_dbg(to_ibdev(cqp->dev), "WQE: mg_id out of range\n");
@@ -135,9 +131,7 @@ enum irdma_status_code irdma_access_mcast_grp(struct irdma_sc_cqp *cqp,
 		return IRDMA_ERR_RING_FULL;
 	}
 
-	ret_code = irdma_create_mg_ctx(info);
-	if (ret_code)
-		return ret_code;
+	irdma_create_mg_ctx(info);
 
 	set_64bit_val(wqe, 32, info->dma_mem_mc.pa);
 	set_64bit_val(wqe, 16,
-- 
2.27.0

Re: [PATCHv2 1/1] RDMA/irdma: Make irdma_create_mg_ctx return a void

[Jason Gunthorpe]

On Thu, Feb 24, 2022 at 01:28:32PM -0500, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> The function irdma_create_mg_ctx always returns 0,
> so make it void and delete the return value check.
> 
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> V1->V2: Remove the unused ret_code and rebase to the commit 2322d17abf0a
>         ("RDMA/irdma: Remove excess error variables")
> ---
>  drivers/infiniband/hw/irdma/uda.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

Applied to for-next, thanks

Jason