* [PATCH 0/3] staging: iio: Remove useless type conversion
@ 2017-03-31 15:08 simran singhal
2017-03-31 15:08 ` [PATCH 1/3] staging: iio: accel: " simran singhal
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: simran singhal @ 2017-03-31 15:08 UTC (permalink / raw)
To: jic23; +Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, devel, linux-kernel
This patch-series removes some type conversions like casting a pointer to a pointer of same type,
casting to the original type using addressof(&) operator etc.
simran singhal (3):
staging: iio: accel: Remove useless type conversion
staging: iio: frequency: Remove useless type conversion
staging: iio: light: Remove useless type conversion
drivers/staging/iio/accel/adis16201.c | 2 +-
drivers/staging/iio/accel/adis16203.c | 2 +-
drivers/staging/iio/accel/adis16209.c | 2 +-
drivers/staging/iio/accel/adis16240.c | 6 +++---
drivers/staging/iio/frequency/ad9832.c | 2 +-
drivers/staging/iio/light/tsl2x7x_core.c | 2 +-
6 files changed, 8 insertions(+), 8 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/3] staging: iio: accel: Remove useless type conversion 2017-03-31 15:08 [PATCH 0/3] staging: iio: Remove useless type conversion simran singhal @ 2017-03-31 15:08 ` simran singhal 2017-04-02 8:38 ` Jonathan Cameron 2017-03-31 15:08 ` [PATCH 2/3] staging: iio: frequency: " simran singhal 2017-03-31 15:08 ` [PATCH 3/3] staging: iio: light: " simran singhal 2 siblings, 1 reply; 7+ messages in thread From: simran singhal @ 2017-03-31 15:08 UTC (permalink / raw) To: jic23; +Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, devel, linux-kernel Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by: simran singhal <singhalsimran0@gmail.com> --- drivers/staging/iio/accel/adis16201.c | 2 +- drivers/staging/iio/accel/adis16203.c | 2 +- drivers/staging/iio/accel/adis16209.c | 2 +- drivers/staging/iio/accel/adis16240.c | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c index fbc2406..b7381d3 100644 --- a/drivers/staging/iio/accel/adis16201.c +++ b/drivers/staging/iio/accel/adis16201.c @@ -228,7 +228,7 @@ static int adis16201_read_raw(struct iio_dev *indio_dev, if (ret) return ret; val16 &= (1 << bits) - 1; - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); + val16 = val16 << (16 - bits) >> (16 - bits); *val = val16; return IIO_VAL_INT; } diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c index b59755a..25e5e52 100644 --- a/drivers/staging/iio/accel/adis16203.c +++ b/drivers/staging/iio/accel/adis16203.c @@ -211,7 +211,7 @@ static int adis16203_read_raw(struct iio_dev *indio_dev, return ret; } val16 &= (1 << bits) - 1; - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); + val16 = val16 << (16 - bits) >> (16 - bits); *val = val16; mutex_unlock(&indio_dev->mlock); return IIO_VAL_INT; diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c index 52fa2e0..7aac310 100644 --- a/drivers/staging/iio/accel/adis16209.c +++ b/drivers/staging/iio/accel/adis16209.c @@ -259,7 +259,7 @@ static int adis16209_read_raw(struct iio_dev *indio_dev, return ret; } val16 &= (1 << bits) - 1; - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); + val16 = val16 << (16 - bits) >> (16 - bits); *val = val16; return IIO_VAL_INT; } diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c index 6e3c95c..2c55b65 100644 --- a/drivers/staging/iio/accel/adis16240.c +++ b/drivers/staging/iio/accel/adis16240.c @@ -220,7 +220,7 @@ static ssize_t adis16240_spi_read_signed(struct device *dev, if (val & ADIS16240_ERROR_ACTIVE) adis_check_status(st); - val = (s16)(val << shift) >> shift; + val = val << shift >> shift; return sprintf(buf, "%d\n", val); } @@ -294,7 +294,7 @@ static int adis16240_read_raw(struct iio_dev *indio_dev, return ret; } val16 &= (1 << bits) - 1; - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); + val16 = val16 << (16 - bits) >> (16 - bits); *val = val16; return IIO_VAL_INT; case IIO_CHAN_INFO_PEAK: @@ -305,7 +305,7 @@ static int adis16240_read_raw(struct iio_dev *indio_dev, return ret; } val16 &= (1 << bits) - 1; - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); + val16 = val16 << (16 - bits) >> (16 - bits); *val = val16; return IIO_VAL_INT; } -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] staging: iio: accel: Remove useless type conversion 2017-03-31 15:08 ` [PATCH 1/3] staging: iio: accel: " simran singhal @ 2017-04-02 8:38 ` Jonathan Cameron 0 siblings, 0 replies; 7+ messages in thread From: Jonathan Cameron @ 2017-04-02 8:38 UTC (permalink / raw) To: simran singhal Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, devel, linux-kernel On 31/03/17 16:08, simran singhal wrote: > Some type conversions like casting a pointer to a pointer of same type, > casting to the original type using addressof(&) operator etc. are not > needed. Therefore, remove them. Done using coccinelle: Please write a more specific commit message. No where in here for example is that particular case relevant as we aren't ever looking at pointers. More stuff below. There's a better way of improving this code! > > @@ > type t; > t *p; > t a; > @@ > ( > - (t)(a) > + a > | > - (t *)(p) > + p > | > - (t *)(&a) > + &a > ) > > Signed-off-by: simran singhal <singhalsimran0@gmail.com> > --- > drivers/staging/iio/accel/adis16201.c | 2 +- > drivers/staging/iio/accel/adis16203.c | 2 +- > drivers/staging/iio/accel/adis16209.c | 2 +- > drivers/staging/iio/accel/adis16240.c | 6 +++--- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c > index fbc2406..b7381d3 100644 > --- a/drivers/staging/iio/accel/adis16201.c > +++ b/drivers/staging/iio/accel/adis16201.c > @@ -228,7 +228,7 @@ static int adis16201_read_raw(struct iio_dev *indio_dev, > if (ret) > return ret; > val16 &= (1 << bits) - 1; > - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); > + val16 = val16 << (16 - bits) >> (16 - bits); hmm. bits is integer and val16 an s16 *looks up type promotion rules* Hohum. I hope someone else will check I get this right. Both instances of 16-bits will be signed integers. val16 will get promoted to a signed integer as well. Had it been a u16 value this would all have been necessary to ensure that the final right shift was pulling in ones. So all in all this looks like the cast is probably there to suppress a warning if the compiler isn't clever enough to figure out it will never truncate unecessarily. However, the fun thing about this is to take a look at what it is actually doing. It's doing sign extension to an s16, then just below assigns it to an int. So how could you do that better? search for sign_extend32 and see what you can do with it. It's actually a more recent introduction to the kernel than this driver (IIRC) so not surprising it isn't already being used here. > *val = val16; > return IIO_VAL_INT; > } > diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c > index b59755a..25e5e52 100644 > --- a/drivers/staging/iio/accel/adis16203.c > +++ b/drivers/staging/iio/accel/adis16203.c > @@ -211,7 +211,7 @@ static int adis16203_read_raw(struct iio_dev *indio_dev, > return ret; > } > val16 &= (1 << bits) - 1; > - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); > + val16 = val16 << (16 - bits) >> (16 - bits); > *val = val16; > mutex_unlock(&indio_dev->mlock); > return IIO_VAL_INT; > diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c > index 52fa2e0..7aac310 100644 > --- a/drivers/staging/iio/accel/adis16209.c > +++ b/drivers/staging/iio/accel/adis16209.c > @@ -259,7 +259,7 @@ static int adis16209_read_raw(struct iio_dev *indio_dev, > return ret; > } > val16 &= (1 << bits) - 1; > - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); > + val16 = val16 << (16 - bits) >> (16 - bits); > *val = val16; > return IIO_VAL_INT; > } > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c > index 6e3c95c..2c55b65 100644 > --- a/drivers/staging/iio/accel/adis16240.c > +++ b/drivers/staging/iio/accel/adis16240.c > @@ -220,7 +220,7 @@ static ssize_t adis16240_spi_read_signed(struct device *dev, > if (val & ADIS16240_ERROR_ACTIVE) > adis_check_status(st); > > - val = (s16)(val << shift) >> shift; > + val = val << shift >> shift; > return sprintf(buf, "%d\n", val); > } > > @@ -294,7 +294,7 @@ static int adis16240_read_raw(struct iio_dev *indio_dev, > return ret; > } > val16 &= (1 << bits) - 1; > - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); > + val16 = val16 << (16 - bits) >> (16 - bits); > *val = val16; > return IIO_VAL_INT; > case IIO_CHAN_INFO_PEAK: > @@ -305,7 +305,7 @@ static int adis16240_read_raw(struct iio_dev *indio_dev, > return ret; > } > val16 &= (1 << bits) - 1; > - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); > + val16 = val16 << (16 - bits) >> (16 - bits); > *val = val16; > return IIO_VAL_INT; > } > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] staging: iio: frequency: Remove useless type conversion 2017-03-31 15:08 [PATCH 0/3] staging: iio: Remove useless type conversion simran singhal 2017-03-31 15:08 ` [PATCH 1/3] staging: iio: accel: " simran singhal @ 2017-03-31 15:08 ` simran singhal 2017-04-02 8:44 ` Jonathan Cameron 2017-03-31 15:08 ` [PATCH 3/3] staging: iio: light: " simran singhal 2 siblings, 1 reply; 7+ messages in thread From: simran singhal @ 2017-03-31 15:08 UTC (permalink / raw) To: jic23; +Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, devel, linux-kernel Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by: simran singhal <singhalsimran0@gmail.com> --- drivers/staging/iio/frequency/ad9832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c index 425b8ab..01bdf8e 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -119,7 +119,7 @@ struct ad9832_state { static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) { unsigned long long freqreg = (u64)fout * - (u64)((u64)1L << AD9832_FREQ_BITS); + (u64)1L << AD9832_FREQ_BITS; do_div(freqreg, mclk); return freqreg; } -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] staging: iio: frequency: Remove useless type conversion 2017-03-31 15:08 ` [PATCH 2/3] staging: iio: frequency: " simran singhal @ 2017-04-02 8:44 ` Jonathan Cameron 0 siblings, 0 replies; 7+ messages in thread From: Jonathan Cameron @ 2017-04-02 8:44 UTC (permalink / raw) To: simran singhal Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, devel, linux-kernel On 31/03/17 16:08, simran singhal wrote: > Some type conversions like casting a pointer to a pointer of same type, > casting to the original type using addressof(&) operator etc. are not > needed. Therefore, remove them. Done using coccinelle: > > @@ > type t; > t *p; > t a; > @@ > ( > - (t)(a) > + a > | > - (t *)(p) > + p > | > - (t *)(&a) > + &a > ) > > Signed-off-by: simran singhal <singhalsimran0@gmail.com> driver name in title please, plus a patch description rather more tailored to the patch. > --- > drivers/staging/iio/frequency/ad9832.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c > index 425b8ab..01bdf8e 100644 > --- a/drivers/staging/iio/frequency/ad9832.c > +++ b/drivers/staging/iio/frequency/ad9832.c > @@ -119,7 +119,7 @@ struct ad9832_state { > static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) > { > unsigned long long freqreg = (u64)fout * > - (u64)((u64)1L << AD9832_FREQ_BITS); > + (u64)1L << AD9832_FREQ_BITS; > do_div(freqreg, mclk); > return freqreg; > } > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] staging: iio: light: Remove useless type conversion 2017-03-31 15:08 [PATCH 0/3] staging: iio: Remove useless type conversion simran singhal 2017-03-31 15:08 ` [PATCH 1/3] staging: iio: accel: " simran singhal 2017-03-31 15:08 ` [PATCH 2/3] staging: iio: frequency: " simran singhal @ 2017-03-31 15:08 ` simran singhal 2017-04-02 8:41 ` Jonathan Cameron 2 siblings, 1 reply; 7+ messages in thread From: simran singhal @ 2017-03-31 15:08 UTC (permalink / raw) To: jic23; +Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, devel, linux-kernel Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by: simran singhal <singhalsimran0@gmail.com> --- drivers/staging/iio/light/tsl2x7x_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c index ea15bc1..0490c1d 100644 --- a/drivers/staging/iio/light/tsl2x7x_core.c +++ b/drivers/staging/iio/light/tsl2x7x_core.c @@ -624,7 +624,7 @@ static int tsl2x7x_als_calibrate(struct iio_dev *indio_dev) dev_info(&chip->client->dev, "%s als_calibrate completed\n", chip->client->name); - return (int)gain_trim_val; + return gain_trim_val; } static int tsl2x7x_chip_on(struct iio_dev *indio_dev) -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] staging: iio: light: Remove useless type conversion 2017-03-31 15:08 ` [PATCH 3/3] staging: iio: light: " simran singhal @ 2017-04-02 8:41 ` Jonathan Cameron 0 siblings, 0 replies; 7+ messages in thread From: Jonathan Cameron @ 2017-04-02 8:41 UTC (permalink / raw) To: simran singhal Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, devel, linux-kernel On 31/03/17 16:08, simran singhal wrote: > Some type conversions like casting a pointer to a pointer of same type, > casting to the original type using addressof(&) operator etc. are not > needed. Therefore, remove them. Done using coccinelle: > > @@ > type t; > t *p; > t a; > @@ > ( > - (t)(a) > + a > | > - (t *)(p) > + p > | > - (t *)(&a) > + &a > ) > Description is largely irrelevant. Please tailor it to the patch. Also if only effecting one driver, the title should include the name of the driver. > Signed-off-by: simran singhal <singhalsimran0@gmail.com> > --- > drivers/staging/iio/light/tsl2x7x_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c > index ea15bc1..0490c1d 100644 > --- a/drivers/staging/iio/light/tsl2x7x_core.c > +++ b/drivers/staging/iio/light/tsl2x7x_core.c > @@ -624,7 +624,7 @@ static int tsl2x7x_als_calibrate(struct iio_dev *indio_dev) > dev_info(&chip->client->dev, > "%s als_calibrate completed\n", chip->client->name); > > - return (int)gain_trim_val; > + return gain_trim_val; > } > > static int tsl2x7x_chip_on(struct iio_dev *indio_dev) > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-02 8:44 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-03-31 15:08 [PATCH 0/3] staging: iio: Remove useless type conversion simran singhal 2017-03-31 15:08 ` [PATCH 1/3] staging: iio: accel: " simran singhal 2017-04-02 8:38 ` Jonathan Cameron 2017-03-31 15:08 ` [PATCH 2/3] staging: iio: frequency: " simran singhal 2017-04-02 8:44 ` Jonathan Cameron 2017-03-31 15:08 ` [PATCH 3/3] staging: iio: light: " simran singhal 2017-04-02 8:41 ` Jonathan Cameron
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.