All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gitlab-ci: Always upload artifacts by default
@ 2021-12-29 23:33 Philippe Mathieu-Daudé
  2021-12-30 15:51 ` Philippe Mathieu-Daudé
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-12-29 23:33 UTC (permalink / raw)
  To: qemu-devel
  Cc: Thomas Huth, Beraldo Leal, Alex Bennée, Richard Henderson,
	Philippe Mathieu-Daudé,
	Wainer dos Santos Moschetta, Philippe Mathieu-Daudé

GitLab defaults [1] to upload artifacts only when the job succeeds,
which is not helpful to troubleshoot failing tests. Switch to
always upload artifacts by default for QEMU jobs, by setting the
'artifacts:when' keyword in the global default section [2].

[1] https://docs.gitlab.com/ee/ci/yaml/index.html#artifactswhen
[2] https://docs.gitlab.com/ee/ci/yaml/index.html#default

Reported-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 .gitlab-ci.d/qemu-project.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.gitlab-ci.d/qemu-project.yml b/.gitlab-ci.d/qemu-project.yml
index 871262fe0e8..24137c14dc4 100644
--- a/.gitlab-ci.d/qemu-project.yml
+++ b/.gitlab-ci.d/qemu-project.yml
@@ -1,6 +1,10 @@
 # This file contains the set of jobs run by the QEMU project:
 # https://gitlab.com/qemu-project/qemu/-/pipelines
 
+default:
+  artifacts:
+    when: always
+
 include:
   - local: '/.gitlab-ci.d/stages.yml'
   - local: '/.gitlab-ci.d/edk2.yml'
-- 
2.33.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gitlab-ci: Always upload artifacts by default
  2021-12-29 23:33 [PATCH] gitlab-ci: Always upload artifacts by default Philippe Mathieu-Daudé
@ 2021-12-30 15:51 ` Philippe Mathieu-Daudé
  0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-12-30 15:51 UTC (permalink / raw)
  To: qemu-devel
  Cc: Richard Henderson, Thomas Huth, Alex Bennée, Beraldo Leal,
	Wainer dos Santos Moschetta

On 12/30/21 00:33, Philippe Mathieu-Daudé wrote:
> GitLab defaults [1] to upload artifacts only when the job succeeds,
> which is not helpful to troubleshoot failing tests. Switch to
> always upload artifacts by default for QEMU jobs, by setting the
> 'artifacts:when' keyword in the global default section [2].
> 
> [1] https://docs.gitlab.com/ee/ci/yaml/index.html#artifactswhen
> [2] https://docs.gitlab.com/ee/ci/yaml/index.html#default
> 
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.d/qemu-project.yml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/.gitlab-ci.d/qemu-project.yml b/.gitlab-ci.d/qemu-project.yml
> index 871262fe0e8..24137c14dc4 100644
> --- a/.gitlab-ci.d/qemu-project.yml
> +++ b/.gitlab-ci.d/qemu-project.yml
> @@ -1,6 +1,10 @@
>  # This file contains the set of jobs run by the QEMU project:
>  # https://gitlab.com/qemu-project/qemu/-/pipelines
>  
> +default:
> +  artifacts:
> +    when: always

Hmm this doesn't work as expected... Please disregard this patch.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-30 15:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-29 23:33 [PATCH] gitlab-ci: Always upload artifacts by default Philippe Mathieu-Daudé
2021-12-30 15:51 ` Philippe Mathieu-Daudé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.