* [PATCH 14/18] cx25840: Fix subdev registration in cx25840-core.c
@ 2010-12-31 11:37 Igor M. Liplianin
0 siblings, 0 replies; 5+ messages in thread
From: Igor M. Liplianin @ 2010-12-31 11:37 UTC (permalink / raw)
To: mchehab, linux-media, linux-kernel
On my system, cx23885 based card reports default volume value above 70000.
So, register cx25840 subdev fails. Although, the card don't have a/v inputs
it needs a/v firmware to be loaded.
Signed-off-by: Igor M. Liplianin <liplianin@netup.ru>
---
drivers/media/video/cx25840/cx25840-core.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c
index dfb198d..dc0cec7 100644
--- a/drivers/media/video/cx25840/cx25840-core.c
+++ b/drivers/media/video/cx25840/cx25840-core.c
@@ -1991,6 +1991,8 @@ static int cx25840_probe(struct i2c_client *client,
if (!is_cx2583x(state)) {
default_volume = 228 - cx25840_read(client, 0x8d4);
default_volume = ((default_volume / 2) + 23) << 9;
+ if (default_volume > 65535)
+ default_volume = 65535;
state->volume = v4l2_ctrl_new_std(&state->hdl,
&cx25840_audio_ctrl_ops, V4L2_CID_AUDIO_VOLUME,
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 14/18] cx25840: Fix subdev registration in cx25840-core.c
2011-01-01 12:58 ` Andy Walls
(?)
@ 2011-01-01 13:44 ` Igor M. Liplianin
-1 siblings, 0 replies; 5+ messages in thread
From: Igor M. Liplianin @ 2011-01-01 13:44 UTC (permalink / raw)
To: Andy Walls, Andy Walls, Mauro Carvalho Chehab
Cc: mchehab, linux-media, linux-kernel, ivtv-devel
В сообщении от 1 января 2011 14:58:30 автор Andy Walls написал:
> Igor,
>
> The proper fix is here:
>
> https://patchwork.kernel.org/patch/376612/
>
> So, NAK on your particular patch.
So, it is safe to skip my patch.
Mauro, please skip it.
>
> Mauro,
>
> I do not see the above patch at linux next. And I couldn't find it in your
> kernel.org tree. What is its status?
>
> This fixes a regression that is known to break cx23885 hardware
> initialization and can break ivtv hardware initialization.
>
> Regards,
> Andy
>
> "Igor M. Liplianin" <liplianin@me.by> wrote:
> >On my system, cx23885 based card reports default volume value above 70000.
> >So, register cx25840 subdev fails. Although, the card don't have a/v
> >inputs it needs a/v firmware to be loaded.
> >
> >Signed-off-by: Igor M. Liplianin <liplianin@netup.ru>
> >---
> >
> > drivers/media/video/cx25840/cx25840-core.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> >diff --git a/drivers/media/video/cx25840/cx25840-core.c
> >b/drivers/media/video/cx25840/cx25840-core.c index dfb198d..dc0cec7
> >100644
> >--- a/drivers/media/video/cx25840/cx25840-core.c
> >+++ b/drivers/media/video/cx25840/cx25840-core.c
> >@@ -1991,6 +1991,8 @@ static int cx25840_probe(struct i2c_client *client,
> >
> > if (!is_cx2583x(state)) {
> >
> > default_volume = 228 - cx25840_read(client, 0x8d4);
> > default_volume = ((default_volume / 2) + 23) << 9;
> >
> >+ if (default_volume > 65535)
> >+ default_volume = 65535;
> >
> > state->volume = v4l2_ctrl_new_std(&state->hdl,
> >
> > &cx25840_audio_ctrl_ops, V4L2_CID_AUDIO_VOLUME,
--
Igor M. Liplianin
Microsoft Windows Free Zone - Linux used for all Computing Tasks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 14/18] cx25840: Fix subdev registration in cx25840-core.c
@ 2011-01-01 12:58 ` Andy Walls
0 siblings, 0 replies; 5+ messages in thread
From: Andy Walls @ 2011-01-01 12:58 UTC (permalink / raw)
To: Igor M. Liplianin, mchehab, linux-media, linux-kernel, ivtv-devel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1768 bytes --]
Igor,
The proper fix is here:
https://patchwork.kernel.org/patch/376612/
So, NAK on your particular patch.
Mauro,
I do not see the above patch at linux next. And I couldn't find it in your kernel.org tree. What is its status?
This fixes a regression that is known to break cx23885 hardware initialization and can break ivtv hardware initialization.
Regards,
Andy
"Igor M. Liplianin" <liplianin@me.by> wrote:
>On my system, cx23885 based card reports default volume value above 70000.
>So, register cx25840 subdev fails. Although, the card don't have a/v inputs
>it needs a/v firmware to be loaded.
>
>Signed-off-by: Igor M. Liplianin <liplianin@netup.ru>
>---
> drivers/media/video/cx25840/cx25840-core.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c
>index dfb198d..dc0cec7 100644
>--- a/drivers/media/video/cx25840/cx25840-core.c
>+++ b/drivers/media/video/cx25840/cx25840-core.c
>@@ -1991,6 +1991,8 @@ static int cx25840_probe(struct i2c_client *client,
> if (!is_cx2583x(state)) {
> default_volume = 228 - cx25840_read(client, 0x8d4);
> default_volume = ((default_volume / 2) + 23) << 9;
>+ if (default_volume > 65535)
>+ default_volume = 65535;
>
> state->volume = v4l2_ctrl_new_std(&state->hdl,
> &cx25840_audio_ctrl_ops, V4L2_CID_AUDIO_VOLUME,
>--
>1.7.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-media" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 14/18] cx25840: Fix subdev registration in cx25840-core.c
@ 2011-01-01 12:58 ` Andy Walls
0 siblings, 0 replies; 5+ messages in thread
From: Andy Walls @ 2011-01-01 12:58 UTC (permalink / raw)
To: Igor M. Liplianin, mchehab, linux-media, linux-kernel, ivtv-devel
Igor,
The proper fix is here:
https://patchwork.kernel.org/patch/376612/
So, NAK on your particular patch.
Mauro,
I do not see the above patch at linux next. And I couldn't find it in your kernel.org tree. What is its status?
This fixes a regression that is known to break cx23885 hardware initialization and can break ivtv hardware initialization.
Regards,
Andy
"Igor M. Liplianin" <liplianin@me.by> wrote:
>On my system, cx23885 based card reports default volume value above 70000.
>So, register cx25840 subdev fails. Although, the card don't have a/v inputs
>it needs a/v firmware to be loaded.
>
>Signed-off-by: Igor M. Liplianin <liplianin@netup.ru>
>---
> drivers/media/video/cx25840/cx25840-core.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c
>index dfb198d..dc0cec7 100644
>--- a/drivers/media/video/cx25840/cx25840-core.c
>+++ b/drivers/media/video/cx25840/cx25840-core.c
>@@ -1991,6 +1991,8 @@ static int cx25840_probe(struct i2c_client *client,
> if (!is_cx2583x(state)) {
> default_volume = 228 - cx25840_read(client, 0x8d4);
> default_volume = ((default_volume / 2) + 23) << 9;
>+ if (default_volume > 65535)
>+ default_volume = 65535;
>
> state->volume = v4l2_ctrl_new_std(&state->hdl,
> &cx25840_audio_ctrl_ops, V4L2_CID_AUDIO_VOLUME,
>--
>1.7.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-media" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 14/18] cx25840: Fix subdev registration in cx25840-core.c
@ 2010-12-31 11:37 Igor M. Liplianin
0 siblings, 0 replies; 5+ messages in thread
From: Igor M. Liplianin @ 2010-12-31 11:37 UTC (permalink / raw)
To: mchehab, linux-media, linux-kernel
On my system, cx23885 based card reports default volume value above 70000.
So, register cx25840 subdev fails. Although, the card don't have a/v inputs
it needs a/v firmware to be loaded.
Signed-off-by: Igor M. Liplianin <liplianin@netup.ru>
---
drivers/media/video/cx25840/cx25840-core.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c
index dfb198d..dc0cec7 100644
--- a/drivers/media/video/cx25840/cx25840-core.c
+++ b/drivers/media/video/cx25840/cx25840-core.c
@@ -1991,6 +1991,8 @@ static int cx25840_probe(struct i2c_client *client,
if (!is_cx2583x(state)) {
default_volume = 228 - cx25840_read(client, 0x8d4);
default_volume = ((default_volume / 2) + 23) << 9;
+ if (default_volume > 65535)
+ default_volume = 65535;
state->volume = v4l2_ctrl_new_std(&state->hdl,
&cx25840_audio_ctrl_ops, V4L2_CID_AUDIO_VOLUME,
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-01 13:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-31 11:37 [PATCH 14/18] cx25840: Fix subdev registration in cx25840-core.c Igor M. Liplianin
-- strict thread matches above, loose matches on Subject: below --
2011-01-01 12:58 Andy Walls
2011-01-01 12:58 ` Andy Walls
2011-01-01 13:44 ` Igor M. Liplianin
2010-12-31 11:37 Igor M. Liplianin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.