From: David Lechner <david@lechnology.com>
To: grzegorz.jaszczyk@linaro.org
Cc: bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org,
ohad@wizery.com, praneeth@ti.com, robh+dt@kernel.org,
rogerq@ti.com, s-anna@ti.com, ssantosh@kernel.org,
t-kristo@ti.com
Subject: Re: [PATCH v2 2/5] remoteproc: pru: Add APIs to get and put the PRU cores
Date: Mon, 4 Jan 2021 14:56:41 -0600 [thread overview]
Message-ID: <4d3048fd-76be-e07d-b155-95a9600053eb@lechnology.com> (raw)
In-Reply-To: <20201216165239.2744-3-grzegorz.jaszczyk@linaro.org>
>
> @@ -706,14 +824,14 @@ static int pru_rproc_set_id(struct pru_rproc *pru)
> case RTU0_IRAM_ADDR_MASK:
> fallthrough;
> case PRU0_IRAM_ADDR_MASK:
> - pru->id = 0;
> + pru->id = PRUSS_PRU0;
> break;
> case TX_PRU1_IRAM_ADDR_MASK:
> fallthrough;
> case RTU1_IRAM_ADDR_MASK:
> fallthrough;
> case PRU1_IRAM_ADDR_MASK:
> - pru->id = 1;
> + pru->id = PRUSS_PRU1;
> break;
> default:
> ret = -EINVAL;
There is a similar opportunity for using PRUSS_PRU1 in pru_d_da_to_va()
WARNING: multiple messages have this Message-ID (diff)
From: David Lechner <david@lechnology.com>
To: grzegorz.jaszczyk@linaro.org
Cc: ohad@wizery.com, devicetree@vger.kernel.org,
mathieu.poirier@linaro.org, praneeth@ti.com,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
bjorn.andersson@linaro.org, t-kristo@ti.com, robh+dt@kernel.org,
ssantosh@kernel.org, linux-omap@vger.kernel.org,
lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org,
rogerq@ti.com
Subject: Re: [PATCH v2 2/5] remoteproc: pru: Add APIs to get and put the PRU cores
Date: Mon, 4 Jan 2021 14:56:41 -0600 [thread overview]
Message-ID: <4d3048fd-76be-e07d-b155-95a9600053eb@lechnology.com> (raw)
In-Reply-To: <20201216165239.2744-3-grzegorz.jaszczyk@linaro.org>
>
> @@ -706,14 +824,14 @@ static int pru_rproc_set_id(struct pru_rproc *pru)
> case RTU0_IRAM_ADDR_MASK:
> fallthrough;
> case PRU0_IRAM_ADDR_MASK:
> - pru->id = 0;
> + pru->id = PRUSS_PRU0;
> break;
> case TX_PRU1_IRAM_ADDR_MASK:
> fallthrough;
> case RTU1_IRAM_ADDR_MASK:
> fallthrough;
> case PRU1_IRAM_ADDR_MASK:
> - pru->id = 1;
> + pru->id = PRUSS_PRU1;
> break;
> default:
> ret = -EINVAL;
There is a similar opportunity for using PRUSS_PRU1 in pru_d_da_to_va()
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-04 20:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 16:52 [PATCH v2 0/5] Introduce PRU remoteproc consumer API Grzegorz Jaszczyk
2020-12-16 16:52 ` Grzegorz Jaszczyk
2020-12-16 16:52 ` [PATCH v2 1/5] dt-bindings: remoteproc: Add PRU consumer bindings Grzegorz Jaszczyk
2020-12-16 16:52 ` Grzegorz Jaszczyk
2020-12-16 16:52 ` [PATCH v2 2/5] remoteproc: pru: Add APIs to get and put the PRU cores Grzegorz Jaszczyk
2020-12-16 16:52 ` Grzegorz Jaszczyk
2021-01-04 20:56 ` David Lechner [this message]
2021-01-04 20:56 ` David Lechner
2020-12-16 16:52 ` [PATCH v2 3/5] remoteproc: pru: Deny rproc sysfs ops for PRU client driven boots Grzegorz Jaszczyk
2020-12-16 16:52 ` Grzegorz Jaszczyk
2020-12-17 22:43 ` kernel test robot
2020-12-17 22:43 ` kernel test robot
2020-12-16 16:52 ` [PATCH v2 4/5] remoteproc: pru: Add pru_rproc_set_ctable() function Grzegorz Jaszczyk
2020-12-16 16:52 ` Grzegorz Jaszczyk
2020-12-16 16:52 ` [PATCH v2 5/5] remoteproc: pru: Configure firmware based on client setup Grzegorz Jaszczyk
2020-12-16 16:52 ` Grzegorz Jaszczyk
2021-01-04 20:11 ` [PATCH v2 0/5] Introduce PRU remoteproc consumer API David Lechner
2021-01-04 20:11 ` David Lechner
2021-01-06 21:05 ` Suman Anna
2021-01-06 21:05 ` Suman Anna
2021-01-06 23:27 ` Mathieu Poirier
2021-01-06 23:27 ` Mathieu Poirier
2021-01-07 0:03 ` Suman Anna
2021-01-07 0:03 ` Suman Anna
2021-01-07 22:44 ` Mathieu Poirier
2021-01-07 22:44 ` Mathieu Poirier
2021-01-07 22:49 ` Suman Anna
2021-01-07 22:49 ` Suman Anna
2021-01-25 4:34 ` santosh.shilimkar
2021-01-25 4:34 ` santosh.shilimkar
2021-01-25 15:43 ` Suman Anna
2021-01-25 15:43 ` Suman Anna
2021-01-25 15:56 ` [External] : " Santosh Shilimkar
2021-01-25 15:56 ` Santosh Shilimkar
2021-12-26 13:00 ` Christian Gmeiner
2021-12-26 13:00 ` Christian Gmeiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d3048fd-76be-e07d-b155-95a9600053eb@lechnology.com \
--to=david@lechnology.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grzegorz.jaszczyk@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=s-anna@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.