From: zijun_hu <zijun_hu@zoho.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] ARMv8: fix error in freeing stack frame
Date: Sat, 23 Sep 2017 13:30:58 +0800 [thread overview]
Message-ID: <4d3a3ded-c3ac-2890-8f87-e8708633b283@zoho.com> (raw)
From: zijun_hu <zijun_hu@htc.com>
relocate_code() allocates 32 bytes stack frame but only 16 bytes are
freed before return. it will cause errors to possible previous frames
and doesn't make relocate_code() look like a function.
fix by freeing 32 bytes stack space
Signed-off-by: zijun_hu <zijun_hu@htc.com>
---
arch/arm/lib/relocate_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/lib/relocate_64.S b/arch/arm/lib/relocate_64.S
index c7600537063f..fdba004363af 100644
--- a/arch/arm/lib/relocate_64.S
+++ b/arch/arm/lib/relocate_64.S
@@ -73,6 +73,6 @@ relocate_done:
isb sy
4: ldp x0, x1, [sp, #16]
bl __asm_flush_dcache_range
-5: ldp x29, x30, [sp],#16
+5: ldp x29, x30, [sp],#32
ret
ENDPROC(relocate_code)
--
1.9.1
next reply other threads:[~2017-09-23 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-23 5:30 zijun_hu [this message]
2017-09-25 2:15 ` [U-Boot] [PATCH 1/1] ARMv8: fix error in freeing stack frame Simon Glass
2017-10-09 17:00 ` [U-Boot] [U-Boot,1/1] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d3a3ded-c3ac-2890-8f87-e8708633b283@zoho.com \
--to=zijun_hu@zoho.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.