* [U-Boot] [PATCH 1/1] ARMv8: fix error in freeing stack frame
@ 2017-09-23 5:30 zijun_hu
2017-09-25 2:15 ` Simon Glass
2017-10-09 17:00 ` [U-Boot] [U-Boot,1/1] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: zijun_hu @ 2017-09-23 5:30 UTC (permalink / raw)
To: u-boot
From: zijun_hu <zijun_hu@htc.com>
relocate_code() allocates 32 bytes stack frame but only 16 bytes are
freed before return. it will cause errors to possible previous frames
and doesn't make relocate_code() look like a function.
fix by freeing 32 bytes stack space
Signed-off-by: zijun_hu <zijun_hu@htc.com>
---
arch/arm/lib/relocate_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/lib/relocate_64.S b/arch/arm/lib/relocate_64.S
index c7600537063f..fdba004363af 100644
--- a/arch/arm/lib/relocate_64.S
+++ b/arch/arm/lib/relocate_64.S
@@ -73,6 +73,6 @@ relocate_done:
isb sy
4: ldp x0, x1, [sp, #16]
bl __asm_flush_dcache_range
-5: ldp x29, x30, [sp],#16
+5: ldp x29, x30, [sp],#32
ret
ENDPROC(relocate_code)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH 1/1] ARMv8: fix error in freeing stack frame
2017-09-23 5:30 [U-Boot] [PATCH 1/1] ARMv8: fix error in freeing stack frame zijun_hu
@ 2017-09-25 2:15 ` Simon Glass
2017-10-09 17:00 ` [U-Boot] [U-Boot,1/1] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2017-09-25 2:15 UTC (permalink / raw)
To: u-boot
On 22 September 2017 at 23:30, zijun_hu <zijun_hu@zoho.com> wrote:
> From: zijun_hu <zijun_hu@htc.com>
>
> relocate_code() allocates 32 bytes stack frame but only 16 bytes are
> freed before return. it will cause errors to possible previous frames
> and doesn't make relocate_code() look like a function.
>
> fix by freeing 32 bytes stack space
>
> Signed-off-by: zijun_hu <zijun_hu@htc.com>
> ---
> arch/arm/lib/relocate_64.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [U-Boot,1/1] ARMv8: fix error in freeing stack frame
2017-09-23 5:30 [U-Boot] [PATCH 1/1] ARMv8: fix error in freeing stack frame zijun_hu
2017-09-25 2:15 ` Simon Glass
@ 2017-10-09 17:00 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-10-09 17:00 UTC (permalink / raw)
To: u-boot
On Sat, Sep 23, 2017 at 01:30:58PM +0800, zijun_hu wrote:
> From: zijun_hu <zijun_hu@htc.com>
>
> relocate_code() allocates 32 bytes stack frame but only 16 bytes are
> freed before return. it will cause errors to possible previous frames
> and doesn't make relocate_code() look like a function.
>
> fix by freeing 32 bytes stack space
>
> Signed-off-by: zijun_hu <zijun_hu@htc.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171009/989ff4f3/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-09 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-23 5:30 [U-Boot] [PATCH 1/1] ARMv8: fix error in freeing stack frame zijun_hu
2017-09-25 2:15 ` Simon Glass
2017-10-09 17:00 ` [U-Boot] [U-Boot,1/1] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.