From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com>, virtualization@lists.linux-foundation.org Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com> Subject: Re: [RFC PATCH 10/10] vhost/vdpa: return configuration bytes read and written to user space Date: Tue, 2 Mar 2021 12:05:35 +0800 [thread overview] Message-ID: <4d682ff2-9663-d6ac-d5bf-616b2bf96e1a@redhat.com> (raw) In-Reply-To: <20210216094454.82106-11-sgarzare@redhat.com> On 2021/2/16 5:44 下午, Stefano Garzarella wrote: > vdpa_get_config() and vdpa_set_config() now return the amount > of bytes read and written, so let's return them to the user space. > > We also modify vhost_vdpa_config_validate() to return 0 (bytes read > or written) instead of an error, when the buffer length is 0. > > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> > --- > drivers/vhost/vdpa.c | 26 +++++++++++++++----------- > 1 file changed, 15 insertions(+), 11 deletions(-) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index 21eea2be5afa..b754c53171a7 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -191,9 +191,6 @@ static ssize_t vhost_vdpa_config_validate(struct vhost_vdpa *v, > struct vdpa_device *vdpa = v->vdpa; > u32 size = vdpa->config->get_config_size(vdpa); > > - if (c->len == 0) > - return -EINVAL; > - > return min(c->len, size); > } > > @@ -204,6 +201,7 @@ static long vhost_vdpa_get_config(struct vhost_vdpa *v, > struct vhost_vdpa_config config; > unsigned long size = offsetof(struct vhost_vdpa_config, buf); > ssize_t config_size; > + long ret; > u8 *buf; > > if (copy_from_user(&config, c, size)) > @@ -217,15 +215,18 @@ static long vhost_vdpa_get_config(struct vhost_vdpa *v, > if (!buf) > return -ENOMEM; > > - vdpa_get_config(vdpa, config.off, buf, config_size); > - > - if (copy_to_user(c->buf, buf, config_size)) { > - kvfree(buf); > - return -EFAULT; > + ret = vdpa_get_config(vdpa, config.off, buf, config_size); > + if (ret < 0) { > + ret = -EFAULT; > + goto out; > } > > + if (copy_to_user(c->buf, buf, config_size)) > + ret = -EFAULT; > + > +out: > kvfree(buf); > - return 0; > + return ret; > } > > static long vhost_vdpa_set_config(struct vhost_vdpa *v, > @@ -235,6 +236,7 @@ static long vhost_vdpa_set_config(struct vhost_vdpa *v, > struct vhost_vdpa_config config; > unsigned long size = offsetof(struct vhost_vdpa_config, buf); > ssize_t config_size; > + long ret; > u8 *buf; > > if (copy_from_user(&config, c, size)) > @@ -248,10 +250,12 @@ static long vhost_vdpa_set_config(struct vhost_vdpa *v, > if (IS_ERR(buf)) > return PTR_ERR(buf); > > - vdpa_set_config(vdpa, config.off, buf, config_size); > + ret = vdpa_set_config(vdpa, config.off, buf, config_size); > + if (ret < 0) > + ret = -EFAULT; > > kvfree(buf); > - return 0; > + return ret; > } So I wonder whether it's worth to return the number of bytes since we can't propogate the result to driver or driver doesn't care about that. Thanks > > static long vhost_vdpa_get_features(struct vhost_vdpa *v, u64 __user *featurep)
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com>, virtualization@lists.linux-foundation.org Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com> Subject: Re: [RFC PATCH 10/10] vhost/vdpa: return configuration bytes read and written to user space Date: Tue, 2 Mar 2021 12:05:35 +0800 [thread overview] Message-ID: <4d682ff2-9663-d6ac-d5bf-616b2bf96e1a@redhat.com> (raw) In-Reply-To: <20210216094454.82106-11-sgarzare@redhat.com> On 2021/2/16 5:44 下午, Stefano Garzarella wrote: > vdpa_get_config() and vdpa_set_config() now return the amount > of bytes read and written, so let's return them to the user space. > > We also modify vhost_vdpa_config_validate() to return 0 (bytes read > or written) instead of an error, when the buffer length is 0. > > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> > --- > drivers/vhost/vdpa.c | 26 +++++++++++++++----------- > 1 file changed, 15 insertions(+), 11 deletions(-) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index 21eea2be5afa..b754c53171a7 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -191,9 +191,6 @@ static ssize_t vhost_vdpa_config_validate(struct vhost_vdpa *v, > struct vdpa_device *vdpa = v->vdpa; > u32 size = vdpa->config->get_config_size(vdpa); > > - if (c->len == 0) > - return -EINVAL; > - > return min(c->len, size); > } > > @@ -204,6 +201,7 @@ static long vhost_vdpa_get_config(struct vhost_vdpa *v, > struct vhost_vdpa_config config; > unsigned long size = offsetof(struct vhost_vdpa_config, buf); > ssize_t config_size; > + long ret; > u8 *buf; > > if (copy_from_user(&config, c, size)) > @@ -217,15 +215,18 @@ static long vhost_vdpa_get_config(struct vhost_vdpa *v, > if (!buf) > return -ENOMEM; > > - vdpa_get_config(vdpa, config.off, buf, config_size); > - > - if (copy_to_user(c->buf, buf, config_size)) { > - kvfree(buf); > - return -EFAULT; > + ret = vdpa_get_config(vdpa, config.off, buf, config_size); > + if (ret < 0) { > + ret = -EFAULT; > + goto out; > } > > + if (copy_to_user(c->buf, buf, config_size)) > + ret = -EFAULT; > + > +out: > kvfree(buf); > - return 0; > + return ret; > } > > static long vhost_vdpa_set_config(struct vhost_vdpa *v, > @@ -235,6 +236,7 @@ static long vhost_vdpa_set_config(struct vhost_vdpa *v, > struct vhost_vdpa_config config; > unsigned long size = offsetof(struct vhost_vdpa_config, buf); > ssize_t config_size; > + long ret; > u8 *buf; > > if (copy_from_user(&config, c, size)) > @@ -248,10 +250,12 @@ static long vhost_vdpa_set_config(struct vhost_vdpa *v, > if (IS_ERR(buf)) > return PTR_ERR(buf); > > - vdpa_set_config(vdpa, config.off, buf, config_size); > + ret = vdpa_set_config(vdpa, config.off, buf, config_size); > + if (ret < 0) > + ret = -EFAULT; > > kvfree(buf); > - return 0; > + return ret; > } So I wonder whether it's worth to return the number of bytes since we can't propogate the result to driver or driver doesn't care about that. Thanks > > static long vhost_vdpa_get_features(struct vhost_vdpa *v, u64 __user *featurep) _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-03-02 8:12 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-16 9:44 [RFC PATCH 00/10] vdpa: get/set_config() rework Stefano Garzarella 2021-02-16 9:44 ` Stefano Garzarella 2021-02-16 9:44 ` [RFC PATCH 01/10] vdpa: add get_config_size callback in vdpa_config_ops Stefano Garzarella 2021-02-16 9:44 ` Stefano Garzarella 2021-03-02 4:14 ` Jason Wang 2021-03-02 4:14 ` Jason Wang 2021-03-02 14:15 ` Stefano Garzarella 2021-03-02 14:15 ` Stefano Garzarella 2021-03-04 8:34 ` Jason Wang 2021-03-04 8:34 ` Jason Wang 2021-03-05 8:38 ` Stefano Garzarella 2021-03-05 8:38 ` Stefano Garzarella 2021-02-16 9:44 ` [RFC PATCH 02/10] vdpa: check vdpa_get_config() parameters and return bytes read Stefano Garzarella 2021-02-16 9:44 ` Stefano Garzarella 2021-02-16 9:44 ` [RFC PATCH 03/10] vdpa: add vdpa_set_config() helper Stefano Garzarella 2021-02-16 9:44 ` Stefano Garzarella 2021-02-16 9:44 ` [RFC PATCH 04/10] vdpa: remove param checks in the get/set_config callbacks Stefano Garzarella 2021-02-16 9:44 ` Stefano Garzarella 2021-02-16 9:44 ` [RFC PATCH 05/10] vdpa: remove WARN_ON() " Stefano Garzarella 2021-02-16 9:44 ` Stefano Garzarella 2021-02-16 9:44 ` [RFC PATCH 06/10] virtio_vdpa: use vdpa_set_config() Stefano Garzarella 2021-02-16 9:44 ` Stefano Garzarella 2021-02-16 9:44 ` [RFC PATCH 07/10] vhost/vdpa: " Stefano Garzarella 2021-02-16 9:44 ` Stefano Garzarella 2021-02-16 9:44 ` [RFC PATCH 08/10] vhost/vdpa: allow user space to pass buffers bigger than config space Stefano Garzarella 2021-02-16 9:44 ` Stefano Garzarella 2021-02-16 9:44 ` [RFC PATCH 09/10] vhost/vdpa: use get_config_size callback in vhost_vdpa_config_validate() Stefano Garzarella 2021-02-16 9:44 ` Stefano Garzarella 2021-02-16 9:44 ` [RFC PATCH 10/10] vhost/vdpa: return configuration bytes read and written to user space Stefano Garzarella 2021-02-16 9:44 ` Stefano Garzarella 2021-03-02 4:05 ` Jason Wang [this message] 2021-03-02 4:05 ` Jason Wang 2021-03-02 14:06 ` Stefano Garzarella 2021-03-02 14:06 ` Stefano Garzarella 2021-03-04 8:31 ` Jason Wang 2021-03-04 8:31 ` Jason Wang 2021-03-05 8:37 ` Stefano Garzarella 2021-03-05 8:37 ` Stefano Garzarella 2021-03-08 3:59 ` Jason Wang 2021-03-08 3:59 ` Jason Wang 2021-03-01 8:17 ` [RFC PATCH 00/10] vdpa: get/set_config() rework Stefano Garzarella 2021-03-01 8:17 ` Stefano Garzarella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4d682ff2-9663-d6ac-d5bf-616b2bf96e1a@redhat.com \ --to=jasowang@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=sgarzare@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.