From: Coly Li <colyli@suse.de> To: "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, linux-bcache@vger.kernel.org, linux-nvdimm@lists.01.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v2] include: Remove pagemap.h from blkdev.h Date: Wed, 10 Mar 2021 18:29:06 +0800 [thread overview] Message-ID: <4d6e3281-98e5-e161-3883-00ccc88e1682@suse.de> (raw) In-Reply-To: <20210309195747.283796-1-willy@infradead.org> On 3/10/21 3:57 AM, Matthew Wilcox (Oracle) wrote: > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h is probably included too widely, > but untangling that dependency is harder and this solves my problem. > x86 allmodconfig builds, but there may be implicit include problems > on other architectures. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > --- > v2: Fix CONFIG_SWAP=n implicit use of pagemap.h by swap.h. Increases > the number of files from 240, but that's still a big win -- 68% > reduction instead of 77%. > > block/blk-settings.c | 1 + > drivers/block/brd.c | 1 + > drivers/block/loop.c | 1 + > drivers/md/bcache/super.c | 1 + > drivers/nvdimm/btt.c | 1 + > drivers/nvdimm/pmem.c | 1 + > drivers/scsi/scsicam.c | 1 + > include/linux/blkdev.h | 1 - > include/linux/swap.h | 1 + > 9 files changed, 8 insertions(+), 1 deletion(-) > [snipped] > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 71691f32959b..f154c89d1326 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -16,6 +16,7 @@ > #include "features.h" > > #include <linux/blkdev.h> > +#include <linux/pagemap.h> > #include <linux/debugfs.h> > #include <linux/genhd.h> > #include <linux/idr.h>[snipped] For bcache part, Acked-by: Coly Li <colyli@suse.de> Thanks. Coly Li _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Coly Li <colyli@suse.de> To: "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, linux-bcache@vger.kernel.org, linux-nvdimm@lists.01.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v2] include: Remove pagemap.h from blkdev.h Date: Wed, 10 Mar 2021 18:29:06 +0800 [thread overview] Message-ID: <4d6e3281-98e5-e161-3883-00ccc88e1682@suse.de> (raw) In-Reply-To: <20210309195747.283796-1-willy@infradead.org> On 3/10/21 3:57 AM, Matthew Wilcox (Oracle) wrote: > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h is probably included too widely, > but untangling that dependency is harder and this solves my problem. > x86 allmodconfig builds, but there may be implicit include problems > on other architectures. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > --- > v2: Fix CONFIG_SWAP=n implicit use of pagemap.h by swap.h. Increases > the number of files from 240, but that's still a big win -- 68% > reduction instead of 77%. > > block/blk-settings.c | 1 + > drivers/block/brd.c | 1 + > drivers/block/loop.c | 1 + > drivers/md/bcache/super.c | 1 + > drivers/nvdimm/btt.c | 1 + > drivers/nvdimm/pmem.c | 1 + > drivers/scsi/scsicam.c | 1 + > include/linux/blkdev.h | 1 - > include/linux/swap.h | 1 + > 9 files changed, 8 insertions(+), 1 deletion(-) > [snipped] > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 71691f32959b..f154c89d1326 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -16,6 +16,7 @@ > #include "features.h" > > #include <linux/blkdev.h> > +#include <linux/pagemap.h> > #include <linux/debugfs.h> > #include <linux/genhd.h> > #include <linux/idr.h>[snipped] For bcache part, Acked-by: Coly Li <colyli@suse.de> Thanks. Coly Li
next prev parent reply other threads:[~2021-03-10 10:29 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-09 19:57 [PATCH v2] include: Remove pagemap.h from blkdev.h Matthew Wilcox (Oracle) 2021-03-09 19:57 ` Matthew Wilcox (Oracle) 2021-03-09 20:47 ` Dan Williams 2021-03-09 20:47 ` Dan Williams 2021-03-09 20:47 ` Dan Williams 2021-03-09 20:50 ` Jens Axboe 2021-03-09 20:50 ` Jens Axboe 2021-03-10 8:43 ` Christoph Hellwig 2021-03-10 8:43 ` Christoph Hellwig 2021-03-10 10:29 ` Coly Li [this message] 2021-03-10 10:29 ` Coly Li 2021-03-10 14:51 ` Martin K. Petersen 2021-03-10 14:51 ` Martin K. Petersen 2021-03-10 18:28 ` William Kucharski 2021-03-10 18:28 ` William Kucharski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4d6e3281-98e5-e161-3883-00ccc88e1682@suse.de \ --to=colyli@suse.de \ --cc=akpm@linux-foundation.org \ --cc=linux-bcache@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linux-scsi@vger.kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.