[Accel-config] Re: [PATCH v1 0/8] Fix bugs in filter, list, config, enable areas

[Accel-config] Re: [PATCH v1 0/8] Fix bugs in filter, list, config, enable areas

[Dave Jiang]

[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]


On 5/5/2021 10:44 AM, ramesh.thomas(a)intel.com wrote:
> From: Ramesh Thomas <ramesh.thomas(a)intel.com>
>
> These patches fixes many of the bugs that were seen due to the addition
> of iax. While fixing the reqported issues found that the existing code
> was using assumptions that are obsolete. Many parts of the filter, list,
> config and enable/disable areas have been rewritten considering latest
> design changes. This simplifies the implementation and would make future
> maintenance easier.

Reviewed-by: Dave Jiang <dave.jiang(a)intel.com>

More deletion than add. Nice!


>
> Ramesh Thomas (8):
>    accel-config: Fix some indentation and coding convention errors
>    accel-config: Fix wrong return values in functions
>    accel-config: Rewrite filter functions
>    accel-config: Rewrite listing functions
>    accel-config: Rewrite device selection using new filter functions
>    accel-config: Skip negative fields in listings
>    accel-config: Return error if no args
>    accel-config: Do not return error if help was specifically called
>
>   accfg/accel-config.c |   2 +-
>   accfg/config_attr.c  | 154 +++++-------------
>   accfg/enable.c       | 106 +++++-------
>   accfg/list.c         | 278 +++++++++++++++----------------
>   util/filter.c        | 379 +++++++++++++++++++++----------------------
>   util/filter.h        |  42 ++---
>   util/json.c          |  36 ++--
>   util/json.h          |   1 -
>   util/parse-options.c |   6 +-
>   9 files changed, 436 insertions(+), 568 deletions(-)
>