From: Eric Sandeen <sandeen@redhat.com>
To: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] misc: enable retpolines across all xfsprogs utilities
Date: Thu, 22 Feb 2018 09:31:41 -0600 [thread overview]
Message-ID: <4d78832f-4148-d0d9-e2f2-ee8e02a44e97@redhat.com> (raw)
In-Reply-To: <20180222150922.GA26282@infradead.org>
On 2/22/18 9:09 AM, Christoph Hellwig wrote:
> On Wed, Feb 21, 2018 at 06:16:25PM -0800, Darrick J. Wong wrote:
>> From: Darrick J. Wong <darrick.wong@oracle.com>
>>
>> Detect and enable retpolines for all code, to mitigate Spectre v2
>> (branch target injection) on x86.
>
> The mechanics look ok, but why do we really care for xfsprogs?
> fs utilities seem like a lesser target and should just be covered
> by hopefully sane compiler defaults, shouldn't they?
>
That's my feeling as well - does manually fixing one utility out of
hundreds on the system help anything? Shouldn't this be done via toolchain
or distro-package-build defaults?
-Eric
next prev parent reply other threads:[~2018-02-22 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 2:16 [PATCH] misc: enable retpolines across all xfsprogs utilities Darrick J. Wong
2018-02-22 15:09 ` Christoph Hellwig
2018-02-22 15:31 ` Eric Sandeen [this message]
2018-02-22 17:15 ` Darrick J. Wong
2018-02-22 21:10 ` Matthias Schniedermeyer
2018-02-22 23:57 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d78832f-4148-d0d9-e2f2-ee8e02a44e97@redhat.com \
--to=sandeen@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.