From: Alexandru Elisei <alexandru.elisei@arm.com> To: Will Deacon <will@kernel.org>, kvmarm@lists.cs.columbia.edu Cc: Marc Zyngier <maz@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, kernel-team@android.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 00/21] KVM: arm64: Rewrite page-table code and fault handling Date: Thu, 1 Oct 2020 11:21:43 +0100 [thread overview] Message-ID: <4d89869a-3c36-eadf-ba44-0a65a1fa7d19@arm.com> (raw) In-Reply-To: <20200911132529.19844-1-will@kernel.org> Hi Will, On 9/11/20 2:25 PM, Will Deacon wrote: > It's me again, with version five of the KVM page-table rework previously > seen at: > > v1: https://lore.kernel.org/r/20200730153406.25136-1-will@kernel.org > v2: https://lore.kernel.org/r/20200818132818.16065-1-will@kernel.org > v3: https://lore.kernel.org/r/20200825093953.26493-1-will@kernel.org > v4: https://lore.kernel.org/r/20200907152344.12978-1-will@kernel.org > > Changes since v4 include: > > * Add comments to the kerneldoc describing alignment behaviour for > addresses and size parameters > * Fix formatting of IPA size messages > * Fix handling of unaligned addresses in kvm_phys_addr_ioremap() > * Add DSB after zeroing stage-2 PGD pages > * Add reviewer tags > > Once again, thanks to Alex, Gavin and Andrew for their comments. I didn't realize that there won't be another iteration of the series. I reviewed all the patches with the exception of patch #5 ("KVM: arm64: Use generic allocator for hyp stage-1 page-tables") because I don't know much about what needs to mapped at EL2 stage 1, everything else looks alright to me. If the commit message can be modified, you can add my Reviewed-by tag to the series (sans #5); it's fine if that's not possible. Thanks, Alex > > Will > > Cc: Marc Zyngier <maz@kernel.org> > Cc: Quentin Perret <qperret@google.com> > Cc: James Morse <james.morse@arm.com> > Cc: Suzuki Poulose <suzuki.poulose@arm.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Gavin Shan <gshan@redhat.com> > Cc: Alexandru Elisei <alexandru.elisei@arm.com> > Cc: Andrew Scull <ascull@google.com> > Cc: kernel-team@android.com > Cc: linux-arm-kernel@lists.infradead.org > > --->8 > > Quentin Perret (4): > KVM: arm64: Add support for stage-2 write-protect in generic > page-table > KVM: arm64: Convert write-protect operation to generic page-table API > KVM: arm64: Add support for stage-2 cache flushing in generic > page-table > KVM: arm64: Convert memslot cache-flushing code to generic page-table > API > > Will Deacon (17): > KVM: arm64: Remove kvm_mmu_free_memory_caches() > KVM: arm64: Add stand-alone page-table walker infrastructure > KVM: arm64: Add support for creating kernel-agnostic stage-1 page > tables > KVM: arm64: Use generic allocator for hyp stage-1 page-tables > KVM: arm64: Add support for creating kernel-agnostic stage-2 page > tables > KVM: arm64: Add support for stage-2 map()/unmap() in generic > page-table > KVM: arm64: Convert kvm_phys_addr_ioremap() to generic page-table API > KVM: arm64: Convert kvm_set_spte_hva() to generic page-table API > KVM: arm64: Convert unmap_stage2_range() to generic page-table API > KVM: arm64: Add support for stage-2 page-aging in generic page-table > KVM: arm64: Convert page-aging and access faults to generic page-table > API > KVM: arm64: Add support for relaxing stage-2 perms in generic > page-table code > KVM: arm64: Convert user_mem_abort() to generic page-table API > KVM: arm64: Check the pgt instead of the pgd when modifying page-table > KVM: arm64: Remove unused page-table code > KVM: arm64: Remove unused 'pgd' field from 'struct kvm_s2_mmu' > KVM: arm64: Don't constrain maximum IPA size based on host > configuration > > arch/arm64/include/asm/kvm_host.h | 2 +- > arch/arm64/include/asm/kvm_mmu.h | 251 +--- > arch/arm64/include/asm/kvm_pgtable.h | 309 ++++ > arch/arm64/include/asm/pgtable-hwdef.h | 24 - > arch/arm64/include/asm/pgtable-prot.h | 19 - > arch/arm64/include/asm/stage2_pgtable.h | 215 --- > arch/arm64/kvm/arm.c | 2 +- > arch/arm64/kvm/hyp/Makefile | 2 +- > arch/arm64/kvm/hyp/pgtable.c | 883 ++++++++++++ > arch/arm64/kvm/mmu.c | 1748 ++++------------------- > arch/arm64/kvm/reset.c | 40 +- > 11 files changed, 1479 insertions(+), 2016 deletions(-) > create mode 100644 arch/arm64/include/asm/kvm_pgtable.h > create mode 100644 arch/arm64/kvm/hyp/pgtable.c > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Alexandru Elisei <alexandru.elisei@arm.com> To: Will Deacon <will@kernel.org>, kvmarm@lists.cs.columbia.edu Cc: Gavin Shan <gshan@redhat.com>, Suzuki Poulose <suzuki.poulose@arm.com>, Marc Zyngier <maz@kernel.org>, Quentin Perret <qperret@google.com>, James Morse <james.morse@arm.com>, Andrew Scull <ascull@google.com>, Catalin Marinas <catalin.marinas@arm.com>, kernel-team@android.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 00/21] KVM: arm64: Rewrite page-table code and fault handling Date: Thu, 1 Oct 2020 11:21:43 +0100 [thread overview] Message-ID: <4d89869a-3c36-eadf-ba44-0a65a1fa7d19@arm.com> (raw) In-Reply-To: <20200911132529.19844-1-will@kernel.org> Hi Will, On 9/11/20 2:25 PM, Will Deacon wrote: > It's me again, with version five of the KVM page-table rework previously > seen at: > > v1: https://lore.kernel.org/r/20200730153406.25136-1-will@kernel.org > v2: https://lore.kernel.org/r/20200818132818.16065-1-will@kernel.org > v3: https://lore.kernel.org/r/20200825093953.26493-1-will@kernel.org > v4: https://lore.kernel.org/r/20200907152344.12978-1-will@kernel.org > > Changes since v4 include: > > * Add comments to the kerneldoc describing alignment behaviour for > addresses and size parameters > * Fix formatting of IPA size messages > * Fix handling of unaligned addresses in kvm_phys_addr_ioremap() > * Add DSB after zeroing stage-2 PGD pages > * Add reviewer tags > > Once again, thanks to Alex, Gavin and Andrew for their comments. I didn't realize that there won't be another iteration of the series. I reviewed all the patches with the exception of patch #5 ("KVM: arm64: Use generic allocator for hyp stage-1 page-tables") because I don't know much about what needs to mapped at EL2 stage 1, everything else looks alright to me. If the commit message can be modified, you can add my Reviewed-by tag to the series (sans #5); it's fine if that's not possible. Thanks, Alex > > Will > > Cc: Marc Zyngier <maz@kernel.org> > Cc: Quentin Perret <qperret@google.com> > Cc: James Morse <james.morse@arm.com> > Cc: Suzuki Poulose <suzuki.poulose@arm.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Gavin Shan <gshan@redhat.com> > Cc: Alexandru Elisei <alexandru.elisei@arm.com> > Cc: Andrew Scull <ascull@google.com> > Cc: kernel-team@android.com > Cc: linux-arm-kernel@lists.infradead.org > > --->8 > > Quentin Perret (4): > KVM: arm64: Add support for stage-2 write-protect in generic > page-table > KVM: arm64: Convert write-protect operation to generic page-table API > KVM: arm64: Add support for stage-2 cache flushing in generic > page-table > KVM: arm64: Convert memslot cache-flushing code to generic page-table > API > > Will Deacon (17): > KVM: arm64: Remove kvm_mmu_free_memory_caches() > KVM: arm64: Add stand-alone page-table walker infrastructure > KVM: arm64: Add support for creating kernel-agnostic stage-1 page > tables > KVM: arm64: Use generic allocator for hyp stage-1 page-tables > KVM: arm64: Add support for creating kernel-agnostic stage-2 page > tables > KVM: arm64: Add support for stage-2 map()/unmap() in generic > page-table > KVM: arm64: Convert kvm_phys_addr_ioremap() to generic page-table API > KVM: arm64: Convert kvm_set_spte_hva() to generic page-table API > KVM: arm64: Convert unmap_stage2_range() to generic page-table API > KVM: arm64: Add support for stage-2 page-aging in generic page-table > KVM: arm64: Convert page-aging and access faults to generic page-table > API > KVM: arm64: Add support for relaxing stage-2 perms in generic > page-table code > KVM: arm64: Convert user_mem_abort() to generic page-table API > KVM: arm64: Check the pgt instead of the pgd when modifying page-table > KVM: arm64: Remove unused page-table code > KVM: arm64: Remove unused 'pgd' field from 'struct kvm_s2_mmu' > KVM: arm64: Don't constrain maximum IPA size based on host > configuration > > arch/arm64/include/asm/kvm_host.h | 2 +- > arch/arm64/include/asm/kvm_mmu.h | 251 +--- > arch/arm64/include/asm/kvm_pgtable.h | 309 ++++ > arch/arm64/include/asm/pgtable-hwdef.h | 24 - > arch/arm64/include/asm/pgtable-prot.h | 19 - > arch/arm64/include/asm/stage2_pgtable.h | 215 --- > arch/arm64/kvm/arm.c | 2 +- > arch/arm64/kvm/hyp/Makefile | 2 +- > arch/arm64/kvm/hyp/pgtable.c | 883 ++++++++++++ > arch/arm64/kvm/mmu.c | 1748 ++++------------------- > arch/arm64/kvm/reset.c | 40 +- > 11 files changed, 1479 insertions(+), 2016 deletions(-) > create mode 100644 arch/arm64/include/asm/kvm_pgtable.h > create mode 100644 arch/arm64/kvm/hyp/pgtable.c > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-01 10:20 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-11 13:25 [PATCH v5 00/21] KVM: arm64: Rewrite page-table code and fault handling Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 01/21] KVM: arm64: Remove kvm_mmu_free_memory_caches() Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 02/21] KVM: arm64: Add stand-alone page-table walker infrastructure Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 03/21] KVM: arm64: Add support for creating kernel-agnostic stage-1 page tables Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 04/21] KVM: arm64: Use generic allocator for hyp stage-1 page-tables Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 05/21] KVM: arm64: Add support for creating kernel-agnostic stage-2 page tables Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 06/21] KVM: arm64: Add support for stage-2 map()/unmap() in generic page-table Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-15 10:47 ` Alexandru Elisei 2020-09-15 10:47 ` Alexandru Elisei 2020-09-11 13:25 ` [PATCH v5 07/21] KVM: arm64: Convert kvm_phys_addr_ioremap() to generic page-table API Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 08/21] KVM: arm64: Convert kvm_set_spte_hva() " Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 09/21] KVM: arm64: Convert unmap_stage2_range() " Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-15 10:57 ` Alexandru Elisei 2020-09-15 10:57 ` Alexandru Elisei 2020-09-11 13:25 ` [PATCH v5 10/21] KVM: arm64: Add support for stage-2 page-aging in generic page-table Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 11/21] KVM: arm64: Convert page-aging and access faults to generic page-table API Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 12/21] KVM: arm64: Add support for stage-2 write-protect in generic page-table Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 13/21] KVM: arm64: Convert write-protect operation to generic page-table API Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 14/21] KVM: arm64: Add support for stage-2 cache flushing in generic page-table Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 15/21] KVM: arm64: Convert memslot cache-flushing code to generic page-table API Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 16/21] KVM: arm64: Add support for relaxing stage-2 perms in generic page-table code Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-15 16:16 ` Alexandru Elisei 2020-09-15 16:16 ` Alexandru Elisei 2020-09-11 13:25 ` [PATCH v5 17/21] KVM: arm64: Convert user_mem_abort() to generic page-table API Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 18/21] KVM: arm64: Check the pgt instead of the pgd when modifying page-table Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 19/21] KVM: arm64: Remove unused page-table code Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 20/21] KVM: arm64: Remove unused 'pgd' field from 'struct kvm_s2_mmu' Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 13:25 ` [PATCH v5 21/21] KVM: arm64: Don't constrain maximum IPA size based on host configuration Will Deacon 2020-09-11 13:25 ` Will Deacon 2020-09-11 15:04 ` [PATCH v5 00/21] KVM: arm64: Rewrite page-table code and fault handling Marc Zyngier 2020-09-11 15:04 ` Marc Zyngier 2020-10-01 10:21 ` Alexandru Elisei [this message] 2020-10-01 10:21 ` Alexandru Elisei 2020-10-01 12:28 ` Will Deacon 2020-10-01 12:28 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4d89869a-3c36-eadf-ba44-0a65a1fa7d19@arm.com \ --to=alexandru.elisei@arm.com \ --cc=catalin.marinas@arm.com \ --cc=kernel-team@android.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=maz@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.