* [PATCH] xen: mark expected switch fall-through
@ 2019-02-12 20:37 Gustavo A. R. Silva
2019-02-12 23:50 ` Boris Ostrovsky
2019-02-12 23:50 ` Boris Ostrovsky
0 siblings, 2 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-12 20:37 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini
Cc: xen-devel, linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/xen/xen-pciback/xenbus.c: In function ‘xen_pcibk_frontend_changed’:
drivers/xen/xen-pciback/xenbus.c:545:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (xenbus_dev_is_online(xdev))
^
drivers/xen/xen-pciback/xenbus.c:548:2: note: here
case XenbusStateUnknown:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/xen/xen-pciback/xenbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index 581c4e1a8b82..23f7f6ec7d1f 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -544,7 +544,7 @@ static void xen_pcibk_frontend_changed(struct xenbus_device *xdev,
xenbus_switch_state(xdev, XenbusStateClosed);
if (xenbus_dev_is_online(xdev))
break;
- /* fall through if not online */
+ /* fall through - if not online */
case XenbusStateUnknown:
dev_dbg(&xdev->dev, "frontend is gone! unregister device\n");
device_unregister(&xdev->dev);
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] xen: mark expected switch fall-through
2019-02-12 20:37 [PATCH] xen: mark expected switch fall-through Gustavo A. R. Silva
@ 2019-02-12 23:50 ` Boris Ostrovsky
2019-02-12 23:50 ` Boris Ostrovsky
1 sibling, 0 replies; 8+ messages in thread
From: Boris Ostrovsky @ 2019-02-12 23:50 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Juergen Gross, xen-devel, Stefano Stabellini, linux-kernel, Kees Cook
On Tue, Feb 12, 2019 at 02:37:20PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/xen/xen-pciback/xenbus.c: In function ‘xen_pcibk_frontend_changed’:
> drivers/xen/xen-pciback/xenbus.c:545:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (xenbus_dev_is_online(xdev))
> ^
> drivers/xen/xen-pciback/xenbus.c:548:2: note: here
> case XenbusStateUnknown:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to for-linus-5.0
(xen-scsiback patch too)
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen: mark expected switch fall-through
2019-02-12 20:37 [PATCH] xen: mark expected switch fall-through Gustavo A. R. Silva
2019-02-12 23:50 ` Boris Ostrovsky
@ 2019-02-12 23:50 ` Boris Ostrovsky
2019-02-13 0:54 ` Gustavo A. R. Silva
` (3 more replies)
1 sibling, 4 replies; 8+ messages in thread
From: Boris Ostrovsky @ 2019-02-12 23:50 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Juergen Gross, Stefano Stabellini, xen-devel, linux-kernel, Kees Cook
On Tue, Feb 12, 2019 at 02:37:20PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/xen/xen-pciback/xenbus.c: In function ‘xen_pcibk_frontend_changed’:
> drivers/xen/xen-pciback/xenbus.c:545:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (xenbus_dev_is_online(xdev))
> ^
> drivers/xen/xen-pciback/xenbus.c:548:2: note: here
> case XenbusStateUnknown:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to for-linus-5.0
(xen-scsiback patch too)
-boris
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xen: mark expected switch fall-through
2019-02-12 23:50 ` Boris Ostrovsky
@ 2019-02-13 0:54 ` Gustavo A. R. Silva
2019-02-13 0:54 ` Gustavo A. R. Silva
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-13 0:54 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: Juergen Gross, xen-devel, Stefano Stabellini, linux-kernel, Kees Cook
On 2/12/19 5:50 PM, Boris Ostrovsky wrote:
> On Tue, Feb 12, 2019 at 02:37:20PM -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/xen/xen-pciback/xenbus.c: In function ‘xen_pcibk_frontend_changed’:
>> drivers/xen/xen-pciback/xenbus.c:545:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (xenbus_dev_is_online(xdev))
>> ^
>> drivers/xen/xen-pciback/xenbus.c:548:2: note: here
>> case XenbusStateUnknown:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied to for-linus-5.0
>
> (xen-scsiback patch too)
>
Thank you, Boris.
--
Gustavo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xen: mark expected switch fall-through
2019-02-12 23:50 ` Boris Ostrovsky
2019-02-13 0:54 ` Gustavo A. R. Silva
@ 2019-02-13 0:54 ` Gustavo A. R. Silva
2019-02-13 5:50 ` Juergen Gross
2019-02-13 5:50 ` Juergen Gross
3 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-13 0:54 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: Juergen Gross, Stefano Stabellini, xen-devel, linux-kernel, Kees Cook
On 2/12/19 5:50 PM, Boris Ostrovsky wrote:
> On Tue, Feb 12, 2019 at 02:37:20PM -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/xen/xen-pciback/xenbus.c: In function ‘xen_pcibk_frontend_changed’:
>> drivers/xen/xen-pciback/xenbus.c:545:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (xenbus_dev_is_online(xdev))
>> ^
>> drivers/xen/xen-pciback/xenbus.c:548:2: note: here
>> case XenbusStateUnknown:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied to for-linus-5.0
>
> (xen-scsiback patch too)
>
Thank you, Boris.
--
Gustavo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen: mark expected switch fall-through
2019-02-12 23:50 ` Boris Ostrovsky
2019-02-13 0:54 ` Gustavo A. R. Silva
2019-02-13 0:54 ` Gustavo A. R. Silva
@ 2019-02-13 5:50 ` Juergen Gross
2019-02-13 5:50 ` Juergen Gross
3 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2019-02-13 5:50 UTC (permalink / raw)
To: Boris Ostrovsky, Gustavo A. R. Silva
Cc: xen-devel, Stefano Stabellini, linux-kernel, Kees Cook
On 13/02/2019 00:50, Boris Ostrovsky wrote:
> On Tue, Feb 12, 2019 at 02:37:20PM -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/xen/xen-pciback/xenbus.c: In function ‘xen_pcibk_frontend_changed’:
>> drivers/xen/xen-pciback/xenbus.c:545:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (xenbus_dev_is_online(xdev))
>> ^
>> drivers/xen/xen-pciback/xenbus.c:548:2: note: here
>> case XenbusStateUnknown:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied to for-linus-5.0
>
> (xen-scsiback patch too)
I'm tending to delay those patches until 5.1, as we are pretty late in
the 5.0 cycle. We should add only really critical fixes to 5.0 now.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen: mark expected switch fall-through
2019-02-12 23:50 ` Boris Ostrovsky
` (2 preceding siblings ...)
2019-02-13 5:50 ` Juergen Gross
@ 2019-02-13 5:50 ` Juergen Gross
3 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2019-02-13 5:50 UTC (permalink / raw)
To: Boris Ostrovsky, Gustavo A. R. Silva
Cc: Stefano Stabellini, xen-devel, linux-kernel, Kees Cook
On 13/02/2019 00:50, Boris Ostrovsky wrote:
> On Tue, Feb 12, 2019 at 02:37:20PM -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/xen/xen-pciback/xenbus.c: In function ‘xen_pcibk_frontend_changed’:
>> drivers/xen/xen-pciback/xenbus.c:545:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (xenbus_dev_is_online(xdev))
>> ^
>> drivers/xen/xen-pciback/xenbus.c:548:2: note: here
>> case XenbusStateUnknown:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied to for-linus-5.0
>
> (xen-scsiback patch too)
I'm tending to delay those patches until 5.1, as we are pretty late in
the 5.0 cycle. We should add only really critical fixes to 5.0 now.
Juergen
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] xen: mark expected switch fall-through
@ 2019-02-12 20:37 Gustavo A. R. Silva
0 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-12 20:37 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini
Cc: xen-devel, linux-kernel, Kees Cook, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/xen/xen-pciback/xenbus.c: In function ‘xen_pcibk_frontend_changed’:
drivers/xen/xen-pciback/xenbus.c:545:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (xenbus_dev_is_online(xdev))
^
drivers/xen/xen-pciback/xenbus.c:548:2: note: here
case XenbusStateUnknown:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/xen/xen-pciback/xenbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index 581c4e1a8b82..23f7f6ec7d1f 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -544,7 +544,7 @@ static void xen_pcibk_frontend_changed(struct xenbus_device *xdev,
xenbus_switch_state(xdev, XenbusStateClosed);
if (xenbus_dev_is_online(xdev))
break;
- /* fall through if not online */
+ /* fall through - if not online */
case XenbusStateUnknown:
dev_dbg(&xdev->dev, "frontend is gone! unregister device\n");
device_unregister(&xdev->dev);
--
2.20.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-02-13 5:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 20:37 [PATCH] xen: mark expected switch fall-through Gustavo A. R. Silva
2019-02-12 23:50 ` Boris Ostrovsky
2019-02-12 23:50 ` Boris Ostrovsky
2019-02-13 0:54 ` Gustavo A. R. Silva
2019-02-13 0:54 ` Gustavo A. R. Silva
2019-02-13 5:50 ` Juergen Gross
2019-02-13 5:50 ` Juergen Gross
2019-02-12 20:37 Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.