* [igt-dev] [PATCH i-g-t] tests/kms_atomic_interruptible: Test Cleanup
@ 2022-08-26 3:49 Nidhi Gupta
2022-08-26 4:00 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
2022-08-26 18:21 ` [igt-dev] [PATCH i-g-t] " Jessica Zhang
0 siblings, 2 replies; 3+ messages in thread
From: Nidhi Gupta @ 2022-08-26 3:49 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_atomic_interruptible.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
index 038cb286..7bcb2d32 100644
--- a/tests/kms_atomic_interruptible.c
+++ b/tests/kms_atomic_interruptible.c
@@ -286,6 +286,8 @@ igt_main
igt_describe("Tests the interrupt properties of legacy modeset");
igt_subtest_with_dynamic("legacy-setmode") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ igt_display_require(&display, drm_fd);
+ igt_display_commit(&display);
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_legacy_modeset, DRM_PLANE_TYPE_PRIMARY);
break;
@@ -295,6 +297,8 @@ igt_main
igt_describe("Tests the interrupt properties of atomic modeset");
igt_subtest_with_dynamic("atomic-setmode") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ igt_display_require(&display, drm_fd);
+ igt_display_commit(&display);
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_atomic_modeset, DRM_PLANE_TYPE_PRIMARY);
break;
@@ -304,6 +308,8 @@ igt_main
igt_describe("Tests the interrupt properties for DPMS");
igt_subtest_with_dynamic("legacy-dpms") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ igt_display_require(&display, drm_fd);
+ igt_display_commit(&display);
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_legacy_dpms, DRM_PLANE_TYPE_PRIMARY);
break;
@@ -313,6 +319,8 @@ igt_main
igt_describe("Tests the interrupt properties for pageflip");
igt_subtest_with_dynamic("legacy-pageflip") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ igt_display_require(&display, drm_fd);
+ igt_display_commit(&display);
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_pageflip, DRM_PLANE_TYPE_PRIMARY);
break;
@@ -322,6 +330,8 @@ igt_main
igt_describe("Tests the interrupt properties for cursor");
igt_subtest_with_dynamic("legacy-cursor") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ igt_display_require(&display, drm_fd);
+ igt_display_commit(&display);
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_setcursor, DRM_PLANE_TYPE_CURSOR);
break;
@@ -331,6 +341,8 @@ igt_main
igt_describe("Tests the interrupt properties for primary plane");
igt_subtest_with_dynamic("universal-setplane-primary") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ igt_display_require(&display, drm_fd);
+ igt_display_commit(&display);
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_setplane, DRM_PLANE_TYPE_PRIMARY);
break;
@@ -340,6 +352,8 @@ igt_main
igt_describe("Tests the interrupt properties for cursor plane");
igt_subtest_with_dynamic("universal-setplane-cursor") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ igt_display_require(&display, drm_fd);
+ igt_display_commit(&display);
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_setplane, DRM_PLANE_TYPE_CURSOR);
break;
--
2.36.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_atomic_interruptible: Test Cleanup
2022-08-26 3:49 [igt-dev] [PATCH i-g-t] tests/kms_atomic_interruptible: Test Cleanup Nidhi Gupta
@ 2022-08-26 4:00 ` Patchwork
2022-08-26 18:21 ` [igt-dev] [PATCH i-g-t] " Jessica Zhang
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2022-08-26 4:00 UTC (permalink / raw)
To: Nidhi Gupta; +Cc: igt-dev
== Series Details ==
Series: tests/kms_atomic_interruptible: Test Cleanup
URL : https://patchwork.freedesktop.org/series/107776/
State : failure
== Summary ==
IGT patchset build failed on latest successful build
1298b5f0e1b3e010657ffba41d2e775fab028e08 igt: Allow overriding the commit hash in the version string
[265/663] Linking target lib/tests/igt_exit_handler
[266/663] Linking target lib/tests/igt_dynamic_subtests
[267/663] Linking target lib/tests/igt_describe
[268/663] Linking target lib/tests/igt_edid
[269/663] Linking target tests/gen3_render_tiledx_blits
[270/663] Linking target lib/tests/igt_fork_helper
[271/663] Linking target lib/tests/igt_list_only
[272/663] Linking target lib/tests/igt_invalid_subtest_name
[273/663] Linking target lib/tests/igt_nesting
[274/663] Linking target lib/tests/igt_simulation
[275/663] Linking target lib/tests/igt_no_exit
[276/663] Linking target lib/tests/igt_segfault
[277/663] Linking target lib/tests/igt_stats
[278/663] Linking target lib/tests/igt_subtest_group
[279/663] Linking target lib/tests/igt_thread
[280/663] Linking target lib/tests/i915_perf_data_alignment
[281/663] Linking target lib/tests/igt_audio
[282/663] Linking target lib/tests/igt_no_subtest
[283/663] Linking target lib/tests/igt_simple_test_subtests
[284/663] Linking target lib/tests/igt_timeout
[285/663] Linking target tests/dmabuf
[286/663] Linking target tests/core_auth
[287/663] Linking target tests/core_getclient
[288/663] Linking target tests/core_getstats
[289/663] Linking target tests/core_getversion
[290/663] Linking target tests/core_setmaster
[291/663] Linking target tests/core_setmaster_vs_auth
[292/663] Linking target tests/debugfs_test
[293/663] Linking target tests/dmabuf_sync_file
[294/663] Linking target tests/device_reset
[295/663] Linking target tests/drm_import_export
[296/663] Linking target tests/drm_buddy
[297/663] Linking target tests/drm_mm
[298/663] Linking target tests/drm_read
[299/663] Linking target tests/fbdev
[300/663] Linking target tests/feature_discovery
[301/663] Linking target tests/kms_3d
[302/663] Linking target tests/kms_addfb_basic
[303/663] Linking target tests/kms_atomic
[304/663] Linking target tests/kms_async_flips
[305/663] Compiling C object tests/kms_atomic_interruptible.p/kms_atomic_interruptible.c.o
FAILED: tests/kms_atomic_interruptible.p/kms_atomic_interruptible.c.o
ccache cc -Itests/kms_atomic_interruptible.p -Itests -I../tests -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I.. -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/x86_64-linux-gnu -I/usr/include/alsa -I/usr/include -I/home/cidrm/kernel_headers/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread -MD -MQ tests/kms_atomic_interruptible.p/kms_atomic_interruptible.c.o -MF tests/kms_atomic_interruptible.p/kms_atomic_interruptible.c.o.d -o tests/kms_atomic_interruptible.p/kms_atomic_interruptible.c.o -c ../tests/kms_atomic_interruptible.c
../tests/kms_atomic_interruptible.c: In function ‘__igt_unique____real_main268’:
../tests/kms_atomic_interruptible.c:289:34: error: ‘drm_fd’ undeclared (first use in this function); did you mean ‘dremf’?
igt_display_require(&display, drm_fd);
^~~~~~
dremf
../tests/kms_atomic_interruptible.c:289:34: note: each undeclared identifier is reported only once for each function it appears in
ninja: build stopped: subcommand failed.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_atomic_interruptible: Test Cleanup
2022-08-26 3:49 [igt-dev] [PATCH i-g-t] tests/kms_atomic_interruptible: Test Cleanup Nidhi Gupta
2022-08-26 4:00 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
@ 2022-08-26 18:21 ` Jessica Zhang
1 sibling, 0 replies; 3+ messages in thread
From: Jessica Zhang @ 2022-08-26 18:21 UTC (permalink / raw)
To: Nidhi Gupta; +Cc: igt-dev
Hi Nidhi,
On 8/25/2022 8:49 PM, Nidhi Gupta wrote:
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
> tests/kms_atomic_interruptible.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
> index 038cb286..7bcb2d32 100644
> --- a/tests/kms_atomic_interruptible.c
> +++ b/tests/kms_atomic_interruptible.c
> @@ -286,6 +286,8 @@ igt_main
> igt_describe("Tests the interrupt properties of legacy modeset");
> igt_subtest_with_dynamic("legacy-setmode") {
> for_each_pipe_with_valid_output(&display, pipe, output) {
> + igt_display_require(&display, drm_fd);
I believe `drm_fd` is a member of the display struct and not a local
variable.
Also, any reason to add extra calls to igt_display_require? There is
already a call to igt_display_require() here [1]. I also don't think it
would be necessary to reinitialize all the display resource structs for
each subtest.
[1]
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/tests/kms_atomic_interruptible.c#L280
> + igt_display_commit(&display);
Similarly, there is already a commit at the beginning of
run_plane_test() [2], so is this call necessary?
[2]
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/tests/kms_atomic_interruptible.c#L90
Thanks,
Jessica Zhang
> igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
> run_plane_test(&display, pipe, output, test_legacy_modeset, DRM_PLANE_TYPE_PRIMARY);
> break;
> @@ -295,6 +297,8 @@ igt_main
> igt_describe("Tests the interrupt properties of atomic modeset");
> igt_subtest_with_dynamic("atomic-setmode") {
> for_each_pipe_with_valid_output(&display, pipe, output) {
> + igt_display_require(&display, drm_fd);
> + igt_display_commit(&display);
> igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
> run_plane_test(&display, pipe, output, test_atomic_modeset, DRM_PLANE_TYPE_PRIMARY);
> break;
> @@ -304,6 +308,8 @@ igt_main
> igt_describe("Tests the interrupt properties for DPMS");
> igt_subtest_with_dynamic("legacy-dpms") {
> for_each_pipe_with_valid_output(&display, pipe, output) {
> + igt_display_require(&display, drm_fd);
> + igt_display_commit(&display);
> igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
> run_plane_test(&display, pipe, output, test_legacy_dpms, DRM_PLANE_TYPE_PRIMARY);
> break;
> @@ -313,6 +319,8 @@ igt_main
> igt_describe("Tests the interrupt properties for pageflip");
> igt_subtest_with_dynamic("legacy-pageflip") {
> for_each_pipe_with_valid_output(&display, pipe, output) {
> + igt_display_require(&display, drm_fd);
> + igt_display_commit(&display);
> igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
> run_plane_test(&display, pipe, output, test_pageflip, DRM_PLANE_TYPE_PRIMARY);
> break;
> @@ -322,6 +330,8 @@ igt_main
> igt_describe("Tests the interrupt properties for cursor");
> igt_subtest_with_dynamic("legacy-cursor") {
> for_each_pipe_with_valid_output(&display, pipe, output) {
> + igt_display_require(&display, drm_fd);
> + igt_display_commit(&display);
> igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
> run_plane_test(&display, pipe, output, test_setcursor, DRM_PLANE_TYPE_CURSOR);
> break;
> @@ -331,6 +341,8 @@ igt_main
> igt_describe("Tests the interrupt properties for primary plane");
> igt_subtest_with_dynamic("universal-setplane-primary") {
> for_each_pipe_with_valid_output(&display, pipe, output) {
> + igt_display_require(&display, drm_fd);
> + igt_display_commit(&display);
> igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
> run_plane_test(&display, pipe, output, test_setplane, DRM_PLANE_TYPE_PRIMARY);
> break;
> @@ -340,6 +352,8 @@ igt_main
> igt_describe("Tests the interrupt properties for cursor plane");
> igt_subtest_with_dynamic("universal-setplane-cursor") {
> for_each_pipe_with_valid_output(&display, pipe, output) {
> + igt_display_require(&display, drm_fd);
> + igt_display_commit(&display);
> igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
> run_plane_test(&display, pipe, output, test_setplane, DRM_PLANE_TYPE_CURSOR);
> break;
> --
> 2.36.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-26 18:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-26 3:49 [igt-dev] [PATCH i-g-t] tests/kms_atomic_interruptible: Test Cleanup Nidhi Gupta
2022-08-26 4:00 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
2022-08-26 18:21 ` [igt-dev] [PATCH i-g-t] " Jessica Zhang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.