* [PATCH] watchdog: rti-wdt: Fix pm_runtime_get_sync() error checking
@ 2022-04-12 7:08 Miaoqian Lin
2022-04-12 14:18 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-04-12 7:08 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Tero Kristo, linux-watchdog,
linux-kernel
Cc: linmq006
If the device is already in a runtime PM enabled state
pm_runtime_get_sync() will return 1, so a test for negative
value should be used to check for errors.
Fixes: 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/watchdog/rti_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c
index db843f825860..00ebeffc674f 100644
--- a/drivers/watchdog/rti_wdt.c
+++ b/drivers/watchdog/rti_wdt.c
@@ -226,7 +226,7 @@ static int rti_wdt_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
ret = pm_runtime_get_sync(dev);
- if (ret) {
+ if (ret < 0) {
pm_runtime_put_noidle(dev);
pm_runtime_disable(&pdev->dev);
return dev_err_probe(dev, ret, "runtime pm failed\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: rti-wdt: Fix pm_runtime_get_sync() error checking
2022-04-12 7:08 [PATCH] watchdog: rti-wdt: Fix pm_runtime_get_sync() error checking Miaoqian Lin
@ 2022-04-12 14:18 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2022-04-12 14:18 UTC (permalink / raw)
To: Miaoqian Lin, Wim Van Sebroeck, Tero Kristo, linux-watchdog,
linux-kernel
On 4/12/22 00:08, Miaoqian Lin wrote:
> If the device is already in a runtime PM enabled state
> pm_runtime_get_sync() will return 1, so a test for negative
> value should be used to check for errors.
>
> Fixes: 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/rti_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c
> index db843f825860..00ebeffc674f 100644
> --- a/drivers/watchdog/rti_wdt.c
> +++ b/drivers/watchdog/rti_wdt.c
> @@ -226,7 +226,7 @@ static int rti_wdt_probe(struct platform_device *pdev)
>
> pm_runtime_enable(dev);
> ret = pm_runtime_get_sync(dev);
> - if (ret) {
> + if (ret < 0) {
> pm_runtime_put_noidle(dev);
> pm_runtime_disable(&pdev->dev);
> return dev_err_probe(dev, ret, "runtime pm failed\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-12 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 7:08 [PATCH] watchdog: rti-wdt: Fix pm_runtime_get_sync() error checking Miaoqian Lin
2022-04-12 14:18 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.