All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] spi-nor: Add Winbond w25q512jv
@ 2017-06-20  6:20 Joel Stanley
  2017-06-20  7:23 ` Marek Vasut
  2017-06-20  7:58 ` Cyrille Pitchen
  0 siblings, 2 replies; 7+ messages in thread
From: Joel Stanley @ 2017-06-20  6:20 UTC (permalink / raw)
  To: Cyrille Pitchen, Marek Vasut
  Cc: Benjamin Herrenschmidt, linux-mtd, Cédric Le Goater

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Similar to the other ones, different size. The "JV" suffix is in
the datasheet, I haven't seen mentions of a different one.

The the datasheet indicates DUAL and QUAD are supported.

http://www.winbond.com/resource-files/w25m512jv%20revc%2001062017.pdf

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
v3:
 - Added the DUAL and QUAD flags for ben. Tested with aspeed-smc driver.

 drivers/mtd/spi-nor/spi-nor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index eef55b597ec7..ad46dc82c8d1 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1146,6 +1146,8 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "w25q80bl", INFO(0xef4014, 0, 64 * 1024,  16, SECT_4K) },
 	{ "w25q128", INFO(0xef4018, 0, 64 * 1024, 256, SECT_4K) },
 	{ "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K) },
+	{ "w25q512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
+			SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
 
 	/* Catalyst / On Semiconductor -- non-JEDEC */
 	{ "cat25c11", CAT25_INFO(  16, 8, 16, 1, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] spi-nor: Add Winbond w25q512jv
  2017-06-20  6:20 [PATCH v3] spi-nor: Add Winbond w25q512jv Joel Stanley
@ 2017-06-20  7:23 ` Marek Vasut
  2017-06-20  9:08   ` Benjamin Herrenschmidt
  2017-06-20  7:58 ` Cyrille Pitchen
  1 sibling, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2017-06-20  7:23 UTC (permalink / raw)
  To: Joel Stanley, Cyrille Pitchen
  Cc: Benjamin Herrenschmidt, linux-mtd, Cédric Le Goater

On 06/20/2017 08:20 AM, Joel Stanley wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> 
> Similar to the other ones, different size. The "JV" suffix is in
> the datasheet, I haven't seen mentions of a different one.
> 
> The the datasheet indicates DUAL and QUAD are supported.
> 
> http://www.winbond.com/resource-files/w25m512jv%20revc%2001062017.pdf

The datasheet says W25M512 not W25Q512.
                      ^-----------^-------- different letter here.

> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v3:
>  - Added the DUAL and QUAD flags for ben. Tested with aspeed-smc driver.
> 
>  drivers/mtd/spi-nor/spi-nor.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index eef55b597ec7..ad46dc82c8d1 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1146,6 +1146,8 @@ static const struct flash_info spi_nor_ids[] = {
>  	{ "w25q80bl", INFO(0xef4014, 0, 64 * 1024,  16, SECT_4K) },
>  	{ "w25q128", INFO(0xef4018, 0, 64 * 1024, 256, SECT_4K) },
>  	{ "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K) },
> +	{ "w25q512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> +			SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
>  
>  	/* Catalyst / On Semiconductor -- non-JEDEC */
>  	{ "cat25c11", CAT25_INFO(  16, 8, 16, 1, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
> 


-- 
Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] spi-nor: Add Winbond w25q512jv
  2017-06-20  6:20 [PATCH v3] spi-nor: Add Winbond w25q512jv Joel Stanley
  2017-06-20  7:23 ` Marek Vasut
@ 2017-06-20  7:58 ` Cyrille Pitchen
  1 sibling, 0 replies; 7+ messages in thread
From: Cyrille Pitchen @ 2017-06-20  7:58 UTC (permalink / raw)
  To: Joel Stanley, Marek Vasut
  Cc: Benjamin Herrenschmidt, linux-mtd, Cédric Le Goater

Hi all,

Le 20/06/2017 à 08:20, Joel Stanley a écrit :
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> 
> Similar to the other ones, different size. The "JV" suffix is in
> the datasheet, I haven't seen mentions of a different one.
> 
> The the datasheet indicates DUAL and QUAD are supported.
> 
> http://www.winbond.com/resource-files/w25m512jv%20revc%2001062017.pdf
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v3:
>  - Added the DUAL and QUAD flags for ben. Tested with aspeed-smc driver.
> 
>  drivers/mtd/spi-nor/spi-nor.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index eef55b597ec7..ad46dc82c8d1 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1146,6 +1146,8 @@ static const struct flash_info spi_nor_ids[] = {
>  	{ "w25q80bl", INFO(0xef4014, 0, 64 * 1024,  16, SECT_4K) },
>  	{ "w25q128", INFO(0xef4018, 0, 64 * 1024, 256, SECT_4K) },
>  	{ "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K) },
> +	{ "w25q512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> +			SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
>

This looks good, I'll try to apply it this evening.

Best regards,

Cyrille

>  	/* Catalyst / On Semiconductor -- non-JEDEC */
>  	{ "cat25c11", CAT25_INFO(  16, 8, 16, 1, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] spi-nor: Add Winbond w25q512jv
  2017-06-20  7:23 ` Marek Vasut
@ 2017-06-20  9:08   ` Benjamin Herrenschmidt
  2017-06-20  9:22     ` Marek Vasut
  0 siblings, 1 reply; 7+ messages in thread
From: Benjamin Herrenschmidt @ 2017-06-20  9:08 UTC (permalink / raw)
  To: Marek Vasut, Joel Stanley, Cyrille Pitchen
  Cc: linux-mtd, Cédric Le Goater

On Tue, 2017-06-20 at 09:23 +0200, Marek Vasut wrote:
> On 06/20/2017 08:20 AM, Joel Stanley wrote:
> > From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > 
> > Similar to the other ones, different size. The "JV" suffix is in
> > the datasheet, I haven't seen mentions of a different one.
> > 
> > The the datasheet indicates DUAL and QUAD are supported.
> > 
> > http://www.winbond.com/resource-files/w25m512jv%20revc%2001062017.pdf
> 
> The datasheet says W25M512 not W25Q512.
>                       ^-----------^-------- different letter here.

Page 23 mentions the "Q" version which is what we have.

Cheers,
Ben.

> 
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > ---
> > v3:
> >  - Added the DUAL and QUAD flags for ben. Tested with aspeed-smc driver.
> > 
> >  drivers/mtd/spi-nor/spi-nor.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index eef55b597ec7..ad46dc82c8d1 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -1146,6 +1146,8 @@ static const struct flash_info spi_nor_ids[] = {
> >  	{ "w25q80bl", INFO(0xef4014, 0, 64 * 1024,  16, SECT_4K) },
> >  	{ "w25q128", INFO(0xef4018, 0, 64 * 1024, 256, SECT_4K) },
> >  	{ "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K) },
> > +	{ "w25q512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> > +			SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> >  
> >  	/* Catalyst / On Semiconductor -- non-JEDEC */
> >  	{ "cat25c11", CAT25_INFO(  16, 8, 16, 1, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
> > 
> 
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] spi-nor: Add Winbond w25q512jv
  2017-06-20  9:08   ` Benjamin Herrenschmidt
@ 2017-06-20  9:22     ` Marek Vasut
  2017-06-20  9:45       ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2017-06-20  9:22 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Joel Stanley, Cyrille Pitchen
  Cc: linux-mtd, Cédric Le Goater

On 06/20/2017 11:08 AM, Benjamin Herrenschmidt wrote:
> On Tue, 2017-06-20 at 09:23 +0200, Marek Vasut wrote:
>> On 06/20/2017 08:20 AM, Joel Stanley wrote:
>>> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>>
>>> Similar to the other ones, different size. The "JV" suffix is in
>>> the datasheet, I haven't seen mentions of a different one.
>>>
>>> The the datasheet indicates DUAL and QUAD are supported.
>>>
>>> http://www.winbond.com/resource-files/w25m512jv%20revc%2001062017.pdf
>>
>> The datasheet says W25M512 not W25Q512.
>>                       ^-----------^-------- different letter here.
> 
> Page 23 mentions the "Q" version which is what we have.

So the M means "Multiple Q dies on single package" ? Why don't you use
w25m in the patch then ?

> Cheers,
> Ben.
> 
>>
>>> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>>> ---
>>> v3:
>>>  - Added the DUAL and QUAD flags for ben. Tested with aspeed-smc driver.
>>>
>>>  drivers/mtd/spi-nor/spi-nor.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>>> index eef55b597ec7..ad46dc82c8d1 100644
>>> --- a/drivers/mtd/spi-nor/spi-nor.c
>>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>>> @@ -1146,6 +1146,8 @@ static const struct flash_info spi_nor_ids[] = {
>>>  	{ "w25q80bl", INFO(0xef4014, 0, 64 * 1024,  16, SECT_4K) },
>>>  	{ "w25q128", INFO(0xef4018, 0, 64 * 1024, 256, SECT_4K) },
>>>  	{ "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K) },
>>> +	{ "w25q512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
>>> +			SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
>>>  
>>>  	/* Catalyst / On Semiconductor -- non-JEDEC */
>>>  	{ "cat25c11", CAT25_INFO(  16, 8, 16, 1, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
>>>
>>
>>


-- 
Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] spi-nor: Add Winbond w25q512jv
  2017-06-20  9:22     ` Marek Vasut
@ 2017-06-20  9:45       ` Benjamin Herrenschmidt
  2017-06-20  9:55         ` Marek Vasut
  0 siblings, 1 reply; 7+ messages in thread
From: Benjamin Herrenschmidt @ 2017-06-20  9:45 UTC (permalink / raw)
  To: Marek Vasut, Joel Stanley, Cyrille Pitchen
  Cc: linux-mtd, Cédric Le Goater

On Tue, 2017-06-20 at 11:22 +0200, Marek Vasut wrote:
> On 06/20/2017 11:08 AM, Benjamin Herrenschmidt wrote:
> > On Tue, 2017-06-20 at 09:23 +0200, Marek Vasut wrote:
> > > On 06/20/2017 08:20 AM, Joel Stanley wrote:
> > > > From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > > 
> > > > Similar to the other ones, different size. The "JV" suffix is in
> > > > the datasheet, I haven't seen mentions of a different one.
> > > > 
> > > > The the datasheet indicates DUAL and QUAD are supported.
> > > > 
> > > > http://www.winbond.com/resource-files/w25m512jv%20revc%2001062017.pdf
> > > 
> > > The datasheet says W25M512 not W25Q512.
> > >                       ^-----------^-------- different letter here.
> > 
> > Page 23 mentions the "Q" version which is what we have.
> 
> So the M means "Multiple Q dies on single package" ? Why don't you use
> w25m in the patch then ?

Because I messed up :-) I got confused between "Q256" and "M512"...

The ID for a single W25Q256JV 0x184019 which we already have
The ID for the dual W25Q256JV aka W25M512JV is 0x187119

Sorry for the mess.

Joel, can you respin ? I don't have my stuff at hand and I'm flying out
tomorrow.

Thanks !

Cheers,
Ben.

> > Cheers,
> > Ben.
> > 
> > > 
> > > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > > > ---
> > > > v3:
> > > >  - Added the DUAL and QUAD flags for ben. Tested with aspeed-smc driver.
> > > > 
> > > >  drivers/mtd/spi-nor/spi-nor.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > > > index eef55b597ec7..ad46dc82c8d1 100644
> > > > --- a/drivers/mtd/spi-nor/spi-nor.c
> > > > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > > > @@ -1146,6 +1146,8 @@ static const struct flash_info spi_nor_ids[] = {
> > > >  	{ "w25q80bl", INFO(0xef4014, 0, 64 * 1024,  16, SECT_4K) },
> > > >  	{ "w25q128", INFO(0xef4018, 0, 64 * 1024, 256, SECT_4K) },
> > > >  	{ "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K) },
> > > > +	{ "w25q512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> > > > +			SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> > > >  
> > > >  	/* Catalyst / On Semiconductor -- non-JEDEC */
> > > >  	{ "cat25c11", CAT25_INFO(  16, 8, 16, 1, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
> > > > 
> > > 
> > > 
> 
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] spi-nor: Add Winbond w25q512jv
  2017-06-20  9:45       ` Benjamin Herrenschmidt
@ 2017-06-20  9:55         ` Marek Vasut
  0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2017-06-20  9:55 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Joel Stanley, Cyrille Pitchen
  Cc: linux-mtd, Cédric Le Goater

On 06/20/2017 11:45 AM, Benjamin Herrenschmidt wrote:
> On Tue, 2017-06-20 at 11:22 +0200, Marek Vasut wrote:
>> On 06/20/2017 11:08 AM, Benjamin Herrenschmidt wrote:
>>> On Tue, 2017-06-20 at 09:23 +0200, Marek Vasut wrote:
>>>> On 06/20/2017 08:20 AM, Joel Stanley wrote:
>>>>> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>>>>
>>>>> Similar to the other ones, different size. The "JV" suffix is in
>>>>> the datasheet, I haven't seen mentions of a different one.
>>>>>
>>>>> The the datasheet indicates DUAL and QUAD are supported.
>>>>>
>>>>> http://www.winbond.com/resource-files/w25m512jv%20revc%2001062017.pdf
>>>>
>>>> The datasheet says W25M512 not W25Q512.
>>>>                       ^-----------^-------- different letter here.
>>>
>>> Page 23 mentions the "Q" version which is what we have.
>>
>> So the M means "Multiple Q dies on single package" ? Why don't you use
>> w25m in the patch then ?
> 
> Because I messed up :-) I got confused between "Q256" and "M512"...
> 
> The ID for a single W25Q256JV 0x184019 which we already have
> The ID for the dual W25Q256JV aka W25M512JV is 0x187119
> 
> Sorry for the mess.
> 
> Joel, can you respin ? I don't have my stuff at hand and I'm flying out
> tomorrow.
> 
> Thanks !

Great, thanks!

-- 
Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-06-20  9:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-20  6:20 [PATCH v3] spi-nor: Add Winbond w25q512jv Joel Stanley
2017-06-20  7:23 ` Marek Vasut
2017-06-20  9:08   ` Benjamin Herrenschmidt
2017-06-20  9:22     ` Marek Vasut
2017-06-20  9:45       ` Benjamin Herrenschmidt
2017-06-20  9:55         ` Marek Vasut
2017-06-20  7:58 ` Cyrille Pitchen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.