* [Buildroot] [PATCH 1/1] qt5: qt5websockets: install missing qml modules
@ 2018-04-11 12:40 Manfred Schlaegl
2018-04-16 15:48 ` Thomas Petazzoni
2018-05-01 6:52 ` Peter Korsgaard
0 siblings, 2 replies; 5+ messages in thread
From: Manfred Schlaegl @ 2018-04-11 12:40 UTC (permalink / raw)
To: buildroot
QML modules for QtWebSockets are located in /usr/qml/QtWebSockets since
Qt 5.5.
/usr/qml/Qt/WebSockets still exists for compatibility reasons, but
it contains only a qmldir file which points to ../../QtWebSockets/.
see also: http://doc.qt.io/qt-5.6/qtwebsockets-qmlmodule.html
Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
---
package/qt5/qt5websockets/qt5websockets.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/qt5/qt5websockets/qt5websockets.mk b/package/qt5/qt5websockets/qt5websockets.mk
index 4d9df9257b..c67db198db 100644
--- a/package/qt5/qt5websockets/qt5websockets.mk
+++ b/package/qt5/qt5websockets/qt5websockets.mk
@@ -41,6 +41,7 @@ endef
ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
define QT5WEBSOCKETS_INSTALL_TARGET_QMLS
cp -dpfr $(STAGING_DIR)/usr/qml/Qt/WebSockets $(TARGET_DIR)/usr/qml/Qt/
+ cp -dpfr $(STAGING_DIR)/usr/qml/QtWebSockets $(TARGET_DIR)/usr/qml/
endef
endif
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] qt5: qt5websockets: install missing qml modules
2018-04-11 12:40 [Buildroot] [PATCH 1/1] qt5: qt5websockets: install missing qml modules Manfred Schlaegl
@ 2018-04-16 15:48 ` Thomas Petazzoni
2018-04-16 16:06 ` Manfred Schlaegl
2018-05-01 6:52 ` Peter Korsgaard
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2018-04-16 15:48 UTC (permalink / raw)
To: buildroot
Hello,
Thanks for your contribution!
On Wed, 11 Apr 2018 14:40:37 +0200, Manfred Schlaegl wrote:
> QML modules for QtWebSockets are located in /usr/qml/QtWebSockets since
> Qt 5.5.
>
> /usr/qml/Qt/WebSockets still exists for compatibility reasons, but
> it contains only a qmldir file which points to ../../QtWebSockets/.
Does this mean we should remove the installation
of /usr/qml/Qt/WebSockets ?
I've applied your patch to master as-is, anyway. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] qt5: qt5websockets: install missing qml modules
2018-04-16 15:48 ` Thomas Petazzoni
@ 2018-04-16 16:06 ` Manfred Schlaegl
2018-04-16 16:30 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Manfred Schlaegl @ 2018-04-16 16:06 UTC (permalink / raw)
To: buildroot
Hi,
On 2018-04-16 17:48, Thomas Petazzoni wrote:
> Hello,
>
> Thanks for your contribution!
Thanks for maintaining ;-)
>
> On Wed, 11 Apr 2018 14:40:37 +0200, Manfred Schlaegl wrote:
>> QML modules for QtWebSockets are located in /usr/qml/QtWebSockets since
>> Qt 5.5.
>>
>> /usr/qml/Qt/WebSockets still exists for compatibility reasons, but
>> it contains only a qmldir file which points to ../../QtWebSockets/.
>
> Does this mean we should remove the installation
> of /usr/qml/Qt/WebSockets ?
Newer projects (since Qt5.5) use
{{{
import QtWebSockets 1.0
}}}
which translates to /usr/qml/QtWebSockets
-> This is, what was missing.
Older projects (prior Qt5.5) use
{{{
import Qt.WebSockets 1.0
}}}
which resolves to /usr/qml/Qt/WebSockets
-> We don't want to break them, so we have to keep /usr/qml/Qt/WebSockets.
In short: We have to keep it. ;-)
>
> I've applied your patch to master as-is, anyway. Thanks!
>
> Thomas
>
Thanks!
Best regards,
Manfred
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] qt5: qt5websockets: install missing qml modules
2018-04-16 16:06 ` Manfred Schlaegl
@ 2018-04-16 16:30 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-04-16 16:30 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 16 Apr 2018 18:06:39 +0200, Manfred Schlaegl wrote:
> -> We don't want to break them, so we have to keep /usr/qml/Qt/WebSockets.
>
> In short: We have to keep it. ;-)
ACK, thanks for the confirmation!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] qt5: qt5websockets: install missing qml modules
2018-04-11 12:40 [Buildroot] [PATCH 1/1] qt5: qt5websockets: install missing qml modules Manfred Schlaegl
2018-04-16 15:48 ` Thomas Petazzoni
@ 2018-05-01 6:52 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2018-05-01 6:52 UTC (permalink / raw)
To: buildroot
>>>>> "Manfred" == Manfred Schlaegl <manfred.schlaegl@ginzinger.com> writes:
> QML modules for QtWebSockets are located in /usr/qml/QtWebSockets since
> Qt 5.5.
> /usr/qml/Qt/WebSockets still exists for compatibility reasons, but
> it contains only a qmldir file which points to ../../QtWebSockets/.
> see also: http://doc.qt.io/qt-5.6/qtwebsockets-qmlmodule.html
> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
Committed to 2018.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-01 6:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-11 12:40 [Buildroot] [PATCH 1/1] qt5: qt5websockets: install missing qml modules Manfred Schlaegl
2018-04-16 15:48 ` Thomas Petazzoni
2018-04-16 16:06 ` Manfred Schlaegl
2018-04-16 16:30 ` Thomas Petazzoni
2018-05-01 6:52 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.