From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com> To: Mark Rutland <mark.rutland@arm.com> Cc: broonie@kernel.org, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 02/11] arm64: Make perf_callchain_kernel() use arch_stack_walk() Date: Sat, 23 Oct 2021 07:49:11 -0500 [thread overview] Message-ID: <4de6800b-54fc-a74d-598f-80fc40924976@linux.microsoft.com> (raw) In-Reply-To: <20211022181154.GM86184@C02TD0UTHF1T.local> On 10/22/21 1:11 PM, Mark Rutland wrote: > On Thu, Oct 14, 2021 at 09:58:38PM -0500, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com> >> >> Currently, perf_callchain_kernel() in ARM64 code walks the stack using >> start_backtrace() and walk_stackframe(). Make it use arch_stack_walk() >> instead. This makes maintenance easier. >> >> Signed-off-by: Madhavan T. Venkataraman <madvenka@linux.microsoft.com> > > This looks good to me; bailing out when perf_callchain_store() can't > accept any more entries absolutely makes sense. > > I gave this a spin with: > > | # perf record -g -c1 ls > | # perf report > > ... and the recorded callchains look sane. > > Reviewed-by: Mark Rutland <mark.rutland@arm.com> > Tested-by: Mark Rutland <mark.rutland@arm.com> > Thanks a lot! > As mentioned on patch 1, I'd like to get this rebased atop Peter's > untangling of ARCH_STACKWALK from STACKTRACE. > Will do. Thanks. Madhavan
WARNING: multiple messages have this Message-ID (diff)
From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com> To: Mark Rutland <mark.rutland@arm.com> Cc: broonie@kernel.org, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 02/11] arm64: Make perf_callchain_kernel() use arch_stack_walk() Date: Sat, 23 Oct 2021 07:49:11 -0500 [thread overview] Message-ID: <4de6800b-54fc-a74d-598f-80fc40924976@linux.microsoft.com> (raw) In-Reply-To: <20211022181154.GM86184@C02TD0UTHF1T.local> On 10/22/21 1:11 PM, Mark Rutland wrote: > On Thu, Oct 14, 2021 at 09:58:38PM -0500, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com> >> >> Currently, perf_callchain_kernel() in ARM64 code walks the stack using >> start_backtrace() and walk_stackframe(). Make it use arch_stack_walk() >> instead. This makes maintenance easier. >> >> Signed-off-by: Madhavan T. Venkataraman <madvenka@linux.microsoft.com> > > This looks good to me; bailing out when perf_callchain_store() can't > accept any more entries absolutely makes sense. > > I gave this a spin with: > > | # perf record -g -c1 ls > | # perf report > > ... and the recorded callchains look sane. > > Reviewed-by: Mark Rutland <mark.rutland@arm.com> > Tested-by: Mark Rutland <mark.rutland@arm.com> > Thanks a lot! > As mentioned on patch 1, I'd like to get this rebased atop Peter's > untangling of ARCH_STACKWALK from STACKTRACE. > Will do. Thanks. Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-23 12:49 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <c05ce30dcc9be1bd6b5e24a2ca8fe1d66246980b> 2021-10-15 2:34 ` [PATCH v9 00/11] arm64: Reorganize the unwinder and implement stack trace reliability checks madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:34 ` [PATCH v9 01/11] arm64: Select STACKTRACE in arch/arm64/Kconfig madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:34 ` [PATCH v9 10/11] arm64: Introduce stack trace reliability checks in the unwinder madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:34 ` [PATCH v9 11/11] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:34 ` [PATCH v9 02/11] arm64: Make perf_callchain_kernel() use arch_stack_walk() madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:34 ` [PATCH v9 03/11] arm64: Make get_wchan() " madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:34 ` [PATCH v9 04/11] arm64: Make return_address() " madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:34 ` [PATCH v9 05/11] arm64: Make dump_stacktrace() " madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:34 ` [PATCH v9 06/11] arm64: Make profile_pc() " madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:34 ` [PATCH v9 07/11] arm64: Call stack_backtrace() only from within walk_stackframe() madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:34 ` [PATCH v9 08/11] arm64: Rename unwinder functions, prevent them from being traced and kprobed madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:34 ` [PATCH v9 09/11] arm64: Make the unwind loop in unwind() similar to other architectures madvenka 2021-10-15 2:34 ` madvenka 2021-10-15 2:53 ` [PATCH v9 00/11] arm64: Reorganize the unwinder and implement stack trace reliability checks Madhavan T. Venkataraman 2021-10-15 2:53 ` Madhavan T. Venkataraman 2021-10-15 2:58 ` [PATCH v10 " madvenka 2021-10-15 2:58 ` madvenka 2021-10-15 2:58 ` [PATCH v10 01/11] arm64: Select STACKTRACE in arch/arm64/Kconfig madvenka 2021-10-15 2:58 ` madvenka 2021-10-15 18:28 ` Mark Brown 2021-10-15 18:28 ` Mark Brown 2021-10-21 12:28 ` Madhavan T. Venkataraman 2021-10-21 12:28 ` Madhavan T. Venkataraman 2021-10-22 18:02 ` Mark Rutland 2021-10-22 18:02 ` Mark Rutland 2021-11-12 17:44 ` Mark Rutland 2021-11-12 17:44 ` Mark Rutland 2021-11-14 16:15 ` Madhavan T. Venkataraman 2021-11-14 16:15 ` Madhavan T. Venkataraman 2021-10-15 2:58 ` [PATCH v10 02/11] arm64: Make perf_callchain_kernel() use arch_stack_walk() madvenka 2021-10-15 2:58 ` madvenka 2021-10-20 14:59 ` Mark Brown 2021-10-20 14:59 ` Mark Brown 2021-10-21 12:28 ` Madhavan T. Venkataraman 2021-10-21 12:28 ` Madhavan T. Venkataraman 2021-10-22 18:11 ` Mark Rutland 2021-10-22 18:11 ` Mark Rutland 2021-10-23 12:49 ` Madhavan T. Venkataraman [this message] 2021-10-23 12:49 ` Madhavan T. Venkataraman 2021-10-15 2:58 ` [PATCH v10 03/11] arm64: Make get_wchan() " madvenka 2021-10-15 2:58 ` madvenka 2021-10-20 16:10 ` Mark Brown 2021-10-20 16:10 ` Mark Brown 2021-10-21 12:30 ` Madhavan T. Venkataraman 2021-10-21 12:30 ` Madhavan T. Venkataraman 2021-10-15 2:58 ` [PATCH v10 04/11] arm64: Make return_address() " madvenka 2021-10-15 2:58 ` madvenka 2021-10-20 15:03 ` Mark Brown 2021-10-20 15:03 ` Mark Brown 2021-10-21 12:29 ` Madhavan T. Venkataraman 2021-10-21 12:29 ` Madhavan T. Venkataraman 2021-10-22 18:51 ` Mark Rutland 2021-10-22 18:51 ` Mark Rutland 2021-10-23 12:51 ` Madhavan T. Venkataraman 2021-10-23 12:51 ` Madhavan T. Venkataraman 2021-10-15 2:58 ` [PATCH v10 05/11] arm64: Make dump_stacktrace() " madvenka 2021-10-15 2:58 ` madvenka 2021-10-25 16:49 ` Mark Rutland 2021-10-25 16:49 ` Mark Rutland 2021-10-26 12:05 ` Mark Rutland 2021-10-26 12:05 ` Mark Rutland 2021-10-27 16:09 ` Madhavan T. Venkataraman 2021-10-27 16:09 ` Madhavan T. Venkataraman 2021-10-15 2:58 ` [PATCH v10 06/11] arm64: Make profile_pc() " madvenka 2021-10-15 2:58 ` madvenka 2021-10-25 2:18 ` nobuta.keiya 2021-10-25 2:18 ` nobuta.keiya 2021-10-27 16:10 ` Madhavan T. Venkataraman 2021-10-27 16:10 ` Madhavan T. Venkataraman 2021-10-27 13:32 ` Mark Rutland 2021-10-27 13:32 ` Mark Rutland 2021-10-27 16:15 ` Madhavan T. Venkataraman 2021-10-27 16:15 ` Madhavan T. Venkataraman 2021-10-15 2:58 ` [PATCH v10 07/11] arm64: Call stack_backtrace() only from within walk_stackframe() madvenka 2021-10-15 2:58 ` madvenka 2021-10-15 2:58 ` [PATCH v10 08/11] arm64: Rename unwinder functions, prevent them from being traced and kprobed madvenka 2021-10-15 2:58 ` madvenka 2021-10-27 17:53 ` Mark Rutland 2021-10-27 17:53 ` Mark Rutland 2021-10-27 20:07 ` Madhavan T. Venkataraman 2021-10-27 20:07 ` Madhavan T. Venkataraman 2021-10-15 2:58 ` [PATCH v10 09/11] arm64: Make the unwind loop in unwind() similar to other architectures madvenka 2021-10-15 2:58 ` madvenka 2021-10-15 2:58 ` [PATCH v10 10/11] arm64: Introduce stack trace reliability checks in the unwinder madvenka 2021-10-15 2:58 ` madvenka 2021-11-04 12:39 ` nobuta.keiya 2021-11-04 12:39 ` nobuta.keiya 2021-11-10 3:13 ` Madhavan T. Venkataraman 2021-11-10 3:13 ` Madhavan T. Venkataraman 2021-10-15 2:58 ` [PATCH v10 11/11] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka 2021-10-15 2:58 ` madvenka 2021-10-15 17:00 ` [PATCH v10 00/11] arm64: Reorganize the unwinder and implement stack trace reliability checks Madhavan T. Venkataraman 2021-10-15 17:00 ` Madhavan T. Venkataraman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4de6800b-54fc-a74d-598f-80fc40924976@linux.microsoft.com \ --to=madvenka@linux.microsoft.com \ --cc=ardb@kernel.org \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=jmorris@namei.org \ --cc=jpoimboe@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=live-patching@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nobuta.keiya@fujitsu.com \ --cc=sjitindarsingh@gmail.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.