From: "zhengbin (A)" <zhengbin13@huawei.com>
To: <bfields@fieldses.org>, <jlayton@kernel.org>,
<linux-nfs@vger.kernel.org>
Cc: <houtao1@huawei.com>, <zhaohongjiang@huawei.com>
Subject: Re: [PATCH] nfsd: Return EPERM on utime/utimes/lutimes calls instead of EACCESS in some cases
Date: Mon, 3 Dec 2018 16:36:27 +0800 [thread overview]
Message-ID: <4e0152c4-bbe9-4246-27ee-bae2fee9129d@huawei.com> (raw)
In-Reply-To: <1543564290-147370-1-git-send-email-zhengbin13@huawei.com>
hi, J. Bruce Fields, Jeff Layton
When you have time, confirm it? thanks
On 2018/11/30 15:51, zhengbin wrote:
> As the man(3) page for utime/utimes/lutimes, EPERM is returned
> when the second parameter of utime/utimes/lutimes is not NULL,
> the caller's effective UID does not match the owner of the file,
> and the caller is not privileged.
>
> However, in a NFS directory, it will return EACCESS(nfsd_setattr->
> fh_verify->nfsd_permission), This patch fix this.
>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
> fs/nfsd/vfs.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index eb67098..9824e32 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -396,10 +396,23 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap,
> bool get_write_count;
> bool size_change = (iap->ia_valid & ATTR_SIZE);
>
> - if (iap->ia_valid & (ATTR_ATIME | ATTR_MTIME | ATTR_SIZE))
> + if (iap->ia_valid & ATTR_SIZE) {
> accmode |= NFSD_MAY_WRITE|NFSD_MAY_OWNER_OVERRIDE;
> - if (iap->ia_valid & ATTR_SIZE)
> ftype = S_IFREG;
> + }
> +
> + /*
> + * If utimes(2) and friends are called with times not NULL, we should
> + * not set NFSD_MAY_WRITE bit. Otherwise fh_verify->nfsd_permission
> + * will return EACCESS, when the caller's effective UID does not match
> + * the owner of the file, and the caller is not privileged. In this
> + * situation, we should return EPERM(notify_change will return this).
> + */
> + if (iap->ia_valid & (ATTR_ATIME | ATTR_MTIME)) {
> + accmode |= NFSD_MAY_OWNER_OVERRIDE;
> + if (!(iap->ia_valid & (ATTR_ATIME_SET | ATTR_MTIME_SET)))
> + accmode |= NFSD_MAY_WRITE;
> + }
>
> /* Callers that do fh_verify should do the fh_want_write: */
> get_write_count = !fhp->fh_dentry;
> --
> 2.7.4
>
>
> .
>
next prev parent reply other threads:[~2018-12-03 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 7:51 [PATCH] nfsd: Return EPERM on utime/utimes/lutimes calls instead of EACCESS in some cases zhengbin
2018-12-03 8:36 ` zhengbin (A) [this message]
2018-12-04 20:13 ` J. Bruce Fields
2018-12-05 1:04 ` zhengbin (A)
2018-12-05 1:37 ` J. Bruce Fields
2018-12-05 1:43 ` zhengbin (A)
2018-12-05 1:49 ` J. Bruce Fields
2018-11-30 8:04 zhengbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0152c4-bbe9-4246-27ee-bae2fee9129d@huawei.com \
--to=zhengbin13@huawei.com \
--cc=bfields@fieldses.org \
--cc=houtao1@huawei.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.