From: Sekhar Nori <nsekhar@ti.com>
To: Peter Rosin <peda@axentia.se>, <linux-kernel@vger.kernel.org>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Brian Norris <computersforpeace@gmail.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
<bcm-kernel-feedback-list@broadcom.com>,
Kevin Hilman <khilman@kernel.org>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linaro.org>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>,
Guenter Roeck <linux@roeck-us.net>, Crt Mori <cmo@melexis.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Antti Palosaari <crope@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Michael Krufky <mkrufky@linuxtv.org>,
Lee Jones <lee.jones@linaro.org>,
<linux-integrity@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<linux-input@vger.kernel.org>, <linux-media@vger.kernel.org>
Subject: Re: [PATCH v2 10/10] i2c: remove i2c_lock_adapter and use i2c_lock_bus directly
Date: Tue, 26 Jun 2018 19:39:43 +0530 [thread overview]
Message-ID: <4e0545e3-fee9-cf29-bae1-e442347e3cb8@ti.com> (raw)
In-Reply-To: <20180620051803.12206-11-peda@axentia.se>
On Wednesday 20 June 2018 10:48 AM, Peter Rosin wrote:
> The i2c_lock_adapter name is ambiguous since it is unclear if it
> refers to the root adapter or the adapter you name in the argument.
> The natural interpretation is the adapter you name in the argument,
> but there are historical reasons for that not being the case; it
> in fact locks the root adapter. Just remove the function and force
> users to spell out the I2C_LOCK_ROOT_ADAPTER name to indicate what
> is really going on. Also remove i2c_unlock_adapter, of course.
>
> This patch was generated with
>
> git grep -l 'i2c_\(un\)\?lock_adapter' \
> | xargs sed -i 's/i2c_\(un\)\?lock_adapter(\([^)]*\))/'\
> 'i2c_\1lock_bus(\2, I2C_LOCK_ROOT_ADAPTER)/g'
>
> followed by white-space touch-up.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> drivers/i2c/busses/i2c-brcmstb.c | 8 ++++----
> drivers/i2c/busses/i2c-davinci.c | 4 ++--
On DM644x and DA850 EVMs applying this series does not seem to break I2C
functionality. So:
Tested-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Peter Rosin <peda@axentia.se>, linux-kernel@vger.kernel.org
Cc: Crt Mori <cmo@melexis.com>, Wolfram Sang <wsa@the-dreams.de>,
linux-iio@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
linux-i2c@vger.kernel.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Peter Huewe <peterhuewe@gmx.de>,
Michael Krufky <mkrufky@linuxtv.org>,
Lee Jones <lee.jones@linaro.org>, Antti Palosaari <crope@iki.fi>,
linux-samsung-soc@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Kevin Hilman <khilman@kernel.org>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Kukjin Kim <kgene@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-input@vger.kernel.org, Orson Zhai <orsonzhai@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-media@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Grego
Subject: Re: [PATCH v2 10/10] i2c: remove i2c_lock_adapter and use i2c_lock_bus directly
Date: Tue, 26 Jun 2018 19:39:43 +0530 [thread overview]
Message-ID: <4e0545e3-fee9-cf29-bae1-e442347e3cb8@ti.com> (raw)
In-Reply-To: <20180620051803.12206-11-peda@axentia.se>
On Wednesday 20 June 2018 10:48 AM, Peter Rosin wrote:
> The i2c_lock_adapter name is ambiguous since it is unclear if it
> refers to the root adapter or the adapter you name in the argument.
> The natural interpretation is the adapter you name in the argument,
> but there are historical reasons for that not being the case; it
> in fact locks the root adapter. Just remove the function and force
> users to spell out the I2C_LOCK_ROOT_ADAPTER name to indicate what
> is really going on. Also remove i2c_unlock_adapter, of course.
>
> This patch was generated with
>
> git grep -l 'i2c_\(un\)\?lock_adapter' \
> | xargs sed -i 's/i2c_\(un\)\?lock_adapter(\([^)]*\))/'\
> 'i2c_\1lock_bus(\2, I2C_LOCK_ROOT_ADAPTER)/g'
>
> followed by white-space touch-up.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> drivers/i2c/busses/i2c-brcmstb.c | 8 ++++----
> drivers/i2c/busses/i2c-davinci.c | 4 ++--
On DM644x and DA850 EVMs applying this series does not seem to break I2C
functionality. So:
Tested-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 10/10] i2c: remove i2c_lock_adapter and use i2c_lock_bus directly
Date: Tue, 26 Jun 2018 19:39:43 +0530 [thread overview]
Message-ID: <4e0545e3-fee9-cf29-bae1-e442347e3cb8@ti.com> (raw)
In-Reply-To: <20180620051803.12206-11-peda@axentia.se>
On Wednesday 20 June 2018 10:48 AM, Peter Rosin wrote:
> The i2c_lock_adapter name is ambiguous since it is unclear if it
> refers to the root adapter or the adapter you name in the argument.
> The natural interpretation is the adapter you name in the argument,
> but there are historical reasons for that not being the case; it
> in fact locks the root adapter. Just remove the function and force
> users to spell out the I2C_LOCK_ROOT_ADAPTER name to indicate what
> is really going on. Also remove i2c_unlock_adapter, of course.
>
> This patch was generated with
>
> git grep -l 'i2c_\(un\)\?lock_adapter' \
> | xargs sed -i 's/i2c_\(un\)\?lock_adapter(\([^)]*\))/'\
> 'i2c_\1lock_bus(\2, I2C_LOCK_ROOT_ADAPTER)/g'
>
> followed by white-space touch-up.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> drivers/i2c/busses/i2c-brcmstb.c | 8 ++++----
> drivers/i2c/busses/i2c-davinci.c | 4 ++--
On DM644x and DA850 EVMs applying this series does not seem to break I2C
functionality. So:
Tested-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
next prev parent reply other threads:[~2018-06-26 14:11 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 5:17 [PATCH v2 00/10] Split i2c_lock_adapter into i2c_lock_root and i2c_lock_segment Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:17 ` [PATCH v2 01/10] tpm/tpm_i2c_infineon: switch to i2c_lock_bus(..., I2C_LOCK_SEGMENT) Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-25 10:24 ` Jarkko Sakkinen
2018-06-25 10:24 ` Jarkko Sakkinen
2018-06-25 10:24 ` Jarkko Sakkinen
2018-06-26 10:07 ` Alexander Steffen
2018-06-26 10:07 ` Alexander Steffen
2018-06-26 10:07 ` Alexander Steffen
2018-06-26 12:05 ` Jarkko Sakkinen
2018-06-26 12:05 ` Jarkko Sakkinen
2018-06-26 12:05 ` Jarkko Sakkinen
2018-06-26 12:05 ` Jarkko Sakkinen
2018-06-26 12:07 ` Jarkko Sakkinen
2018-06-26 12:07 ` Jarkko Sakkinen
2018-06-26 12:07 ` Jarkko Sakkinen
2018-06-26 12:07 ` Jarkko Sakkinen
2018-06-20 5:17 ` [PATCH v2 02/10] i2c: mux: pca9541: " Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:17 ` [PATCH v2 03/10] input: rohm_bu21023: " Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 20:28 ` Dmitry Torokhov
2018-06-20 20:28 ` Dmitry Torokhov
2018-06-20 20:28 ` Dmitry Torokhov
2018-06-20 5:17 ` [PATCH v2 04/10] media: af9013: " Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:17 ` [PATCH v2 05/10] media: drxk_hard: " Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:17 ` [PATCH v2 06/10] media: rtl2830: " Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:17 ` Peter Rosin
2018-06-20 5:18 ` [PATCH v2 07/10] media: tda1004x: " Peter Rosin
2018-06-20 5:18 ` Peter Rosin
2018-06-20 5:18 ` Peter Rosin
2018-06-20 5:18 ` [PATCH v2 08/10] media: tda18271: " Peter Rosin
2018-06-20 5:18 ` Peter Rosin
2018-06-20 5:18 ` Peter Rosin
2018-06-20 5:18 ` [PATCH v2 09/10] mfd: 88pm860x-i2c: " Peter Rosin
2018-06-20 5:18 ` Peter Rosin
2018-06-20 5:18 ` Peter Rosin
2018-07-04 7:04 ` Lee Jones
2018-07-04 7:04 ` Lee Jones
2018-07-04 7:04 ` Lee Jones
2018-07-04 7:04 ` Lee Jones
2018-06-20 5:18 ` [PATCH v2 10/10] i2c: remove i2c_lock_adapter and use i2c_lock_bus directly Peter Rosin
2018-06-20 5:18 ` Peter Rosin
2018-06-20 5:18 ` Peter Rosin
2018-06-26 8:28 ` Jonathan Cameron
2018-06-26 8:28 ` Jonathan Cameron
2018-06-26 8:28 ` Jonathan Cameron
2018-06-26 14:09 ` Sekhar Nori [this message]
2018-06-26 14:09 ` Sekhar Nori
2018-06-26 14:09 ` Sekhar Nori
2018-06-26 2:37 ` [PATCH v2 00/10] Split i2c_lock_adapter into i2c_lock_root and i2c_lock_segment Wolfram Sang
2018-06-26 2:37 ` Wolfram Sang
2018-06-26 2:37 ` Wolfram Sang
2018-07-12 21:28 ` Wolfram Sang
2018-07-12 21:28 ` Wolfram Sang
2018-07-12 21:28 ` Wolfram Sang
2018-07-12 21:28 ` Wolfram Sang
2018-07-12 21:59 ` Mauro Carvalho Chehab
2018-07-12 21:59 ` Mauro Carvalho Chehab
2018-07-12 21:59 ` Mauro Carvalho Chehab
2018-07-12 22:11 ` Wolfram Sang
2018-07-12 22:11 ` Wolfram Sang
2018-07-12 22:11 ` Wolfram Sang
2018-07-12 22:11 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0545e3-fee9-cf29-bae1-e442347e3cb8@ti.com \
--to=nsekhar@ti.com \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cmo@melexis.com \
--cc=computersforpeace@gmail.com \
--cc=crope@iki.fi \
--cc=dmitry.torokhov@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.0xf0@gmail.com \
--cc=hskinnemoen@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=jic23@kernel.org \
--cc=kgene@kernel.org \
--cc=khilman@kernel.org \
--cc=knaack.h@gmx.de \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=orsonzhai@gmail.com \
--cc=peda@axentia.se \
--cc=peterhuewe@gmx.de \
--cc=pmeerw@pmeerw.net \
--cc=wsa@the-dreams.de \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.