From: Richard Zhao <linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Cc: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: Re: [PATCH 1/4] i2c: imx: check busy bit when START/STOP Date: Fri, 2 Oct 2009 08:57:04 +0800 [thread overview] Message-ID: <4e090d470910011757g261c693ehdca40ce43ebee2ec@mail.gmail.com> (raw) In-Reply-To: <20091001163753.GA20103-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> On Fri, Oct 2, 2009 at 12:37 AM, Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote: >> > Ah, so 'make the driver work on i.MX51' is a good statement which should >> > be part of the commit message. >> Well, maybe I can mention it. >> But I think the good point is to present what you modified, not the side effect. > > It is not the side effect but the intention :) As no code is changed without a > need, the reason really should be in the patch description. No, it's not intention. I'm just trying to make the controller work in a right way. Without this patch, maybe some other fast cpus have problem too. I just tested mx31 and mx51. I will add "Without this patch, i2c on some fast SoCs (for example imx51) will not work". Is it ok for you? > >> Yes. But I don't have multi-master system. So I can't say that. >> The code is just taken from Freescale latest code. Without it, It >> could also cause a device error. I forget the details. Anyway, it >> doesn't make anything wrong. > > Do you know where the details are explained? No, I don't. I don't have device in hand now. If you have, could you please help do a simple test? Use hw to simulate multi-master system. Before execute xfer, you first pull down SDA, then pull down SDC. It simulates a START. and execute xfer to see whether IBB is set? Thanks Richard > > Regards, > > Wolfram > > -- > Pengutronix e.K. | Wolfram Sang | > Industrial Linux Solutions | http://www.pengutronix.de/ | > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAkrE2uEACgkQD27XaX1/VRumZQCeL4x9oaBKKjSKzJLlRrkfvvqg > nlEAoLpQdpI3TeKEvK13rs46kSZRDsZU > =7kM6 > -----END PGP SIGNATURE----- > >
WARNING: multiple messages have this Message-ID (diff)
From: linuxzsc@gmail.com (Richard Zhao) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/4] i2c: imx: check busy bit when START/STOP Date: Fri, 2 Oct 2009 08:57:04 +0800 [thread overview] Message-ID: <4e090d470910011757g261c693ehdca40ce43ebee2ec@mail.gmail.com> (raw) In-Reply-To: <20091001163753.GA20103@pengutronix.de> On Fri, Oct 2, 2009 at 12:37 AM, Wolfram Sang <w.sang@pengutronix.de> wrote: >> > Ah, so 'make the driver work on i.MX51' is a good statement which should >> > be part of the commit message. >> Well, maybe I can mention it. >> But I think the good point is to present what you modified, not the side effect. > > It is not the side effect but the intention :) As no code is changed without a > need, the reason really should be in the patch description. No, it's not intention. I'm just trying to make the controller work in a right way. Without this patch, maybe some other fast cpus have problem too. I just tested mx31 and mx51. I will add "Without this patch, i2c on some fast SoCs (for example imx51) will not work". Is it ok for you? > >> Yes. But I don't have multi-master system. So I can't say that. >> The code is just taken from Freescale latest code. Without it, It >> could also cause a device error. I forget the details. ?Anyway, it >> doesn't make anything wrong. > > Do you know where the details are explained? No, I don't. I don't have device in hand now. If you have, could you please help do a simple test? Use hw to simulate multi-master system. Before execute xfer, you first pull down SDA, then pull down SDC. It simulates a START. and execute xfer to see whether IBB is set? Thanks Richard > > Regards, > > ? Wolfram > > -- > Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | Wolfram Sang ? ? ? ? ? ? ? ?| > Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?| > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAkrE2uEACgkQD27XaX1/VRumZQCeL4x9oaBKKjSKzJLlRrkfvvqg > nlEAoLpQdpI3TeKEvK13rs46kSZRDsZU > =7kM6 > -----END PGP SIGNATURE----- > >
next prev parent reply other threads:[~2009-10-02 0:57 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-10-01 1:13 [PATCH 1/4] i2c: imx: check busy bit when START/STOP Richard Zhao 2009-10-01 1:13 ` Richard Zhao [not found] ` <1254359613-21210-1-git-send-email-linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2009-10-01 1:13 ` [PATCH 2/4] i2c: imx: only imx1 needs disable delay Richard Zhao 2009-10-01 1:13 ` Richard Zhao [not found] ` <1254359613-21210-2-git-send-email-linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2009-10-01 1:13 ` [PATCH 3/4] i2c: imx: add macros and printk to make debug easy Richard Zhao 2009-10-01 1:13 ` Richard Zhao [not found] ` <1254359613-21210-3-git-send-email-linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2009-10-01 1:13 ` [PATCH 4/4] i2c: imx: disable clock when it's possible to save power Richard Zhao 2009-10-01 1:13 ` Richard Zhao [not found] ` <1254359613-21210-4-git-send-email-linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2009-10-01 7:34 ` Sascha Hauer 2009-10-01 7:34 ` Sascha Hauer [not found] ` <20091001073434.GY27039-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2009-10-01 7:56 ` Richard Zhao 2009-10-01 7:56 ` Richard Zhao [not found] ` <4e090d470910010056n56bff9f4l1fec703c2dde9edf-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2009-10-01 8:00 ` Sascha Hauer 2009-10-01 8:00 ` Sascha Hauer 2009-10-04 12:30 ` Richard Zhao 2009-10-01 7:29 ` [PATCH 3/4] i2c: imx: add macros and printk to make debug easy Sascha Hauer 2009-10-01 7:29 ` Sascha Hauer [not found] ` <20091001072934.GX27039-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2009-10-01 8:01 ` Richard Zhao 2009-10-01 8:01 ` Richard Zhao [not found] ` <4e090d470910010101r6839cc9ax4fe84f04a1afbb00-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2009-10-01 8:26 ` Sascha Hauer 2009-10-01 8:26 ` Sascha Hauer [not found] ` <20091001082610.GB27039-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2009-10-01 9:30 ` Richard Zhao 2009-10-01 9:30 ` Richard Zhao 2009-10-04 12:23 ` Richard Zhao 2009-10-01 7:26 ` [PATCH 2/4] i2c: imx: only imx1 needs disable delay Sascha Hauer 2009-10-01 7:26 ` Sascha Hauer 2009-10-01 7:52 ` Richard Zhao 2009-10-01 7:52 ` Richard Zhao [not found] ` <4e090d470910010052k37a0a4eep6d436e45e6524234-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2009-10-01 7:57 ` Sascha Hauer 2009-10-01 7:57 ` Sascha Hauer 2009-10-01 8:03 ` [PATCH 1/4] i2c: imx: check busy bit when START/STOP Richard Zhao 2009-10-01 8:03 ` Richard Zhao [not found] ` <4e090d470910010103o611d9fb2t3acf93632216fc88-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2009-10-01 8:38 ` Sascha Hauer 2009-10-01 8:38 ` Sascha Hauer [not found] ` <20091001083831.GD27039-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2009-10-01 9:11 ` Richard Zhao 2009-10-01 9:11 ` Richard Zhao [not found] ` <4e090d470910010211k4ce78763i1a5163ec6ea57fe8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2009-10-01 9:52 ` Sascha Hauer 2009-10-01 9:52 ` Sascha Hauer [not found] ` <20091001095239.GE27039-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2009-10-01 14:54 ` Richard Zhao 2009-10-01 14:54 ` Richard Zhao [not found] ` <4e090d470910010754r1ebc4455u6220ccfd803491b0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2009-10-01 16:37 ` Wolfram Sang 2009-10-01 16:37 ` Wolfram Sang [not found] ` <20091001163753.GA20103-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2009-10-02 0:57 ` Richard Zhao [this message] 2009-10-02 0:57 ` Richard Zhao [not found] ` <4e090d470910011757g261c693ehdca40ce43ebee2ec-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2009-10-02 7:26 ` Sascha Hauer 2009-10-02 7:26 ` Sascha Hauer [not found] ` <20091002072643.GH27039-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2009-10-02 8:17 ` Richard Zhao 2009-10-02 8:17 ` Richard Zhao [not found] ` <4e090d470910020117w620fda4cta7b26b912d01bc24-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2009-10-02 14:11 ` Wolfram Sang 2009-10-02 14:11 ` Wolfram Sang 2009-10-04 12:22 ` Richard Zhao -- strict thread matches above, loose matches on Subject: below -- 2009-09-30 5:55 Richard Zhao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4e090d470910011757g261c693ehdca40ce43ebee2ec@mail.gmail.com \ --to=linuxzsc-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.