* [Buildroot] [PATCH] swupdate: requires shared library support
@ 2019-01-11 6:44 Baruch Siach
2019-01-11 8:01 ` [Buildroot] " James Hilliard
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2019-01-11 6:44 UTC (permalink / raw)
To: buildroot
Since version 2018.11 swupdate builds its lua binding as a shared
library unconditionally.
Fixes:
http://autobuild.buildroot.net/results/557/55767e58c211656558af7916a4e0975089a2785b/
http://autobuild.buildroot.net/results/073/07391b074a2fb16d2925320e16535e177a923089/
http://autobuild.buildroot.net/results/9e2/9e2b90b557576fd0b633a19b335ff1a7ee64ce69/
Cc: J?rg Krause <joerg.krause@embedded.rocks>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/swupdate/Config.in | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/package/swupdate/Config.in b/package/swupdate/Config.in
index ca2eaf294013..f208bd412095 100644
--- a/package/swupdate/Config.in
+++ b/package/swupdate/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_SWUPDATE
bool "swupdate"
depends on BR2_TOOLCHAIN_HAS_THREADS
+ depends on !BR2_STATIC_LIBS
depends on BR2_USE_MMU # fork()
# swupdate requires a parser and uses libconfig as default
select BR2_PACKAGE_LIBCONFIG if !BR2_PACKAGE_JSON_C && \
@@ -59,6 +60,6 @@ config BR2_PACKAGE_SWUPDATE_INSTALL_WEBSITE
installed to /var/www/swupdate.
endif
-comment "swupdate needs a toolchain w/ threads"
+comment "swupdate needs a toolchain w/ threads, dynamic library"
depends on BR2_USE_MMU
- depends on !BR2_TOOLCHAIN_HAS_THREADS
+ depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] swupdate: requires shared library support
2019-01-11 6:44 [Buildroot] [PATCH] swupdate: requires shared library support Baruch Siach
@ 2019-01-11 8:01 ` James Hilliard
2019-01-14 21:34 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: James Hilliard @ 2019-01-11 8:01 UTC (permalink / raw)
To: buildroot
On Thu, Jan 10, 2019 at 11:44 PM Baruch Siach <baruch@tkos.co.il> wrote:
>
> Since version 2018.11 swupdate builds its lua binding as a shared
> library unconditionally.
swupdate doesn't require lua so requiring static libs to build
swupdate doesn't seem to make sense.
>
> Fixes:
> http://autobuild.buildroot.net/results/557/55767e58c211656558af7916a4e0975089a2785b/
> http://autobuild.buildroot.net/results/073/07391b074a2fb16d2925320e16535e177a923089/
> http://autobuild.buildroot.net/results/9e2/9e2b90b557576fd0b633a19b335ff1a7ee64ce69/
>
> Cc: J?rg Krause <joerg.krause@embedded.rocks>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/swupdate/Config.in | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/package/swupdate/Config.in b/package/swupdate/Config.in
> index ca2eaf294013..f208bd412095 100644
> --- a/package/swupdate/Config.in
> +++ b/package/swupdate/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_SWUPDATE
> bool "swupdate"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> + depends on !BR2_STATIC_LIBS
This needs to only be required when swupdate is built with LUA enabled
in the swupdate config.
> depends on BR2_USE_MMU # fork()
> # swupdate requires a parser and uses libconfig as default
> select BR2_PACKAGE_LIBCONFIG if !BR2_PACKAGE_JSON_C && \
> @@ -59,6 +60,6 @@ config BR2_PACKAGE_SWUPDATE_INSTALL_WEBSITE
> installed to /var/www/swupdate.
> endif
>
> -comment "swupdate needs a toolchain w/ threads"
> +comment "swupdate needs a toolchain w/ threads, dynamic library"
> depends on BR2_USE_MMU
> - depends on !BR2_TOOLCHAIN_HAS_THREADS
> + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] swupdate: requires shared library support
2019-01-11 8:01 ` [Buildroot] " James Hilliard
@ 2019-01-14 21:34 ` Thomas Petazzoni
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-01-14 21:34 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 11 Jan 2019 01:01:11 -0700, James Hilliard wrote:
> On Thu, Jan 10, 2019 at 11:44 PM Baruch Siach <baruch@tkos.co.il> wrote:
> >
> > Since version 2018.11 swupdate builds its lua binding as a shared
> > library unconditionally.
> swupdate doesn't require lua so requiring static libs to build
> swupdate doesn't seem to make sense.
I guess this issue has been fixed by
https://git.buildroot.org/buildroot/commit/package/swupdate?id=b898b67209ff5c28f06d29b4e15ee671d6b64b0b.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-14 21:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 6:44 [Buildroot] [PATCH] swupdate: requires shared library support Baruch Siach
2019-01-11 8:01 ` [Buildroot] " James Hilliard
2019-01-14 21:34 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.