* [GIT PULL 0/1] KVM: s390: allow to compile without warning with W=1
@ 2021-09-30 12:54 Christian Borntraeger
2021-09-30 12:54 ` [GIT PULL 1/1] KVM: s390: Function documentation fixes Christian Borntraeger
2021-10-04 7:58 ` [GIT PULL 0/1] KVM: s390: allow to compile without warning with W=1 Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Christian Borntraeger @ 2021-09-30 12:54 UTC (permalink / raw)
To: Paolo Bonzini
Cc: KVM, Janosch Frank, Claudio Imbrenda, David Hildenbrand,
Cornelia Huck, linux-s390, Christian Borntraeger, Heiko Carstens,
Vasily Gorbik
Paolo,
please pull for kvm/master a fix for W=1.
The following changes since commit 5c49d1850ddd3240d20dc40b01f593e35a184f38:
KVM: VMX: Fix a TSX_CTRL_CPUID_CLEAR field mask issue (2021-09-27 11:25:40 -0400)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/kvm-s390-master-5.15-1
for you to fetch changes up to 25b5476a294cd5f7c7730f334f6b400d30bb783d:
KVM: s390: Function documentation fixes (2021-09-28 17:56:54 +0200)
----------------------------------------------------------------
KVM: s390: allow to compile without warning with W=1
----------------------------------------------------------------
Janosch Frank (1):
KVM: s390: Function documentation fixes
arch/s390/kvm/gaccess.c | 12 ++++++++++++
arch/s390/kvm/intercept.c | 4 +++-
2 files changed, 15 insertions(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [GIT PULL 1/1] KVM: s390: Function documentation fixes
2021-09-30 12:54 [GIT PULL 0/1] KVM: s390: allow to compile without warning with W=1 Christian Borntraeger
@ 2021-09-30 12:54 ` Christian Borntraeger
2021-10-04 7:58 ` [GIT PULL 0/1] KVM: s390: allow to compile without warning with W=1 Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Christian Borntraeger @ 2021-09-30 12:54 UTC (permalink / raw)
To: Paolo Bonzini
Cc: KVM, Janosch Frank, Claudio Imbrenda, David Hildenbrand,
Cornelia Huck, linux-s390, Christian Borntraeger, Heiko Carstens,
Vasily Gorbik
From: Janosch Frank <frankja@linux.ibm.com>
The latest compile changes pointed us to a few instances where we use
the kernel documentation style but don't explain all variables or
don't adhere to it 100%.
It's easy to fix so let's do that.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
arch/s390/kvm/gaccess.c | 12 ++++++++++++
arch/s390/kvm/intercept.c | 4 +++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/arch/s390/kvm/gaccess.c b/arch/s390/kvm/gaccess.c
index b9f85b2dc053..6af59c59cc1b 100644
--- a/arch/s390/kvm/gaccess.c
+++ b/arch/s390/kvm/gaccess.c
@@ -894,6 +894,11 @@ int access_guest_real(struct kvm_vcpu *vcpu, unsigned long gra,
/**
* guest_translate_address - translate guest logical into guest absolute address
+ * @vcpu: virtual cpu
+ * @gva: Guest virtual address
+ * @ar: Access register
+ * @gpa: Guest physical address
+ * @mode: Translation access mode
*
* Parameter semantics are the same as the ones from guest_translate.
* The memory contents at the guest address are not changed.
@@ -934,6 +939,11 @@ int guest_translate_address(struct kvm_vcpu *vcpu, unsigned long gva, u8 ar,
/**
* check_gva_range - test a range of guest virtual addresses for accessibility
+ * @vcpu: virtual cpu
+ * @gva: Guest virtual address
+ * @ar: Access register
+ * @length: Length of test range
+ * @mode: Translation access mode
*/
int check_gva_range(struct kvm_vcpu *vcpu, unsigned long gva, u8 ar,
unsigned long length, enum gacc_mode mode)
@@ -956,6 +966,7 @@ int check_gva_range(struct kvm_vcpu *vcpu, unsigned long gva, u8 ar,
/**
* kvm_s390_check_low_addr_prot_real - check for low-address protection
+ * @vcpu: virtual cpu
* @gra: Guest real address
*
* Checks whether an address is subject to low-address protection and set
@@ -979,6 +990,7 @@ int kvm_s390_check_low_addr_prot_real(struct kvm_vcpu *vcpu, unsigned long gra)
* @pgt: pointer to the beginning of the page table for the given address if
* successful (return value 0), or to the first invalid DAT entry in
* case of exceptions (return value > 0)
+ * @dat_protection: referenced memory is write protected
* @fake: pgt references contiguous guest memory block, not a pgtable
*/
static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr,
diff --git a/arch/s390/kvm/intercept.c b/arch/s390/kvm/intercept.c
index 72b25b7cc6ae..2bd8f854f1b4 100644
--- a/arch/s390/kvm/intercept.c
+++ b/arch/s390/kvm/intercept.c
@@ -269,6 +269,7 @@ static int handle_prog(struct kvm_vcpu *vcpu)
/**
* handle_external_interrupt - used for external interruption interceptions
+ * @vcpu: virtual cpu
*
* This interception only occurs if the CPUSTAT_EXT_INT bit was set, or if
* the new PSW does not have external interrupts disabled. In the first case,
@@ -315,7 +316,8 @@ static int handle_external_interrupt(struct kvm_vcpu *vcpu)
}
/**
- * Handle MOVE PAGE partial execution interception.
+ * handle_mvpg_pei - Handle MOVE PAGE partial execution interception.
+ * @vcpu: virtual cpu
*
* This interception can only happen for guests with DAT disabled and
* addresses that are currently not mapped in the host. Thus we try to
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [GIT PULL 0/1] KVM: s390: allow to compile without warning with W=1
2021-09-30 12:54 [GIT PULL 0/1] KVM: s390: allow to compile without warning with W=1 Christian Borntraeger
2021-09-30 12:54 ` [GIT PULL 1/1] KVM: s390: Function documentation fixes Christian Borntraeger
@ 2021-10-04 7:58 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-10-04 7:58 UTC (permalink / raw)
To: Christian Borntraeger
Cc: KVM, Janosch Frank, Claudio Imbrenda, David Hildenbrand,
Cornelia Huck, linux-s390, Heiko Carstens, Vasily Gorbik
On 30/09/21 14:54, Christian Borntraeger wrote:
> git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/kvm-s390-master-5.15-1
Pulled, thanks!
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-04 7:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 12:54 [GIT PULL 0/1] KVM: s390: allow to compile without warning with W=1 Christian Borntraeger
2021-09-30 12:54 ` [GIT PULL 1/1] KVM: s390: Function documentation fixes Christian Borntraeger
2021-10-04 7:58 ` [GIT PULL 0/1] KVM: s390: allow to compile without warning with W=1 Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.