From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Ralf Baechle <ralf@linux-mips.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Gerrit Renker <gerrit@erg.abdn.ac.uk>,
Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Andrew Hendry <andrew.hendry@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Willem de Bruijn <willemb@google.com>,
Deepa Dinamani <deepa.kernel@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hams@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-can@vger.kernel.org, dccp@vger.kernel.org,
linux-wpan@vger.kernel.org, linux-sctp@vger.kernel.org,
linux-x25@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling
Date: Wed, 17 Apr 2019 11:59:55 +0200 [thread overview]
Message-ID: <4eabda4b-d08e-ae29-b3df-0971e909fe9c@pengutronix.de> (raw)
In-Reply-To: <20190416203620.539628-1-arnd@arndb.de>
[-- Attachment #1.1: Type: text/plain, Size: 1449 bytes --]
On 4/16/19 10:32 PM, Arnd Bergmann wrote:
> The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many
> socket protocol handlers, and all of those end up calling the same
> sock_get_timestamp()/sock_get_timestampns() helper functions, which
> results in a lot of duplicate code.
>
> With the introduction of 64-bit time_t on 32-bit architectures, this
> gets worse, as we then need four different ioctl commands in each
> socket protocol implementation.
>
> To simplify that, let's add a new .gettstamp() operation in
> struct proto_ops, and move ioctl implementation into the common
> sock_ioctl()/compat_sock_ioctl_trans() functions that these all go
> through.
>
> We can reuse the sock_get_timestamp() implementation, but generalize
> it so it can deal with both native and compat mode, as well as
> timeval and timespec structures.
>
> Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
> Link: https://lore.kernel.org/lkml/CAK8P3a038aDQQotzua_QtKGhq8O9n+rdiz2=WDCp82ys8eUT+A@mail.gmail.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
For the CAN part:
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Ralf Baechle <ralf@linux-mips.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Gerrit Renker <gerrit@erg.abdn.ac.uk>,
Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Andrew Hendry <andrew.hendry@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Willem de Bruijn <willemb@google.com>,
Deepa Dinamani <deepa.kernel@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hams@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-can@vger.kernel.org, dccp@vger.kernel.org,
linux-wpan@vger.kernel.org, linux-sctp@vger.kernel.org,
linux-x25@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling
Date: Wed, 17 Apr 2019 09:59:55 +0000 [thread overview]
Message-ID: <4eabda4b-d08e-ae29-b3df-0971e909fe9c@pengutronix.de> (raw)
In-Reply-To: <20190416203620.539628-1-arnd@arndb.de>
[-- Attachment #1.1: Type: text/plain, Size: 1449 bytes --]
On 4/16/19 10:32 PM, Arnd Bergmann wrote:
> The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many
> socket protocol handlers, and all of those end up calling the same
> sock_get_timestamp()/sock_get_timestampns() helper functions, which
> results in a lot of duplicate code.
>
> With the introduction of 64-bit time_t on 32-bit architectures, this
> gets worse, as we then need four different ioctl commands in each
> socket protocol implementation.
>
> To simplify that, let's add a new .gettstamp() operation in
> struct proto_ops, and move ioctl implementation into the common
> sock_ioctl()/compat_sock_ioctl_trans() functions that these all go
> through.
>
> We can reuse the sock_get_timestamp() implementation, but generalize
> it so it can deal with both native and compat mode, as well as
> timeval and timespec structures.
>
> Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
> Link: https://lore.kernel.org/lkml/CAK8P3a038aDQQotzua_QtKGhq8O9n+rdiz2=WDCp82ys8eUT+A@mail.gmail.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
For the CAN part:
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: dccp@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling
Date: Wed, 17 Apr 2019 09:59:55 +0000 [thread overview]
Message-ID: <4eabda4b-d08e-ae29-b3df-0971e909fe9c@pengutronix.de> (raw)
In-Reply-To: <20180829130308.3504560-1-arnd@arndb.de>
[-- Attachment #1.1: Type: text/plain, Size: 1449 bytes --]
On 4/16/19 10:32 PM, Arnd Bergmann wrote:
> The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many
> socket protocol handlers, and all of those end up calling the same
> sock_get_timestamp()/sock_get_timestampns() helper functions, which
> results in a lot of duplicate code.
>
> With the introduction of 64-bit time_t on 32-bit architectures, this
> gets worse, as we then need four different ioctl commands in each
> socket protocol implementation.
>
> To simplify that, let's add a new .gettstamp() operation in
> struct proto_ops, and move ioctl implementation into the common
> sock_ioctl()/compat_sock_ioctl_trans() functions that these all go
> through.
>
> We can reuse the sock_get_timestamp() implementation, but generalize
> it so it can deal with both native and compat mode, as well as
> timeval and timespec structures.
>
> Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
> Link: https://lore.kernel.org/lkml/CAK8P3a038aDQQotzua_QtKGhq8O9n+rdiz2=WDCp82ys8eUT+A@mail.gmail.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
For the CAN part:
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-04-17 9:59 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 20:32 [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling Arnd Bergmann
2019-04-16 20:32 ` Arnd Bergmann
2019-04-16 20:32 ` Arnd Bergmann
2019-04-16 20:32 ` Arnd Bergmann
2019-04-16 20:32 ` [PATCH net-next 2/3] asm-generic: generalize asm/sockios.h Arnd Bergmann
2019-04-16 20:32 ` Arnd Bergmann
2019-04-16 20:32 ` [PATCH net-next 3/3] net: socket: implement 64-bit timestamps Arnd Bergmann
2019-04-16 20:32 ` Arnd Bergmann
2019-04-17 9:35 ` [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling Neil Horman
2019-04-17 9:35 ` Neil Horman
2019-04-17 9:35 ` Neil Horman
2019-04-17 9:35 ` Neil Horman
2019-04-17 9:35 ` Neil Horman
2019-04-17 17:21 ` David Miller
2019-04-17 17:21 ` David Miller
2019-04-17 17:21 ` David Miller
2019-04-17 20:15 ` Neil Horman
2019-04-17 20:15 ` Neil Horman
2019-04-17 20:15 ` Neil Horman
2019-04-17 9:59 ` Marc Kleine-Budde [this message]
2019-04-17 9:59 ` Marc Kleine-Budde
2019-04-17 9:59 ` Marc Kleine-Budde
2019-04-17 14:46 ` Willem de Bruijn
2019-04-17 14:46 ` Willem de Bruijn
2019-04-17 14:46 ` Willem de Bruijn
2019-04-17 14:46 ` Willem de Bruijn
2019-04-17 14:46 ` Willem de Bruijn
2019-04-17 16:19 ` Arnd Bergmann
2019-04-17 16:19 ` Arnd Bergmann
2019-04-17 16:19 ` Arnd Bergmann
2019-04-17 16:19 ` Arnd Bergmann
2019-04-17 18:16 ` Willem de Bruijn
2019-04-17 18:16 ` Willem de Bruijn
2019-04-17 18:16 ` Willem de Bruijn
2019-04-17 18:16 ` Willem de Bruijn
-- strict thread matches above, loose matches on Subject: below --
2018-08-29 12:59 Arnd Bergmann
2018-08-29 12:59 ` Arnd Bergmann
2018-08-29 12:59 ` Arnd Bergmann
2018-08-29 12:59 ` [PATCH net-next 2/3] asm-generic: generalize asm/sockios.h Arnd Bergmann
2018-08-29 12:59 ` Arnd Bergmann
2018-08-29 13:11 ` [PATCH net-next 3/3] net: socket: implement 64-bit timestamps Arnd Bergmann
2018-08-29 13:11 ` Arnd Bergmann
2018-08-30 20:09 ` [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling Willem de Bruijn
2018-08-30 20:09 ` Willem de Bruijn
2018-08-30 20:09 ` Willem de Bruijn
2018-08-31 10:31 ` Arnd Bergmann
2018-08-31 10:31 ` Arnd Bergmann
2018-08-31 10:31 ` Arnd Bergmann
2018-08-31 13:37 ` Willem de Bruijn
2018-08-31 13:37 ` Willem de Bruijn
2018-08-31 13:37 ` Willem de Bruijn
2018-08-31 14:00 ` Arnd Bergmann
2018-08-31 14:00 ` Arnd Bergmann
2018-08-31 14:00 ` Arnd Bergmann
2018-08-31 15:08 ` Willem de Bruijn
2018-08-31 15:08 ` Willem de Bruijn
2018-08-31 15:08 ` Willem de Bruijn
2018-09-13 12:28 ` Arnd Bergmann
2018-09-13 12:28 ` Arnd Bergmann
2018-09-13 12:28 ` Arnd Bergmann
2018-09-21 9:14 ` Stefan Schmidt
2018-09-21 9:14 ` Stefan Schmidt
2018-09-21 9:14 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eabda4b-d08e-ae29-b3df-0971e909fe9c@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=alex.aring@gmail.com \
--cc=andrew.hendry@gmail.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=deepa.kernel@gmail.com \
--cc=edumazet@google.com \
--cc=gerrit@erg.abdn.ac.uk \
--cc=johan.hedberg@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=ralf@linux-mips.org \
--cc=socketcan@hartkopp.net \
--cc=stefan@datenfreihafen.org \
--cc=vyasevich@gmail.com \
--cc=willemb@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.